From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A9EE7C for ; Mon, 19 Sep 2022 15:19:53 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 57FAA499; Mon, 19 Sep 2022 17:19:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663600791; bh=PQGPD6rFfQ4c9/wXNerOZd6lDaZMOvrBsAqiWgV3tp4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IN7WVwhttqy9kKXcxIP20OMJA/V4fQBWil7pAMKkG4AXtYpceTw0TlNljB0cvxArg j84YQ52vuqaWmmH8XoIwtQDvRnjs6BaIjUEnRbNhEPsnQoe+SVh2sbQey79MGxtSGd BVX8UoQgAKAq5H8L+7APt1mi8Zwpf4AbIFAIkNL8= Date: Mon, 19 Sep 2022 18:19:38 +0300 From: Laurent Pinchart To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Arnd Bergmann , Benson Leung , Cai Huoqing , chrome-platform@lists.linux.dev, Chun-Kuang Hu , Dafna Hirschfeld , Daniel Vetter , David Airlie , Enric Balletbo i Serra , Guenter Roeck , Jitao Shi , Kieran Bingham , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Maarten Lankhorst , Matthias Brugger , Maxime Ripard , Philip Chen , Philipp Zabel , Thomas Zimmermann , Tomi Valkeinen Subject: Re: [PATCH v1 04/12] drm/bridge: Drop drm_bridge_chain_mode_fixup Message-ID: References: <20220717174454.46616-1-sam@ravnborg.org> <20220717174454.46616-5-sam@ravnborg.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220717174454.46616-5-sam@ravnborg.org> Hi Sam, Thank you for the patch. On Sun, Jul 17, 2022 at 07:44:46PM +0200, Sam Ravnborg wrote: > There are no users left of drm_bridge_chain_mode_fixup() and we > do not want to have this function available, so drop it. > > Signed-off-by: Sam Ravnborg > Reviewed-by: Maxime Ripard > Cc: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_bridge.c | 37 ------------------------------------ > include/drm/drm_bridge.h | 3 --- > 2 files changed, 40 deletions(-) > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > index bb7fc09267af..b6f56d8f3547 100644 > --- a/drivers/gpu/drm/drm_bridge.c > +++ b/drivers/gpu/drm/drm_bridge.c > @@ -430,43 +430,6 @@ void drm_bridge_detach(struct drm_bridge *bridge) > * needed, in order to gradually transition to the new model. > */ > > -/** > - * drm_bridge_chain_mode_fixup - fixup proposed mode for all bridges in the > - * encoder chain > - * @bridge: bridge control structure > - * @mode: desired mode to be set for the bridge > - * @adjusted_mode: updated mode that works for this bridge > - * > - * Calls &drm_bridge_funcs.mode_fixup for all the bridges in the > - * encoder chain, starting from the first bridge to the last. > - * > - * Note: the bridge passed should be the one closest to the encoder > - * > - * RETURNS: > - * true on success, false on failure > - */ > -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > -{ > - struct drm_encoder *encoder; > - > - if (!bridge) > - return true; > - > - encoder = bridge->encoder; > - list_for_each_entry_from(bridge, &encoder->bridge_chain, chain_node) { > - if (!bridge->funcs->mode_fixup) > - continue; > - > - if (!bridge->funcs->mode_fixup(bridge, mode, adjusted_mode)) > - return false; > - } > - > - return true; > -} > -EXPORT_SYMBOL(drm_bridge_chain_mode_fixup); > - > /** > * drm_bridge_chain_mode_valid - validate the mode against all bridges in the > * encoder chain. > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 1eca9c4c3346..7496f41535b1 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -845,9 +845,6 @@ drm_bridge_chain_get_first_bridge(struct drm_encoder *encoder) > #define drm_for_each_bridge_in_chain(encoder, bridge) \ > list_for_each_entry(bridge, &(encoder)->bridge_chain, chain_node) > > -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode); > enum drm_mode_status > drm_bridge_chain_mode_valid(struct drm_bridge *bridge, > const struct drm_display_info *info, -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 870A2C54EE9 for ; Mon, 19 Sep 2022 15:29:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vmbl7fAo74+UY5ZK52lEdv7z9Gr7TdO4H9v5Na/9loM=; b=MkRTECa26ABFsj RY/iLNgYayPQumAWTmAvhM2Zz6eUMbEiGLYkmLe1mGf2vt4wXl5hpGrpRGq0a5m0YCDpdFmYzXkZh e9EMKzo9MoXFPQ335vgJ8f4HtiegDI1MmYnoWEz6N/JBz2LPb7bzQNw1sz1Nrk2cr4RWgUP+qzp9C 5VW+XtkLgPU4zcpJL73CwjnR+NgUDczLnUAz0ztm8Srijtvg02wU9mKdgP6/+jAOzjq8RBfJEehlF qFZjO6uoguUoCqyj6uXNz0MBe3KbRliqJmIi89S9h20ZY6EAANDTMfjt/bAX0eA0h+gNw9BiKVX/M 3wed+Nv0+/v5csMMCFLw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaIhK-00CSfM-P9; Mon, 19 Sep 2022 15:28:39 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaIYq-00CO9E-Vb; Mon, 19 Sep 2022 15:19:55 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 57FAA499; Mon, 19 Sep 2022 17:19:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663600791; bh=PQGPD6rFfQ4c9/wXNerOZd6lDaZMOvrBsAqiWgV3tp4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IN7WVwhttqy9kKXcxIP20OMJA/V4fQBWil7pAMKkG4AXtYpceTw0TlNljB0cvxArg j84YQ52vuqaWmmH8XoIwtQDvRnjs6BaIjUEnRbNhEPsnQoe+SVh2sbQey79MGxtSGd BVX8UoQgAKAq5H8L+7APt1mi8Zwpf4AbIFAIkNL8= Date: Mon, 19 Sep 2022 18:19:38 +0300 From: Laurent Pinchart To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Arnd Bergmann , Benson Leung , Cai Huoqing , chrome-platform@lists.linux.dev, Chun-Kuang Hu , Dafna Hirschfeld , Daniel Vetter , David Airlie , Enric Balletbo i Serra , Guenter Roeck , Jitao Shi , Kieran Bingham , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Maarten Lankhorst , Matthias Brugger , Maxime Ripard , Philip Chen , Philipp Zabel , Thomas Zimmermann , Tomi Valkeinen Subject: Re: [PATCH v1 04/12] drm/bridge: Drop drm_bridge_chain_mode_fixup Message-ID: References: <20220717174454.46616-1-sam@ravnborg.org> <20220717174454.46616-5-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220717174454.46616-5-sam@ravnborg.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220919_081953_448289_65A80792 X-CRM114-Status: GOOD ( 20.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Sun, Jul 17, 2022 at 07:44:46PM +0200, Sam Ravnborg wrote: > There are no users left of drm_bridge_chain_mode_fixup() and we > do not want to have this function available, so drop it. > > Signed-off-by: Sam Ravnborg > Reviewed-by: Maxime Ripard > Cc: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_bridge.c | 37 ------------------------------------ > include/drm/drm_bridge.h | 3 --- > 2 files changed, 40 deletions(-) > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > index bb7fc09267af..b6f56d8f3547 100644 > --- a/drivers/gpu/drm/drm_bridge.c > +++ b/drivers/gpu/drm/drm_bridge.c > @@ -430,43 +430,6 @@ void drm_bridge_detach(struct drm_bridge *bridge) > * needed, in order to gradually transition to the new model. > */ > > -/** > - * drm_bridge_chain_mode_fixup - fixup proposed mode for all bridges in the > - * encoder chain > - * @bridge: bridge control structure > - * @mode: desired mode to be set for the bridge > - * @adjusted_mode: updated mode that works for this bridge > - * > - * Calls &drm_bridge_funcs.mode_fixup for all the bridges in the > - * encoder chain, starting from the first bridge to the last. > - * > - * Note: the bridge passed should be the one closest to the encoder > - * > - * RETURNS: > - * true on success, false on failure > - */ > -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > -{ > - struct drm_encoder *encoder; > - > - if (!bridge) > - return true; > - > - encoder = bridge->encoder; > - list_for_each_entry_from(bridge, &encoder->bridge_chain, chain_node) { > - if (!bridge->funcs->mode_fixup) > - continue; > - > - if (!bridge->funcs->mode_fixup(bridge, mode, adjusted_mode)) > - return false; > - } > - > - return true; > -} > -EXPORT_SYMBOL(drm_bridge_chain_mode_fixup); > - > /** > * drm_bridge_chain_mode_valid - validate the mode against all bridges in the > * encoder chain. > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 1eca9c4c3346..7496f41535b1 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -845,9 +845,6 @@ drm_bridge_chain_get_first_bridge(struct drm_encoder *encoder) > #define drm_for_each_bridge_in_chain(encoder, bridge) \ > list_for_each_entry(bridge, &(encoder)->bridge_chain, chain_node) > > -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode); > enum drm_mode_status > drm_bridge_chain_mode_valid(struct drm_bridge *bridge, > const struct drm_display_info *info, -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4419ECAAD3 for ; Mon, 19 Sep 2022 15:20:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7678D10E66E; Mon, 19 Sep 2022 15:20:09 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id D737C10E66B for ; Mon, 19 Sep 2022 15:19:52 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 57FAA499; Mon, 19 Sep 2022 17:19:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663600791; bh=PQGPD6rFfQ4c9/wXNerOZd6lDaZMOvrBsAqiWgV3tp4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IN7WVwhttqy9kKXcxIP20OMJA/V4fQBWil7pAMKkG4AXtYpceTw0TlNljB0cvxArg j84YQ52vuqaWmmH8XoIwtQDvRnjs6BaIjUEnRbNhEPsnQoe+SVh2sbQey79MGxtSGd BVX8UoQgAKAq5H8L+7APt1mi8Zwpf4AbIFAIkNL8= Date: Mon, 19 Sep 2022 18:19:38 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 04/12] drm/bridge: Drop drm_bridge_chain_mode_fixup Message-ID: References: <20220717174454.46616-1-sam@ravnborg.org> <20220717174454.46616-5-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220717174454.46616-5-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dafna Hirschfeld , Neil Armstrong , David Airlie , Tomi Valkeinen , dri-devel@lists.freedesktop.org, Andrzej Hajda , Guenter Roeck , chrome-platform@lists.linux.dev, Jernej Skrabec , Chun-Kuang Hu , Jitao Shi , Arnd Bergmann , Jonas Karlman , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Philip Chen , Thomas Zimmermann , Robert Foss , linux-renesas-soc@vger.kernel.org, Kieran Bingham , Enric Balletbo i Serra , Cai Huoqing Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, Thank you for the patch. On Sun, Jul 17, 2022 at 07:44:46PM +0200, Sam Ravnborg wrote: > There are no users left of drm_bridge_chain_mode_fixup() and we > do not want to have this function available, so drop it. > > Signed-off-by: Sam Ravnborg > Reviewed-by: Maxime Ripard > Cc: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thomas Zimmermann > Cc: David Airlie > Cc: Daniel Vetter Reviewed-by: Laurent Pinchart > --- > drivers/gpu/drm/drm_bridge.c | 37 ------------------------------------ > include/drm/drm_bridge.h | 3 --- > 2 files changed, 40 deletions(-) > > diff --git a/drivers/gpu/drm/drm_bridge.c b/drivers/gpu/drm/drm_bridge.c > index bb7fc09267af..b6f56d8f3547 100644 > --- a/drivers/gpu/drm/drm_bridge.c > +++ b/drivers/gpu/drm/drm_bridge.c > @@ -430,43 +430,6 @@ void drm_bridge_detach(struct drm_bridge *bridge) > * needed, in order to gradually transition to the new model. > */ > > -/** > - * drm_bridge_chain_mode_fixup - fixup proposed mode for all bridges in the > - * encoder chain > - * @bridge: bridge control structure > - * @mode: desired mode to be set for the bridge > - * @adjusted_mode: updated mode that works for this bridge > - * > - * Calls &drm_bridge_funcs.mode_fixup for all the bridges in the > - * encoder chain, starting from the first bridge to the last. > - * > - * Note: the bridge passed should be the one closest to the encoder > - * > - * RETURNS: > - * true on success, false on failure > - */ > -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > -{ > - struct drm_encoder *encoder; > - > - if (!bridge) > - return true; > - > - encoder = bridge->encoder; > - list_for_each_entry_from(bridge, &encoder->bridge_chain, chain_node) { > - if (!bridge->funcs->mode_fixup) > - continue; > - > - if (!bridge->funcs->mode_fixup(bridge, mode, adjusted_mode)) > - return false; > - } > - > - return true; > -} > -EXPORT_SYMBOL(drm_bridge_chain_mode_fixup); > - > /** > * drm_bridge_chain_mode_valid - validate the mode against all bridges in the > * encoder chain. > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 1eca9c4c3346..7496f41535b1 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -845,9 +845,6 @@ drm_bridge_chain_get_first_bridge(struct drm_encoder *encoder) > #define drm_for_each_bridge_in_chain(encoder, bridge) \ > list_for_each_entry(bridge, &(encoder)->bridge_chain, chain_node) > > -bool drm_bridge_chain_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode); > enum drm_mode_status > drm_bridge_chain_mode_valid(struct drm_bridge *bridge, > const struct drm_display_info *info, -- Regards, Laurent Pinchart