From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CEC37C for ; Mon, 19 Sep 2022 15:31:45 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4867D499; Mon, 19 Sep 2022 17:31:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663601503; bh=xj+FXHZun7Tq2dFujf6besSXQvCHP1Rn25a1rvSb5ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kbgwRAU2yAb5P6lfEc4xG6kfAJyc+96nTqzByEhr8ACzvuioMONQQ0p9+sLB9lcKg n86vQt8oXnNUst7jy1xSUN4Uq1gnJYpTzE6o35wFzWEc4z+ELb+iIxWGKBRWDxZiSu bdtZB8khxJkL/kFnzjH8V2IkgPMgsnzhsYqpnjjU= Date: Mon, 19 Sep 2022 18:31:30 +0300 From: Laurent Pinchart To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Arnd Bergmann , Benson Leung , Cai Huoqing , chrome-platform@lists.linux.dev, Chun-Kuang Hu , Dafna Hirschfeld , Daniel Vetter , David Airlie , Enric Balletbo i Serra , Guenter Roeck , Jitao Shi , Kieran Bingham , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Maarten Lankhorst , Matthias Brugger , Maxime Ripard , Philip Chen , Philipp Zabel , Thomas Zimmermann , Tomi Valkeinen Subject: Re: [PATCH v1 09/12] drm/rcar-du: lvds: Use drm_bridge_funcs.atomic_check Message-ID: References: <20220717174454.46616-1-sam@ravnborg.org> <20220717175801.78668-1-sam@ravnborg.org> <20220717175801.78668-2-sam@ravnborg.org> Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220717175801.78668-2-sam@ravnborg.org> Hi Sam, Thank you for the patch. On Sun, Jul 17, 2022 at 07:57:58PM +0200, Sam Ravnborg wrote: > Replace the deprecated drm_bridge_funcs.mode_fixup() with > drm_bridge_funcs.atomic_check(). > The driver implements the state operations, so no other changes > are required for the replacement. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: linux-renesas-soc@vger.kernel.org Reviewed-by: Laurent Pinchart I assume you'll merge this through drm-misc with the rest of the series, so I won't take it in my tree unless you ask me so. > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index 830aac0a2cb4..c4adbcede090 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -554,10 +554,12 @@ static void rcar_lvds_atomic_disable(struct drm_bridge *bridge, > clk_disable_unprepare(lvds->clocks.mod); > } > > -static bool rcar_lvds_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > +static int rcar_lvds_atomic_check(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state) > { > + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; > struct rcar_lvds *lvds = bridge_to_rcar_lvds(bridge); > int min_freq; > > @@ -569,7 +571,7 @@ static bool rcar_lvds_mode_fixup(struct drm_bridge *bridge, > min_freq = lvds->info->quirks & RCAR_LVDS_QUIRK_EXT_PLL ? 5000 : 31000; > adjusted_mode->clock = clamp(adjusted_mode->clock, min_freq, 148500); > > - return true; > + return 0; > } > > static int rcar_lvds_attach(struct drm_bridge *bridge, > @@ -591,7 +593,7 @@ static const struct drm_bridge_funcs rcar_lvds_bridge_ops = { > .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_enable = rcar_lvds_atomic_enable, > .atomic_disable = rcar_lvds_atomic_disable, > - .mode_fixup = rcar_lvds_mode_fixup, > + .atomic_check = rcar_lvds_atomic_check, > }; > > bool rcar_lvds_dual_link(struct drm_bridge *bridge) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82A60ECAAD3 for ; Mon, 19 Sep 2022 15:43:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=49UGqywDgyF16Xt/sb0kOtCj4hCoz1Oevbpt24Xg5ds=; b=BnmqLQ47/6bKSb 2wpkVCgjsc479z9I8REq4Vgwz5Wo1o6Oq/PWj0/qYsOnicW1EPWZ6IoGlhUl6dbtDY4+UvU3hVpPs o/WsXMxQYNZW33WaWsp7hqb1tO2l8vIOwXzoDryGMQuG1TkJ2zasugjYAHbx3JMsd+YXLRgl0XZHT qsrd2xWKHZKrtfPO/Ofc5ZFH46WnboADgSThnUYuqnk+0JWkPgDz3lgRT91Qr6N2koEAGGduCqP/A +mkW6AB8tb0Mcj04gSoY0MdFrr1jAFk6/yg8A3acoE9Pdh6vsTd3/Kn+0mxyOnTL+hDyxntqaKEc8 mQDoit6ifA9fPgkaKILQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaIun-00CabJ-27; Mon, 19 Sep 2022 15:42:33 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oaIkL-00CUJ8-0F; Mon, 19 Sep 2022 15:31:46 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4867D499; Mon, 19 Sep 2022 17:31:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663601503; bh=xj+FXHZun7Tq2dFujf6besSXQvCHP1Rn25a1rvSb5ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kbgwRAU2yAb5P6lfEc4xG6kfAJyc+96nTqzByEhr8ACzvuioMONQQ0p9+sLB9lcKg n86vQt8oXnNUst7jy1xSUN4Uq1gnJYpTzE6o35wFzWEc4z+ELb+iIxWGKBRWDxZiSu bdtZB8khxJkL/kFnzjH8V2IkgPMgsnzhsYqpnjjU= Date: Mon, 19 Sep 2022 18:31:30 +0300 From: Laurent Pinchart To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Andrzej Hajda , Neil Armstrong , Robert Foss , Jonas Karlman , Jernej Skrabec , Arnd Bergmann , Benson Leung , Cai Huoqing , chrome-platform@lists.linux.dev, Chun-Kuang Hu , Dafna Hirschfeld , Daniel Vetter , David Airlie , Enric Balletbo i Serra , Guenter Roeck , Jitao Shi , Kieran Bingham , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, Maarten Lankhorst , Matthias Brugger , Maxime Ripard , Philip Chen , Philipp Zabel , Thomas Zimmermann , Tomi Valkeinen Subject: Re: [PATCH v1 09/12] drm/rcar-du: lvds: Use drm_bridge_funcs.atomic_check Message-ID: References: <20220717174454.46616-1-sam@ravnborg.org> <20220717175801.78668-1-sam@ravnborg.org> <20220717175801.78668-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220717175801.78668-2-sam@ravnborg.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220919_083145_380535_5B90E0EF X-CRM114-Status: GOOD ( 19.99 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Sun, Jul 17, 2022 at 07:57:58PM +0200, Sam Ravnborg wrote: > Replace the deprecated drm_bridge_funcs.mode_fixup() with > drm_bridge_funcs.atomic_check(). > The driver implements the state operations, so no other changes > are required for the replacement. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: linux-renesas-soc@vger.kernel.org Reviewed-by: Laurent Pinchart I assume you'll merge this through drm-misc with the rest of the series, so I won't take it in my tree unless you ask me so. > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index 830aac0a2cb4..c4adbcede090 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -554,10 +554,12 @@ static void rcar_lvds_atomic_disable(struct drm_bridge *bridge, > clk_disable_unprepare(lvds->clocks.mod); > } > > -static bool rcar_lvds_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > +static int rcar_lvds_atomic_check(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state) > { > + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; > struct rcar_lvds *lvds = bridge_to_rcar_lvds(bridge); > int min_freq; > > @@ -569,7 +571,7 @@ static bool rcar_lvds_mode_fixup(struct drm_bridge *bridge, > min_freq = lvds->info->quirks & RCAR_LVDS_QUIRK_EXT_PLL ? 5000 : 31000; > adjusted_mode->clock = clamp(adjusted_mode->clock, min_freq, 148500); > > - return true; > + return 0; > } > > static int rcar_lvds_attach(struct drm_bridge *bridge, > @@ -591,7 +593,7 @@ static const struct drm_bridge_funcs rcar_lvds_bridge_ops = { > .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_enable = rcar_lvds_atomic_enable, > .atomic_disable = rcar_lvds_atomic_disable, > - .mode_fixup = rcar_lvds_mode_fixup, > + .atomic_check = rcar_lvds_atomic_check, > }; > > bool rcar_lvds_dual_link(struct drm_bridge *bridge) -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CE79AC6FA86 for ; Mon, 19 Sep 2022 15:31:48 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9725A10E686; Mon, 19 Sep 2022 15:31:47 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id D962710E686 for ; Mon, 19 Sep 2022 15:31:44 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4867D499; Mon, 19 Sep 2022 17:31:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663601503; bh=xj+FXHZun7Tq2dFujf6besSXQvCHP1Rn25a1rvSb5ck=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kbgwRAU2yAb5P6lfEc4xG6kfAJyc+96nTqzByEhr8ACzvuioMONQQ0p9+sLB9lcKg n86vQt8oXnNUst7jy1xSUN4Uq1gnJYpTzE6o35wFzWEc4z+ELb+iIxWGKBRWDxZiSu bdtZB8khxJkL/kFnzjH8V2IkgPMgsnzhsYqpnjjU= Date: Mon, 19 Sep 2022 18:31:30 +0300 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v1 09/12] drm/rcar-du: lvds: Use drm_bridge_funcs.atomic_check Message-ID: References: <20220717174454.46616-1-sam@ravnborg.org> <20220717175801.78668-1-sam@ravnborg.org> <20220717175801.78668-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220717175801.78668-2-sam@ravnborg.org> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dafna Hirschfeld , Neil Armstrong , David Airlie , Tomi Valkeinen , dri-devel@lists.freedesktop.org, Andrzej Hajda , Guenter Roeck , chrome-platform@lists.linux.dev, Jernej Skrabec , Chun-Kuang Hu , Jitao Shi , Arnd Bergmann , Jonas Karlman , linux-mediatek@lists.infradead.org, Matthias Brugger , linux-arm-kernel@lists.infradead.org, Philip Chen , Thomas Zimmermann , Robert Foss , linux-renesas-soc@vger.kernel.org, Kieran Bingham , Enric Balletbo i Serra , Cai Huoqing Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Sam, Thank you for the patch. On Sun, Jul 17, 2022 at 07:57:58PM +0200, Sam Ravnborg wrote: > Replace the deprecated drm_bridge_funcs.mode_fixup() with > drm_bridge_funcs.atomic_check(). > The driver implements the state operations, so no other changes > are required for the replacement. > > Signed-off-by: Sam Ravnborg > Cc: Laurent Pinchart > Cc: Kieran Bingham > Cc: linux-renesas-soc@vger.kernel.org Reviewed-by: Laurent Pinchart I assume you'll merge this through drm-misc with the rest of the series, so I won't take it in my tree unless you ask me so. > --- > drivers/gpu/drm/rcar-du/rcar_lvds.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_lvds.c b/drivers/gpu/drm/rcar-du/rcar_lvds.c > index 830aac0a2cb4..c4adbcede090 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_lvds.c > +++ b/drivers/gpu/drm/rcar-du/rcar_lvds.c > @@ -554,10 +554,12 @@ static void rcar_lvds_atomic_disable(struct drm_bridge *bridge, > clk_disable_unprepare(lvds->clocks.mod); > } > > -static bool rcar_lvds_mode_fixup(struct drm_bridge *bridge, > - const struct drm_display_mode *mode, > - struct drm_display_mode *adjusted_mode) > +static int rcar_lvds_atomic_check(struct drm_bridge *bridge, > + struct drm_bridge_state *bridge_state, > + struct drm_crtc_state *crtc_state, > + struct drm_connector_state *conn_state) > { > + struct drm_display_mode *adjusted_mode = &crtc_state->adjusted_mode; > struct rcar_lvds *lvds = bridge_to_rcar_lvds(bridge); > int min_freq; > > @@ -569,7 +571,7 @@ static bool rcar_lvds_mode_fixup(struct drm_bridge *bridge, > min_freq = lvds->info->quirks & RCAR_LVDS_QUIRK_EXT_PLL ? 5000 : 31000; > adjusted_mode->clock = clamp(adjusted_mode->clock, min_freq, 148500); > > - return true; > + return 0; > } > > static int rcar_lvds_attach(struct drm_bridge *bridge, > @@ -591,7 +593,7 @@ static const struct drm_bridge_funcs rcar_lvds_bridge_ops = { > .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_enable = rcar_lvds_atomic_enable, > .atomic_disable = rcar_lvds_atomic_disable, > - .mode_fixup = rcar_lvds_mode_fixup, > + .atomic_check = rcar_lvds_atomic_check, > }; > > bool rcar_lvds_dual_link(struct drm_bridge *bridge) -- Regards, Laurent Pinchart