From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D089ECAAA1 for ; Mon, 19 Sep 2022 22:18:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229745AbiISWSy (ORCPT ); Mon, 19 Sep 2022 18:18:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37948 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229473AbiISWSx (ORCPT ); Mon, 19 Sep 2022 18:18:53 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD9140E1C for ; Mon, 19 Sep 2022 15:18:52 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B167C6DB; Tue, 20 Sep 2022 00:18:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1663625930; bh=x/5huv2a2aX3hXbCOlz1gR+ksdpPXMxshcLXdTbAaaA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oTeP0g3px4/lkpvU99KpYLp/TveIncZaSjKijSf5I+/ra+yPjHHa/P54tlpuzoBSH 83nUlcid7R0HDudQtbDJLMPVSwUh6rkFiajkZeNusHdOsCbk/qX1QZukoxjiKXO9u7 KQ6lxIc7F7jrWLfV+PVt1tNcUBZD+l3SvN2gMCI0= Date: Tue, 20 Sep 2022 01:18:36 +0300 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org Subject: Re: [PATCH v2 1/1] media: v4l: subdev: Document s_power() callback is deprecated Message-ID: References: <20220919221641.3801108-1-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220919221641.3801108-1-sakari.ailus@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Sep 20, 2022 at 01:16:41AM +0300, Sakari Ailus wrote: > Runtime PM has been around for a decade or more, there's hardly a need to > use the V4L2 specific s_power() callback in drivers anymore. Document this > in s_power() callback documentation as well. > > Signed-off-by: Sakari Ailus > Reviewed-by: Laurent Pinchart > --- > include/media/v4l2-subdev.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/media/v4l2-subdev.h b/include/media/v4l2-subdev.h > index 2f80c9c818ed0..54566d139da79 100644 > --- a/include/media/v4l2-subdev.h > +++ b/include/media/v4l2-subdev.h > @@ -176,7 +176,10 @@ struct v4l2_subdev_io_pin_config { > * @s_register: callback for VIDIOC_DBG_S_REGISTER() ioctl handler code. > * > * @s_power: puts subdevice in power saving mode (on == 0) or normal operation > - * mode (on == 1). > + * mode (on == 1). DEPRECATED. See > + * Documentation/driver-api/media/camera-sensor.rst . pre_streamon and Extra space before '.' > + * post_streamoff callbacks can be used for e.g. setting the bus to LP-11 > + * mode before s_stream is called. Technically post_streamoff doesn't really match that description, but that's OK. > * > * @interrupt_service_routine: Called by the bridge chip's interrupt service > * handler, when an interrupt status has be raised due to this subdev, -- Regards, Laurent Pinchart