From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Yunlong Jia <yunlong.jia@ecs.corp-partner.google.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
Henry Sun <henrysun@google.com>,
Douglas Anderson <dianders@chromium.org>,
Bob Moragues <moragues@chromium.org>,
Yunlong Jia <yunlong.jia@ecs.com.tw>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Johnny Chuang <johnny.chuang.emc@gmail.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3 2/2] input: touchscreen: elants_i2c: Add eth3915n touchscreen chip
Date: Mon, 19 Sep 2022 21:19:59 -0700 [thread overview]
Message-ID: <Yyk/b29aG2ivpkf5@google.com> (raw)
In-Reply-To: <20220909102720.v3.2.I22ae48d8ee064456073a828393704809360c4368@changeid>
Hi Yunlong,
On Fri, Sep 09, 2022 at 10:27:55AM +0000, Yunlong Jia wrote:
> The eth3915n requires more delay time than the eth3500 when poweron
> & reset.
> Define EKTH3915_POWERON_DELAY_MSEC as the poweron delay time of eth3915n,
> about 80ms.
> Define EKTH3915_RESET_DELAY_MSEC as the reset delay time of eth3915n,
> about 300ms.
>
> Signed-off-by: Yunlong Jia <yunlong.jia@ecs.com.tw>
> Reviewed-by: Douglas Anderson <dianders@chromium.org>
>
> ---
>
> Changes in v3:
> 1. Add poweron delay time.
This materially changes the patch so I do not believe you should have
kept Doug's reviewed-by tag. I also do not understand what this delay is
for. Is this the minimal time for the reset line to stay high? Something
else?
Thanks.
--
Dmitry
next prev parent reply other threads:[~2022-09-20 4:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-09 10:27 [PATCH v3 1/2] dt-bindings: input: touchscreen: elants_i2c: Add eth3915n touchscreen chip Yunlong Jia
2022-09-09 10:27 ` [PATCH v3 2/2] " Yunlong Jia
2022-09-10 21:53 ` Doug Anderson
2022-09-20 4:19 ` Dmitry Torokhov [this message]
[not found] ` <CAFvdKjuBFoKXmU9zN8vQ65LT3=MMX-_3vhay16uhN3Z05QN6eA@mail.gmail.com>
2022-09-20 14:24 ` Doug Anderson
2022-09-10 21:52 ` [PATCH v3 1/2] dt-bindings: " Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyk/b29aG2ivpkf5@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=henrysun@google.com \
--cc=johnny.chuang.emc@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=moragues@chromium.org \
--cc=yunlong.jia@ecs.com.tw \
--cc=yunlong.jia@ecs.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.