From: Jarkko Sakkinen <jarkko@kernel.org>
To: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: dhowells@redhat.com, paul@paul-moore.com, jmorris@namei.org,
serge@hallyn.com, akpm@linux-foundation.org, alan@redhat.com,
keyrings@vger.kernel.org, linux-security-module@vger.kernel.org
Subject: Re: [PATCH v2] KEYS: Remove orphan declarations from security/keys/internal.h
Date: Tue, 20 Sep 2022 07:49:04 +0300 [thread overview]
Message-ID: <YylGQAOtxolniRS0@kernel.org> (raw)
In-Reply-To: <20220913014613.524253-1-cuigaosheng1@huawei.com>
On Tue, Sep 13, 2022 at 09:46:13AM +0800, Gaosheng Cui wrote:
> Remove the following orphan declarations from security/keys/internal.h:
> 1. request_key_conswq has been removed since
> commit 76181c134f87 ("KEYS: Make request_key() and co fundamentally
> asynchronous").
>
> 2. keyring_search_instkey() has been removed since
> commit b5f545c880a2 ("[PATCH] keys: Permit running process to
> instantiate keys").
>
> Fixes: 76181c134f87 ("KEYS: Make request_key() and co fundamentally asynchronous").
> Fixes: b5f545c880a2 ("[PATCH] keys: Permit running process to instantiate keys").
> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
> ---
> v2:
> - Format the commit messages for the patchk, thanks!
> security/keys/internal.h | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/security/keys/internal.h b/security/keys/internal.h
> index 9b9cf3b6fcbb..6a2fb45c22f8 100644
> --- a/security/keys/internal.h
> +++ b/security/keys/internal.h
> @@ -86,7 +86,6 @@ extern struct kmem_cache *key_jar;
> extern struct rb_root key_serial_tree;
> extern spinlock_t key_serial_lock;
> extern struct mutex key_construction_mutex;
> -extern wait_queue_head_t request_key_conswq;
>
> extern void key_set_index_key(struct keyring_index_key *index_key);
> extern struct key_type *key_type_lookup(const char *type);
> @@ -109,9 +108,6 @@ extern void __key_link_end(struct key *keyring,
> extern key_ref_t find_key_to_update(key_ref_t keyring_ref,
> const struct keyring_index_key *index_key);
>
> -extern struct key *keyring_search_instkey(struct key *keyring,
> - key_serial_t target_id);
> -
> extern int iterate_over_keyring(const struct key *keyring,
> int (*func)(const struct key *key, void *data),
> void *data);
> --
> 2.25.1
>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
BR, Jarkko
prev parent reply other threads:[~2022-09-20 4:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 1:46 [PATCH v2] KEYS: Remove orphan declarations from security/keys/internal.h Gaosheng Cui
2022-09-20 4:49 ` Jarkko Sakkinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YylGQAOtxolniRS0@kernel.org \
--to=jarkko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alan@redhat.com \
--cc=cuigaosheng1@huawei.com \
--cc=dhowells@redhat.com \
--cc=jmorris@namei.org \
--cc=keyrings@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.