From: "Theodore Ts'o" <tytso@mit.edu>
To: Ian Kent <raven@themaw.net>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
Siddhesh Poyarekar <siddhesh@gotplt.org>,
David Howells <dhowells@redhat.com>,
Miklos Szeredi <miklos@szeredi.hu>,
Carlos Maiolino <cmaiolino@redhat.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [REPOST PATCH v3 0/2] vfs: fix a mount table handling problem
Date: Tue, 20 Sep 2022 21:20:56 -0400 [thread overview]
Message-ID: <Yypm+GO6eMdV0QQ0@mit.edu> (raw)
In-Reply-To: <166365872189.39016.10771273319597352356.stgit@donald.themaw.net>
On Tue, Sep 20, 2022 at 03:26:17PM +0800, Ian Kent wrote:
> Whenever a mount has an empty "source" (aka mnt_fsname), the glibc
> function getmntent incorrectly parses its input, resulting in reporting
> incorrect data to the caller.
>
> The problem is that the get_mnt_entry() function in glibc's
> misc/mntent_r.c assumes that leading whitespace on a line can always
> be discarded because it will always be followed by a # for the case
> of a comment or a non-whitespace character that's part of the value
> of the first field. However, this assumption is violated when the
> value of the first field is an empty string.
>
> This is fixed in the mount API code by simply checking for a pointer
> that contains a NULL and treating it as a NULL pointer.
Why not simply have the mount API code disallow a zero-length "source"
/ mnt_fsname?
- Ted
next prev parent reply other threads:[~2022-09-21 1:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 7:26 [REPOST PATCH v3 0/2] vfs: fix a mount table handling problem Ian Kent
2022-09-20 7:26 ` [REPOST PATCH v3 1/2] ext4: fix possible null pointer dereference Ian Kent
2022-09-20 7:26 ` [REPOST PATCH v3 2/2] vfs: parse: deal with zero length string value Ian Kent
2022-10-18 1:55 ` Andrew Morton
2022-10-18 2:07 ` Ian Kent
2022-09-21 1:20 ` Theodore Ts'o [this message]
2022-09-21 4:38 ` [REPOST PATCH v3 0/2] vfs: fix a mount table handling problem Ian Kent
2022-09-21 5:35 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yypm+GO6eMdV0QQ0@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=cmaiolino@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=raven@themaw.net \
--cc=siddhesh@gotplt.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.