From: Kent Gibson <warthog618@gmail.com>
To: Meng Li <Meng.Li@windriver.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpiolib: cdev: Set lineevent_state::irq after IRQ register successfully
Date: Wed, 21 Sep 2022 14:40:26 +0800 [thread overview]
Message-ID: <Yyqx2hhuohVhMo84@sol> (raw)
In-Reply-To: <YyqKfxpAjdSU9r+2@sol>
On Wed, Sep 21, 2022 at 11:52:31AM +0800, Kent Gibson wrote:
> On Wed, Sep 21, 2022 at 11:20:20AM +0800, Meng Li wrote:
> > When running gpio test on nxp-ls1028 platform with below command
> > gpiomon --num-events=3 --rising-edge gpiochip1 25
> > There will be a warning trace as below:
> > Call trace:
> > free_irq+0x204/0x360
> > lineevent_free+0x64/0x70
> > gpio_ioctl+0x598/0x6a0
> > __arm64_sys_ioctl+0xb4/0x100
> > invoke_syscall+0x5c/0x130
> > ......
> > el0t_64_sync+0x1a0/0x1a4
> > The reason of this issue is that calling request_threaded_irq()
> > function failed, and then lineevent_free() is invoked to release
> > the resource. Since the lineevent_state::irq was already set, so
> > the subsequent invocation of free_irq() would trigger the above
> > warning call trace. To fix this issue, set the lineevent_state::irq
> > after the IRQ register successfully.
> >
> > Fixes: 468242724143 ("gpiolib: cdev: refactor lineevent cleanup into lineevent_free")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Meng Li <Meng.Li@windriver.com>
>
> Good pick up - the IRQ shouldn't be freed if it hasn't been successfully requested.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
>
Oops, that should be
Reviewed-by: Kent Gibson <warthog618@gmail.com>
next prev parent reply other threads:[~2022-09-21 6:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 3:20 [PATCH] gpiolib: cdev: Set lineevent_state::irq after IRQ register successfully Meng Li
2022-09-21 3:52 ` Kent Gibson
2022-09-21 6:40 ` Kent Gibson [this message]
2022-09-21 7:33 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yyqx2hhuohVhMo84@sol \
--to=warthog618@gmail.com \
--cc=Meng.Li@windriver.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.