From: Jason Gunthorpe <jgg@ziepe.ca>
To: longli@microsoft.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>,
Haiyang Zhang <haiyangz@microsoft.com>,
Stephen Hemminger <sthemmin@microsoft.com>,
Wei Liu <wei.liu@kernel.org>, Dexuan Cui <decui@microsoft.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Leon Romanovsky <leon@kernel.org>,
edumazet@google.com, shiraz.saleem@intel.com,
Ajay Sharma <sharmaajay@microsoft.com>,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [Patch v6 00/12] Introduce Microsoft Azure Network Adapter (MANA) RDMA driver
Date: Wed, 21 Sep 2022 13:25:25 -0300 [thread overview]
Message-ID: <Yys69cXCOdYL0LTo@ziepe.ca> (raw)
In-Reply-To: <1663723352-598-1-git-send-email-longli@linuxonhyperv.com>
On Tue, Sep 20, 2022 at 06:22:20PM -0700, longli@linuxonhyperv.com wrote:
> From: Long Li <longli@microsoft.com>
>
> This patchset implements a RDMA driver for Microsoft Azure Network
> Adapter (MANA). In MANA, the RDMA device is modeled as an auxiliary device
> to the Ethernet device.
>
> The first 11 patches modify the MANA Ethernet driver to support RDMA driver.
> The last patch implementes the RDMA driver.
>
> The user-mode of the driver is being reviewed at:
> https://github.com/linux-rdma/rdma-core/pull/1177
>
>
> Ajay Sharma (3):
> net: mana: Set the DMA device max segment size
> net: mana: Define and process GDMA response code
> GDMA_STATUS_MORE_ENTRIES
> net: mana: Define data structures for protection domain and memory
> registration
>
> Long Li (9):
> net: mana: Add support for auxiliary device
> net: mana: Record the physical address for doorbell page region
> net: mana: Handle vport sharing between devices
> net: mana: Add functions for allocating doorbell page from GDMA
> net: mana: Export Work Queue functions for use by RDMA driver
> net: mana: Record port number in netdev
> net: mana: Move header files to a common location
> net: mana: Define max values for SGL entries
> RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter
Still some basic checkpatchy stuff:
/tmp/tmpm2fsg47h/0012-RDMA-mana_ib-Add-a-driver-for-Microsoft-Azure-Network-Adapter.patch:412: WARNING: quoted string split across lines
#412: FILE: drivers/infiniband/hw/mana/main.c:70:
+ "vport handle %llx pdid %x doorbell_id %x "
+ "tx_shortform_allowed %d tx_vp_offset %u\n",
/tmp/tmpm2fsg47h/0012-RDMA-mana_ib-Add-a-driver-for-Microsoft-Azure-Network-Adapter.patch:540: WARNING: quoted string split across lines
#540: FILE: drivers/infiniband/hw/mana/main.c:198:
+ "size_dma_region %lu num_pages_total %lu, "
+ "page_sz 0x%llx offset_in_page %u\n",
And it thinks you should write more for the kconfig symbol, eg why
would someone want to turn it on (hint, to use dpkd on some Azure
instances)
/tmp/tmpm2fsg47h/0012-RDMA-mana_ib-Add-a-driver-for-Microsoft-Azure-Network-Adapter.patch:100: WARNING: please write a help paragraph that fully describes the config symbol
#100: FILE: drivers/infiniband/hw/mana/Kconfig:2:
+config MANA_INFINIBAND
+ tristate "Microsoft Azure Network Adapter support"
+ depends on NETDEVICES && ETHERNET && PCI && MICROSOFT_MANA
+ help
+ This driver provides low-level RDMA support for
+ Microsoft Azure Network Adapter (MANA).
I'll put it in linux-next and you can fix the rest of the stuff bots
will usually find.
Jason
next prev parent reply other threads:[~2022-09-21 16:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 1:22 [Patch v6 00/12] Introduce Microsoft Azure Network Adapter (MANA) RDMA driver longli
2022-09-21 1:22 ` [Patch v6 01/12] net: mana: Add support for auxiliary device longli
2022-09-21 1:22 ` [Patch v6 02/12] net: mana: Record the physical address for doorbell page region longli
2022-09-21 1:22 ` [Patch v6 03/12] net: mana: Handle vport sharing between devices longli
2022-09-21 1:22 ` [Patch v6 04/12] net: mana: Add functions for allocating doorbell page from GDMA longli
2022-09-21 1:22 ` [Patch v6 05/12] net: mana: Set the DMA device max segment size longli
2022-09-21 1:22 ` [Patch v6 06/12] net: mana: Export Work Queue functions for use by RDMA driver longli
2022-09-21 1:22 ` [Patch v6 07/12] net: mana: Record port number in netdev longli
2022-09-21 1:22 ` [Patch v6 08/12] net: mana: Move header files to a common location longli
2022-09-21 1:22 ` [Patch v6 09/12] net: mana: Define max values for SGL entries longli
2022-09-21 1:22 ` [Patch v6 10/12] net: mana: Define and process GDMA response code GDMA_STATUS_MORE_ENTRIES longli
2022-09-21 1:22 ` [Patch v6 11/12] net: mana: Define data structures for protection domain and memory registration longli
2022-09-21 1:22 ` [Patch v6 12/12] RDMA/mana_ib: Add a driver for Microsoft Azure Network Adapter longli
2022-09-21 16:26 ` Jason Gunthorpe
2022-09-21 21:00 ` Long Li
2022-09-21 17:59 ` Jason Gunthorpe
2022-09-22 8:23 ` Long Li
2022-09-21 16:25 ` Jason Gunthorpe [this message]
2022-09-21 18:53 ` [Patch v6 00/12] Introduce Microsoft Azure Network Adapter (MANA) RDMA driver Long Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yys69cXCOdYL0LTo@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=leon@kernel.org \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sharmaajay@microsoft.com \
--cc=shiraz.saleem@intel.com \
--cc=sthemmin@microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.