From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: Ren Zhijie <renzhijie2@huawei.com>
Cc: gregkh@linuxfoundation.org, xji@analogixsemi.com,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] usb: typec: anx7411: Fix build error without CONFIG_POWER_SUPPLY
Date: Thu, 22 Sep 2022 12:24:27 +0300 [thread overview]
Message-ID: <Yywpy8X2YuqB1qdQ@kuha.fi.intel.com> (raw)
In-Reply-To: <20220920084431.196258-1-renzhijie2@huawei.com>
On Tue, Sep 20, 2022 at 04:44:31PM +0800, Ren Zhijie wrote:
> Building without CONFIG_POWER_SUPPLY will fail:
>
> drivers/usb/typec/anx7411.o: In function `anx7411_detect_power_mode':
> anx7411.c:(.text+0x527): undefined reference to `power_supply_changed'
> drivers/usb/typec/anx7411.o: In function `anx7411_psy_set_prop':
> anx7411.c:(.text+0x90d): undefined reference to `power_supply_get_drvdata'
> anx7411.c:(.text+0x930): undefined reference to `power_supply_changed'
> drivers/usb/typec/anx7411.o: In function `anx7411_psy_get_prop':
> anx7411.c:(.text+0x94d): undefined reference to `power_supply_get_drvdata'
> drivers/usb/typec/anx7411.o: In function `anx7411_i2c_probe':
> anx7411.c:(.text+0x111d): undefined reference to
> `devm_power_supply_register'
> drivers/usb/typec/anx7411.o: In function `anx7411_work_func':
> anx7411.c:(.text+0x167c): undefined reference to `power_supply_changed'
> anx7411.c:(.text+0x1b55): undefined reference to `power_supply_changed'
>
> Add POWER_SUPPLY dependency to Kconfig.
>
> Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
> Signed-off-by: Ren Zhijie <renzhijie2@huawei.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/typec/Kconfig b/drivers/usb/typec/Kconfig
> index 5defdfead653..831e7049977d 100644
> --- a/drivers/usb/typec/Kconfig
> +++ b/drivers/usb/typec/Kconfig
> @@ -56,6 +56,7 @@ config TYPEC_ANX7411
> tristate "Analogix ANX7411 Type-C DRP Port controller driver"
> depends on I2C
> depends on USB_ROLE_SWITCH
> + depends on POWER_SUPPLY
> help
> Say Y or M here if your system has Analogix ANX7411 Type-C DRP Port
> controller driver.
> --
> 2.17.1
--
heikki
next prev parent reply other threads:[~2022-09-22 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-20 8:44 [PATCH -next] usb: typec: anx7411: Fix build error without CONFIG_POWER_SUPPLY Ren Zhijie
2022-09-22 9:24 ` Heikki Krogerus [this message]
2022-09-22 10:00 ` Xin Ji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yywpy8X2YuqB1qdQ@kuha.fi.intel.com \
--to=heikki.krogerus@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=renzhijie2@huawei.com \
--cc=xji@analogixsemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.