Re: [PATCH] mtd: spi-nor: gigadevice: Add support for gd25lr256e

From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Michael Walle <michael@walle.cc>
Cc: Tudor Ambarus <tudor.ambarus@microchip.com>,
	Pratyush Yadav <pratyush@kernel.org>,
	Miquel Raynal <miquel.raynal@bootlin.com>,
	Richard Weinberger <richard@nod.at>,
	Vignesh Raghavendra <vigneshr@ti.com>,
	linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: spi-nor: gigadevice: Add support for gd25lr256e
Date: Thu, 22 Sep 2022 17:30:45 +0300	[thread overview]
Message-ID: <YyxxlSscwnWSyfy3@black.fi.intel.com> (raw)
In-Reply-To: <88d096d0c5efe43bc50f3c547634eb8b@walle.cc>

On Thu, Sep 22, 2022 at 04:15:37PM +0200, Michael Walle wrote:
> Am 2022-09-22 15:56, schrieb Mika Westerberg:
> > Add support for this 32MB serial flash.
> > 
> > Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> > ---
> >  drivers/mtd/spi-nor/gigadevice.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/mtd/spi-nor/gigadevice.c
> > b/drivers/mtd/spi-nor/gigadevice.c
> > index 119b38e6fc2a..7a7f5cb67a9e 100644
> > --- a/drivers/mtd/spi-nor/gigadevice.c
> > +++ b/drivers/mtd/spi-nor/gigadevice.c
> > @@ -57,6 +57,10 @@ static const struct flash_info gigadevice_nor_parts[]
> > = {
> >  		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6)
> >  		FIXUP_FLAGS(SPI_NOR_4B_OPCODES)
> >  		.fixups = &gd25q256_fixups },
> > +	{ "gd25lr256e", INFO(0xc86719, 0, 64 * 1024, 512)
> 
> There doesn't seem to be a public datasheet. Does this flash support SFDP?
> 
> In that case, please just use
> 	{ "gd25lr256e", INFO(0xc86719, 0, 0, 0),
> 		FLAGS(SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB)
> 		PARSE_SFDP
> 	}
> 

Sure, let me check this one works and update the patch accordinglly.

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/