From mboxrd@z Thu Jan 1 00:00:00 1970 From: Corey Minyard Date: Thu, 22 Sep 2022 13:57:39 -0500 Subject: [PATCH] ipmi: kcs: aspeed: Update port address comments In-Reply-To: <20220920020333.601-1-chiawei_wang@aspeedtech.com> References: <20220920020333.601-1-chiawei_wang@aspeedtech.com> Message-ID: List-Id: To: linux-aspeed@lists.ozlabs.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Tue, Sep 20, 2022 at 10:03:33AM +0800, Chia-Wei Wang wrote: > Remove AST_usrGuide_KCS.pdf as it is no longer maintained. Even if it's no longer maintained, is it useful? It seems better to leave in useful documentation unless it has been replaced with something else. -corey > > Add more descriptions as the driver now supports the I/O > address configurations for both the KCS Data and Cmd/Status > interface registers. > > Signed-off-by: Chia-Wei Wang > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 29 ++++++++++++++++++----------- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c > index cdc88cde1e9a..19c32bf50e0e 100644 > --- a/drivers/char/ipmi/kcs_bmc_aspeed.c > +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c > @@ -207,17 +207,24 @@ static void aspeed_kcs_updateb(struct kcs_bmc_device *kcs_bmc, u32 reg, u8 mask, > } > > /* > - * AST_usrGuide_KCS.pdf > - * 2. Background: > - * we note D for Data, and C for Cmd/Status, default rules are > - * A. KCS1 / KCS2 ( D / C:X / X+4 ) > - * D / C : CA0h / CA4h > - * D / C : CA8h / CACh > - * B. KCS3 ( D / C:XX2h / XX3h ) > - * D / C : CA2h / CA3h > - * D / C : CB2h / CB3h > - * C. KCS4 > - * D / C : CA4h / CA5h > + * We note D for Data, and C for Cmd/Status, default rules are > + * > + * 1. Only the D address is given: > + * A. KCS1/KCS2 (D/C: X/X+4) > + * D/C: CA0h/CA4h > + * D/C: CA8h/CACh > + * B. KCS3 (D/C: XX2/XX3h) > + * D/C: CA2h/CA3h > + * C. KCS4 (D/C: X/X+1) > + * D/C: CA4h/CA5h > + * > + * 2. Both the D/C addresses are given: > + * A. KCS1/KCS2/KCS4 (D/C: X/Y) > + * D/C: CA0h/CA1h > + * D/C: CA8h/CA9h > + * D/C: CA4h/CA5h > + * B. KCS3 (D/C: XX2/XX3h) > + * D/C: CA2h/CA3h > */ > static int aspeed_kcs_set_address(struct kcs_bmc_device *kcs_bmc, u32 addrs[2], int nr_addrs) > { > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDDABC54EE9 for ; Thu, 22 Sep 2022 18:58:26 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4MYPgj0cxGz3c73 for ; Fri, 23 Sep 2022 04:58:25 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=axhceb0o; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=2607:f8b0:4864:20::72e; helo=mail-qk1-x72e.google.com; envelope-from=tcminyard@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20210112 header.b=axhceb0o; dkim-atps=neutral Received: from mail-qk1-x72e.google.com (mail-qk1-x72e.google.com [IPv6:2607:f8b0:4864:20::72e]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4MYPfz581Yz3bpn; Fri, 23 Sep 2022 04:57:45 +1000 (AEST) Received: by mail-qk1-x72e.google.com with SMTP id o7so6841909qkj.10; Thu, 22 Sep 2022 11:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=h9c+xPWJyC5OnFGo12v4TpTLnof1p8+esOXYmciFsQA=; b=axhceb0omg3rX8tkuuP0AQ9Uwq2axBINJntz4zOv/BEVfSxg/ddN5kY3Gx/C6vrdw3 N8hqgRa5R76RpCqg4mTHnN1dbWkPdjFId8w5nvxn7A758diY5owUDU4phu9NrtF3TRjT AgIvXm92Oiy4/Fv7p63YBmwatogCuf/3r0pDbYlAiDeNGHkjx2XnylVlLFmbm8jiq93t pxusF/6VqWeyojGb6Qk9yeub6PRZsXQCBF3bcJAWHvEG9OeH3noFYuWi5tp+0MGcV7ua SAmWYz21zlNRLFScWZssJ1x6kr7EW2DUHxCjTYisq41CBg3nS44wrqYhQJhVGi09hKPg P20g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc:subject:date; bh=h9c+xPWJyC5OnFGo12v4TpTLnof1p8+esOXYmciFsQA=; b=WEmvj2QMJn+SI7nKkSzanzikNysshIBadpRYGI707nQdrjQyB27FgwwHL3RSkHqtE8 /6mz24Aoh1iLqd/o0y/9c2LR3+eax9WtnMA9h0T8SsU5gpupmjvvGW38R58jx8pklJk9 3ucAtotdsGYRHUnZ1j3KMSFtGLkoRI06L36YOl0cR6ul+/QBzf3m94et4/n/sobx5fba 6fkwcDAC3/mUVdOI0fZW0DwAyaO+CV6FvgF/TjJ9REhkbcI0jtMP4p9UwcWfyAO9lBwr a0QN1SfGcM8tHlF0E5FB0nJWme8yJrsop+ICqbyu6RZdLGZfGB6qDK0a5pkVqEQlgHe9 CizA== X-Gm-Message-State: ACrzQf2Zsge7nU12eZola9dNsWahcY7p4Izf1FVI+W/DJ5R+wYBQlMKd 6NaYyhIwItBOLvlD4Bml6A== X-Google-Smtp-Source: AMsMyM7lRX/UtjmtPjX7vd4fBl38n/2HwjotYxOaQHYiv6AR68EPDuLkUGmGjF8Iz8qfIhSJckxh4Q== X-Received: by 2002:a05:620a:1d02:b0:6ce:5820:2fdc with SMTP id dl2-20020a05620a1d0200b006ce58202fdcmr3246580qkb.638.1663873061853; Thu, 22 Sep 2022 11:57:41 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id g17-20020ac87751000000b003434e47515csm3889217qtu.7.2022.09.22.11.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 11:57:41 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:5d3f:d09:85d2:d6e]) by serve.minyard.net (Postfix) with ESMTPSA id AEF841800BD; Thu, 22 Sep 2022 18:57:40 +0000 (UTC) Date: Thu, 22 Sep 2022 13:57:39 -0500 From: Corey Minyard To: Chia-Wei Wang Subject: Re: [PATCH] ipmi: kcs: aspeed: Update port address comments Message-ID: References: <20220920020333.601-1-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920020333.601-1-chiawei_wang@aspeedtech.com> X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Cc: linux-aspeed@lists.ozlabs.org, andrew@aj.id.au, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, joel@jms.id.au, openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Tue, Sep 20, 2022 at 10:03:33AM +0800, Chia-Wei Wang wrote: > Remove AST_usrGuide_KCS.pdf as it is no longer maintained. Even if it's no longer maintained, is it useful? It seems better to leave in useful documentation unless it has been replaced with something else. -corey > > Add more descriptions as the driver now supports the I/O > address configurations for both the KCS Data and Cmd/Status > interface registers. > > Signed-off-by: Chia-Wei Wang > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 29 ++++++++++++++++++----------- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c > index cdc88cde1e9a..19c32bf50e0e 100644 > --- a/drivers/char/ipmi/kcs_bmc_aspeed.c > +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c > @@ -207,17 +207,24 @@ static void aspeed_kcs_updateb(struct kcs_bmc_device *kcs_bmc, u32 reg, u8 mask, > } > > /* > - * AST_usrGuide_KCS.pdf > - * 2. Background: > - * we note D for Data, and C for Cmd/Status, default rules are > - * A. KCS1 / KCS2 ( D / C:X / X+4 ) > - * D / C : CA0h / CA4h > - * D / C : CA8h / CACh > - * B. KCS3 ( D / C:XX2h / XX3h ) > - * D / C : CA2h / CA3h > - * D / C : CB2h / CB3h > - * C. KCS4 > - * D / C : CA4h / CA5h > + * We note D for Data, and C for Cmd/Status, default rules are > + * > + * 1. Only the D address is given: > + * A. KCS1/KCS2 (D/C: X/X+4) > + * D/C: CA0h/CA4h > + * D/C: CA8h/CACh > + * B. KCS3 (D/C: XX2/XX3h) > + * D/C: CA2h/CA3h > + * C. KCS4 (D/C: X/X+1) > + * D/C: CA4h/CA5h > + * > + * 2. Both the D/C addresses are given: > + * A. KCS1/KCS2/KCS4 (D/C: X/Y) > + * D/C: CA0h/CA1h > + * D/C: CA8h/CA9h > + * D/C: CA4h/CA5h > + * B. KCS3 (D/C: XX2/XX3h) > + * D/C: CA2h/CA3h > */ > static int aspeed_kcs_set_address(struct kcs_bmc_device *kcs_bmc, u32 addrs[2], int nr_addrs) > { > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49A03ECAAD8 for ; Thu, 22 Sep 2022 18:59:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Reply-To:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wD5PkxdDTAgdpad1+qa0uGElP6w7DmnyYoruwHxNpK4=; b=2NgPnRZ+SYuIX1 QRVPXvjUA/wCMn09ZcXdQKaEo5tQtjlTgth2TmetmRi2wz0P8OicM+Zt6iHslmlrZ5pJt94QdOqwh NLf78ViKxzhjifObT1DWmqMSAhUXrWcnLJuZlA3kVavtmRVmTr4x56W2rz7TU6CJP5vTmaVuLMuX1 Je0jq3hGXu7jtCOpFRNHyRFA3uMukKC6o5vEYkGd4/7BST3JxM8bHtsLXRhuG0aCYQG9BVRuAgeOW IFxsvKO9BsvJ9niW8QUP1zqHGRY/HUYKcUIej3A6b7fWgAtDhfhisirpy+0t6ymxA7+D0+xC39/XY Fal/QvOqAkCtZQhdOYWA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1obROM-00HU7P-Il; Thu, 22 Sep 2022 18:57:46 +0000 Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1obROJ-00HU6c-TA for linux-arm-kernel@lists.infradead.org; Thu, 22 Sep 2022 18:57:45 +0000 Received: by mail-qk1-x72f.google.com with SMTP id c19so6843952qkm.7 for ; Thu, 22 Sep 2022 11:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=h9c+xPWJyC5OnFGo12v4TpTLnof1p8+esOXYmciFsQA=; b=axhceb0omg3rX8tkuuP0AQ9Uwq2axBINJntz4zOv/BEVfSxg/ddN5kY3Gx/C6vrdw3 N8hqgRa5R76RpCqg4mTHnN1dbWkPdjFId8w5nvxn7A758diY5owUDU4phu9NrtF3TRjT AgIvXm92Oiy4/Fv7p63YBmwatogCuf/3r0pDbYlAiDeNGHkjx2XnylVlLFmbm8jiq93t pxusF/6VqWeyojGb6Qk9yeub6PRZsXQCBF3bcJAWHvEG9OeH3noFYuWi5tp+0MGcV7ua SAmWYz21zlNRLFScWZssJ1x6kr7EW2DUHxCjTYisq41CBg3nS44wrqYhQJhVGi09hKPg P20g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc:subject:date; bh=h9c+xPWJyC5OnFGo12v4TpTLnof1p8+esOXYmciFsQA=; b=4H0Y43tEB6dEyr6UQfqhtZDmJvErIilUlmQCquINO0Z7iy4c3SIZnB/ksBgq8iwwUE K+nCpKFyxajFWnCnnYXXE2kyHmmThqwRySU9BNfDV1rsJCnk2UlsJ/Z221BEJdqQisBh Ob3bEqwuUhMNQia1JaamtqvlbOXo8StshTQcvp0fovUsBbmlse/2qfhdNaNiyH9o2QWI Hegxg8X/WDj6namZG5pUW1uXTDK3h/GM6CyIX/Q8r8gIiEF8jIuCUfrZ2NKH8zYQzs2s AcDCaAOBImKPPvV0glT9w56zQnxGHPJZLJkzVt0NCVbhfXdKKbheQa6TGLblB+C0FkBP /nhg== X-Gm-Message-State: ACrzQf3IHfDxDyG48yC6tfPAh1dNppoSKhF0IcsuV0u3WJpK42NnDUbU Xs8r/e2EQepnKHMp7wV+Hw== X-Google-Smtp-Source: AMsMyM7lRX/UtjmtPjX7vd4fBl38n/2HwjotYxOaQHYiv6AR68EPDuLkUGmGjF8Iz8qfIhSJckxh4Q== X-Received: by 2002:a05:620a:1d02:b0:6ce:5820:2fdc with SMTP id dl2-20020a05620a1d0200b006ce58202fdcmr3246580qkb.638.1663873061853; Thu, 22 Sep 2022 11:57:41 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id g17-20020ac87751000000b003434e47515csm3889217qtu.7.2022.09.22.11.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 11:57:41 -0700 (PDT) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:5d3f:d09:85d2:d6e]) by serve.minyard.net (Postfix) with ESMTPSA id AEF841800BD; Thu, 22 Sep 2022 18:57:40 +0000 (UTC) Date: Thu, 22 Sep 2022 13:57:39 -0500 From: Corey Minyard To: Chia-Wei Wang Cc: joel@jms.id.au, andrew@aj.id.au, openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH] ipmi: kcs: aspeed: Update port address comments Message-ID: References: <20220920020333.601-1-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220920020333.601-1-chiawei_wang@aspeedtech.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220922_115743_979737_8DBCE503 X-CRM114-Status: GOOD ( 19.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 20, 2022 at 10:03:33AM +0800, Chia-Wei Wang wrote: > Remove AST_usrGuide_KCS.pdf as it is no longer maintained. Even if it's no longer maintained, is it useful? It seems better to leave in useful documentation unless it has been replaced with something else. -corey > > Add more descriptions as the driver now supports the I/O > address configurations for both the KCS Data and Cmd/Status > interface registers. > > Signed-off-by: Chia-Wei Wang > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 29 ++++++++++++++++++----------- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c > index cdc88cde1e9a..19c32bf50e0e 100644 > --- a/drivers/char/ipmi/kcs_bmc_aspeed.c > +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c > @@ -207,17 +207,24 @@ static void aspeed_kcs_updateb(struct kcs_bmc_device *kcs_bmc, u32 reg, u8 mask, > } > > /* > - * AST_usrGuide_KCS.pdf > - * 2. Background: > - * we note D for Data, and C for Cmd/Status, default rules are > - * A. KCS1 / KCS2 ( D / C:X / X+4 ) > - * D / C : CA0h / CA4h > - * D / C : CA8h / CACh > - * B. KCS3 ( D / C:XX2h / XX3h ) > - * D / C : CA2h / CA3h > - * D / C : CB2h / CB3h > - * C. KCS4 > - * D / C : CA4h / CA5h > + * We note D for Data, and C for Cmd/Status, default rules are > + * > + * 1. Only the D address is given: > + * A. KCS1/KCS2 (D/C: X/X+4) > + * D/C: CA0h/CA4h > + * D/C: CA8h/CACh > + * B. KCS3 (D/C: XX2/XX3h) > + * D/C: CA2h/CA3h > + * C. KCS4 (D/C: X/X+1) > + * D/C: CA4h/CA5h > + * > + * 2. Both the D/C addresses are given: > + * A. KCS1/KCS2/KCS4 (D/C: X/Y) > + * D/C: CA0h/CA1h > + * D/C: CA8h/CA9h > + * D/C: CA4h/CA5h > + * B. KCS3 (D/C: XX2/XX3h) > + * D/C: CA2h/CA3h > */ > static int aspeed_kcs_set_address(struct kcs_bmc_device *kcs_bmc, u32 addrs[2], int nr_addrs) > { > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CC06C54EE9 for ; Thu, 22 Sep 2022 18:57:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231625AbiIVS5v (ORCPT ); Thu, 22 Sep 2022 14:57:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232039AbiIVS5q (ORCPT ); Thu, 22 Sep 2022 14:57:46 -0400 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2844E7C27 for ; Thu, 22 Sep 2022 11:57:42 -0700 (PDT) Received: by mail-qk1-x72f.google.com with SMTP id g2so6892117qkk.1 for ; Thu, 22 Sep 2022 11:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:from:to:cc:subject:date; bh=h9c+xPWJyC5OnFGo12v4TpTLnof1p8+esOXYmciFsQA=; b=axhceb0omg3rX8tkuuP0AQ9Uwq2axBINJntz4zOv/BEVfSxg/ddN5kY3Gx/C6vrdw3 N8hqgRa5R76RpCqg4mTHnN1dbWkPdjFId8w5nvxn7A758diY5owUDU4phu9NrtF3TRjT AgIvXm92Oiy4/Fv7p63YBmwatogCuf/3r0pDbYlAiDeNGHkjx2XnylVlLFmbm8jiq93t pxusF/6VqWeyojGb6Qk9yeub6PRZsXQCBF3bcJAWHvEG9OeH3noFYuWi5tp+0MGcV7ua SAmWYz21zlNRLFScWZssJ1x6kr7EW2DUHxCjTYisq41CBg3nS44wrqYhQJhVGi09hKPg P20g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:sender:x-gm-message-state:from :to:cc:subject:date; bh=h9c+xPWJyC5OnFGo12v4TpTLnof1p8+esOXYmciFsQA=; b=jiXLMH8Or1Ya6RnNmJNpm3y4SLBCztFN9zggvxCOQMj3Vx2NlOEZCmAkwTeC9FYVSr kewUfmp+fYux9fHPNqKPNnOmyfJJOrTxYnqh3rS4kYzagZCjC4J08jaMx2vIvvwszSmH ySTIDAkJmwx+c3c7ohMBOtnMbb3a/Q8h7q3DbPJDaXM5mHlhwK1vEude4tLb34Ir0OdL vqnJWcILoyvAtBcESFamiYnzVpbnY/h+VOLadjORsDb9/QRnwypyTZSukziFh1jFjSZU jucYdsrM5aareITBsCz06FFZtg1mBB9Qs0mCT0HWJ0Zny/SMOo2xztyYQCbWJjA4FxmP ceiw== X-Gm-Message-State: ACrzQf3AVJrSXefi/wy+HZA8SF4GD3CdvGI1bDHR5o2wH7lcDkYqkqkV qZqdQ5fsXk5sc+uXjxpwaAvnWeYn1dFH X-Google-Smtp-Source: AMsMyM7lRX/UtjmtPjX7vd4fBl38n/2HwjotYxOaQHYiv6AR68EPDuLkUGmGjF8Iz8qfIhSJckxh4Q== X-Received: by 2002:a05:620a:1d02:b0:6ce:5820:2fdc with SMTP id dl2-20020a05620a1d0200b006ce58202fdcmr3246580qkb.638.1663873061853; Thu, 22 Sep 2022 11:57:41 -0700 (PDT) Received: from serve.minyard.net (serve.minyard.net. [2001:470:b8f6:1b::1]) by smtp.gmail.com with ESMTPSA id g17-20020ac87751000000b003434e47515csm3889217qtu.7.2022.09.22.11.57.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Sep 2022 11:57:41 -0700 (PDT) Sender: Corey Minyard Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:5d3f:d09:85d2:d6e]) by serve.minyard.net (Postfix) with ESMTPSA id AEF841800BD; Thu, 22 Sep 2022 18:57:40 +0000 (UTC) Date: Thu, 22 Sep 2022 13:57:39 -0500 From: Corey Minyard To: Chia-Wei Wang Cc: joel@jms.id.au, andrew@aj.id.au, openipmi-developer@lists.sourceforge.net, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org Subject: Re: [PATCH] ipmi: kcs: aspeed: Update port address comments Message-ID: Reply-To: minyard@acm.org References: <20220920020333.601-1-chiawei_wang@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920020333.601-1-chiawei_wang@aspeedtech.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 20, 2022 at 10:03:33AM +0800, Chia-Wei Wang wrote: > Remove AST_usrGuide_KCS.pdf as it is no longer maintained. Even if it's no longer maintained, is it useful? It seems better to leave in useful documentation unless it has been replaced with something else. -corey > > Add more descriptions as the driver now supports the I/O > address configurations for both the KCS Data and Cmd/Status > interface registers. > > Signed-off-by: Chia-Wei Wang > --- > drivers/char/ipmi/kcs_bmc_aspeed.c | 29 ++++++++++++++++++----------- > 1 file changed, 18 insertions(+), 11 deletions(-) > > diff --git a/drivers/char/ipmi/kcs_bmc_aspeed.c b/drivers/char/ipmi/kcs_bmc_aspeed.c > index cdc88cde1e9a..19c32bf50e0e 100644 > --- a/drivers/char/ipmi/kcs_bmc_aspeed.c > +++ b/drivers/char/ipmi/kcs_bmc_aspeed.c > @@ -207,17 +207,24 @@ static void aspeed_kcs_updateb(struct kcs_bmc_device *kcs_bmc, u32 reg, u8 mask, > } > > /* > - * AST_usrGuide_KCS.pdf > - * 2. Background: > - * we note D for Data, and C for Cmd/Status, default rules are > - * A. KCS1 / KCS2 ( D / C:X / X+4 ) > - * D / C : CA0h / CA4h > - * D / C : CA8h / CACh > - * B. KCS3 ( D / C:XX2h / XX3h ) > - * D / C : CA2h / CA3h > - * D / C : CB2h / CB3h > - * C. KCS4 > - * D / C : CA4h / CA5h > + * We note D for Data, and C for Cmd/Status, default rules are > + * > + * 1. Only the D address is given: > + * A. KCS1/KCS2 (D/C: X/X+4) > + * D/C: CA0h/CA4h > + * D/C: CA8h/CACh > + * B. KCS3 (D/C: XX2/XX3h) > + * D/C: CA2h/CA3h > + * C. KCS4 (D/C: X/X+1) > + * D/C: CA4h/CA5h > + * > + * 2. Both the D/C addresses are given: > + * A. KCS1/KCS2/KCS4 (D/C: X/Y) > + * D/C: CA0h/CA1h > + * D/C: CA8h/CA9h > + * D/C: CA4h/CA5h > + * B. KCS3 (D/C: XX2/XX3h) > + * D/C: CA2h/CA3h > */ > static int aspeed_kcs_set_address(struct kcs_bmc_device *kcs_bmc, u32 addrs[2], int nr_addrs) > { > -- > 2.25.1 >