From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 06B39C433FE for ; Wed, 5 Oct 2022 10:38:28 +0000 (UTC) Received: from localhost ([::1]:60736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1og1nH-0007lL-NC for qemu-devel@archiver.kernel.org; Wed, 05 Oct 2022 06:38:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42132) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og1ha-0005HT-5I for qemu-devel@nongnu.org; Wed, 05 Oct 2022 06:32:37 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]:58094) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1og1hX-0008Hr-S5 for qemu-devel@nongnu.org; Wed, 05 Oct 2022 06:32:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664965950; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=z3V0Swsu9xuYX8doN0UPNK8OTp5wHhiQ+HRIgbAFFiQ=; b=CqhW5aUHDECjap7Mbj3Gy7RERQKJ0fnVBiAMihOuGaEah4XSzMLTui1+jILXuczU9OnsfI 4NPlFSVd4LRg5TVcT2r2tHDzueaJgeyOpX8BdI9LUHzGXqS17opYaKSypKFdEphxrZVH+j M22VPYdmDEbG56JiL8P7qcv+LE3kQf0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-583-GJD17LGXPsWVT7CK0ehmBA-1; Wed, 05 Oct 2022 06:32:26 -0400 X-MC-Unique: GJD17LGXPsWVT7CK0ehmBA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 689DA1C06EC9; Wed, 5 Oct 2022 10:32:26 +0000 (UTC) Received: from redhat.com (unknown [10.39.195.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 90D3317585; Wed, 5 Oct 2022 10:32:25 +0000 (UTC) Date: Wed, 5 Oct 2022 12:32:24 +0200 From: Kevin Wolf To: Paolo Bonzini Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, afaria@redhat.com, Eric Blake Subject: Re: [PATCH 06/26] blkdebug: add missing coroutine_fn annotations Message-ID: References: <20220922084924.201610-1-pbonzini@redhat.com> <20220922084924.201610-7-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220922084924.201610-7-pbonzini@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 Received-SPF: pass client-ip=170.10.129.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 22.09.2022 um 10:49 hat Paolo Bonzini geschrieben: > Callers of coroutine_fn must be coroutine_fn themselves, or the call > must be within "if (qemu_in_coroutine())". Apply coroutine_fn to > functions where this holds. > > Reviewed-by: Alberto Faria > Reviewed-by: Eric Blake > Signed-off-by: Paolo Bonzini Hm... blkdebug_debug_event() is called from bdrv_debug_event(), which is not coroutine_fn. And I think that it's not coroutine_fn is correct: For example, with 'qemu-img snapshot -c' you get img_snapshot() -> bdrv_snapshot_create() -> qcow2_snapshot_create() -> qcow2_alloc_clusters() -> BLKDBG_EVENT. I'm sure many other calls in qcow2 can be reached from non-coroutine context as well. It almost looks like your code analysis didn't consider calls through function pointers? Kevin