From: Sean Christopherson <seanjc@google.com>
To: Zixuan Wang <zxwang@fb.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, drjones@redhat.com,
shankaran@fb.com, somnathc@fb.com, marcorr@google.com,
varad.gautam@suse.com, jroedel@suse.de, bp@suse.de,
zxwang42@gmail.com
Subject: Re: [kvm-unit-tests RFC PATCH 5/5] x86/efi: Update README with standalone instructions
Date: Wed, 5 Oct 2022 18:38:04 +0000 [thread overview]
Message-ID: <Yz3PDMsaMVAgvXOe@google.com> (raw)
In-Reply-To: <20220816175413.3553795-6-zxwang@fb.com>
On Tue, Aug 16, 2022, Zixuan Wang wrote:
> Update the `x86/efi/README.md` with instructions to build and run
> standalone test cases with UEFI.
>
> Signed-off-by: Zixuan Wang <zxwang@fb.com>
> ---
> x86/efi/README.md | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/x86/efi/README.md b/x86/efi/README.md
> index aa1dbcd..f740225 100644
> --- a/x86/efi/README.md
> +++ b/x86/efi/README.md
> @@ -30,6 +30,16 @@ the env variable `EFI_UEFI`:
>
> EFI_UEFI=/path/to/OVMF.fd ./x86/efi/run ./x86/msr.efi
>
> +### Build and standalone test cases with UEFI
s/and// ?
> +
> +To build:
> +
> + ./configure --enable-efi
> + make standalone
> + (send tests/some-test somewhere)
> + (go to somewhere)
> + EFI_UEFI=/path/to/OVMF.fd ./some-test
This makes me wonder if the scripts should try to locate OVMF.fd, same as they
do for QEMU. It's odd that specifying QEMU is optional, but for EFI_UEFI it's
mandatory.
prev parent reply other threads:[~2022-10-05 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220816175413.3553795-1-zxwang@fb.com>
[not found] ` <20220816175413.3553795-2-zxwang@fb.com>
2022-10-05 18:20 ` [kvm-unit-tests RFC PATCH 1/5] efi: Compile standalone binaries for EFI Sean Christopherson
[not found] ` <20220816175413.3553795-3-zxwang@fb.com>
2022-10-05 18:24 ` [kvm-unit-tests RFC PATCH 2/5] x86/efi: Fix efi runner scripts for standalone Sean Christopherson
[not found] ` <20220816175413.3553795-4-zxwang@fb.com>
2022-10-05 18:34 ` [kvm-unit-tests RFC PATCH 3/5] x86/efi: Update unittests.cfg to build standalones Sean Christopherson
[not found] ` <20220816175413.3553795-6-zxwang@fb.com>
2022-10-05 18:38 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz3PDMsaMVAgvXOe@google.com \
--to=seanjc@google.com \
--cc=bp@suse.de \
--cc=drjones@redhat.com \
--cc=jroedel@suse.de \
--cc=kvm@vger.kernel.org \
--cc=marcorr@google.com \
--cc=pbonzini@redhat.com \
--cc=shankaran@fb.com \
--cc=somnathc@fb.com \
--cc=varad.gautam@suse.com \
--cc=zxwang42@gmail.com \
--cc=zxwang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.