From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D948AC433FE for ; Thu, 6 Oct 2022 00:21:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229760AbiJFAVf (ORCPT ); Wed, 5 Oct 2022 20:21:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229494AbiJFAVd (ORCPT ); Wed, 5 Oct 2022 20:21:33 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC9407F0BF for ; Wed, 5 Oct 2022 17:21:32 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id 67so549220pfz.12 for ; Wed, 05 Oct 2022 17:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=E/qBKORZtms2bTkZoXsWhlC9/6RpsMQQlPOAxIcYlGk=; b=c2qKijirYjsZ69Ah4k0WN+wrGry4ewCU+IuoTxyRXIVK2ES4YXYzc0AJc9QbtGJYDv bFfo1t0V0O3T7ImNURIVB2AFgmU+olhGl+ErTALhPBHnTHZkDxhwfKJpy2BOQWoAAop7 pfZjizdxWVFEJw+jCVYLCnIAz/Q5kZ4WkWeN4GuqeFwKqn5HkcP+FvSGEOZddYG5pemq rGzYbyCXzhn3okL5vzNbaiIcEkdjy2P592cfxWGGAYfCIZ6YbuP2BEY9ip4KSIycP+GT fPs3nMIGuL/lKAoTfLwivV+y2KCcUBI/xxwNGZZCMVSs+sTHhfP5MLgCOaMw/MADpx51 krig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=E/qBKORZtms2bTkZoXsWhlC9/6RpsMQQlPOAxIcYlGk=; b=WJoGNtDX5IOcdSkyr0HbZdOyqPQqmiwvcIKirmqrIpcXdDOUKDE2oWrIS9ZAFVhBp5 VH0dEBCsy9pynksU+wXxOvp2Vqk6D4EdlWaSngSip8nwRLewQG3ydOUjDoVzco+jDFw1 EOh4o2333e4Kln4ML3s2xwElLVnDQ9ocusf/waNzZSweXbHtyRK5VrvJXoL3wzmuUKxG ARxXDkQrU2/ZMpZpr8EjhGIstc9wE+3nVcVLRvIp58JColne8GEFkYoVQJztcaFt/4jy Ve+drg/DnLn2uXzUiRYjfujHn4DjpL1eSbIb86szaBGdE2nBk1m8jjXfh1AeOYp7aYbm W84Q== X-Gm-Message-State: ACrzQf2kv1OblCdlEfp9+BZerQdBOJ8FnTnklFipSUjD18BX/+67MU0k +Iw3SPSLUzOzvgSeozJ50go4og== X-Google-Smtp-Source: AMsMyM5U398swJ3hL0VBqOMmCJQM5iXecYHKlVbx2tEKWecELFstQ3h0dTMpzI5YR+QZC9b3Yzqxrg== X-Received: by 2002:a63:4f4f:0:b0:434:b9db:b9f with SMTP id p15-20020a634f4f000000b00434b9db0b9fmr2109069pgl.438.1665015691617; Wed, 05 Oct 2022 17:21:31 -0700 (PDT) Received: from google.com (7.104.168.34.bc.googleusercontent.com. [34.168.104.7]) by smtp.gmail.com with ESMTPSA id iz6-20020a170902ef8600b00172c7dee22fsm10941845plb.236.2022.10.05.17.21.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Oct 2022 17:21:31 -0700 (PDT) Date: Thu, 6 Oct 2022 00:21:27 +0000 From: Sean Christopherson To: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Li Subject: Re: [PATCH] KVM: nVMX: Inject #GP, not #UD, if "generic" VMXON CR0/CR4 check fails Message-ID: References: <20221006001956.329314-1-seanjc@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221006001956.329314-1-seanjc@google.com> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, Oct 06, 2022, Sean Christopherson wrote: > + * Forwarding the VM-Exit unconditionally, i.e. without performing the > + * #UD checks (see above), is functionally ok because KVM doesn't allow > + * L1 to run L2 without CR4.VMXE=0, and because KVM never modifies L2's > + * CR0 or CR4, i.e. it's L2's responsibility to emulate #UDs that are Grr, s/L2's/L1's. Fixed the comment locally but didn't commit it before hitting "send".