From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35069C433FE for ; Thu, 6 Oct 2022 08:28:58 +0000 (UTC) Received: from localhost ([::1]:55596 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogMFV-0001BU-7l for qemu-devel@archiver.kernel.org; Thu, 06 Oct 2022 04:28:57 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogM2K-00013t-WF for qemu-devel@nongnu.org; Thu, 06 Oct 2022 04:15:21 -0400 Received: from mail.ozlabs.org ([2404:9400:2221:ea00::3]:36227 helo=gandalf.ozlabs.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogM2G-00033e-Bn for qemu-devel@nongnu.org; Thu, 06 Oct 2022 04:15:20 -0400 Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Mjkl31qKSz4xGn; Thu, 6 Oct 2022 19:15:11 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1665044111; bh=WtfyQadjhbdAzhznKpkuHh85DojvFARS9q3SQHsVpdk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CVmPOZFhs8U5OZAl7b85r5BacPw5luUhcLH02998g8Iap0YWWkABP48lXOAQdX9ll vgl69s36T0xTSFuxwfnGzQgzDFB2HPNBwgqAeUoYF4VZpTVRR5BxEvx2I/LTaN5WvB H6xzISdKX4rjxwlY502raRNgsMIVBgJkwEHIw9Rc= Date: Thu, 6 Oct 2022 19:13:51 +1100 From: David Gibson To: Laurent Vivier Cc: qemu-devel@nongnu.org, Thomas Huth , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eric Blake , "Dr. David Alan Gilbert" , Jason Wang , Samuel Thibault , Markus Armbruster , Paolo Bonzini , Stefan Weil , Greg Kurz , "Michael S. Tsirkin" , Stefano Brivio Subject: Re: [PATCH v10 07/17] net: socket: Don't ignore EINVAL on netdev socket connection Message-ID: References: <20221005162051.1120041-1-lvivier@redhat.com> <20221005162051.1120041-8-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tPZSyIBM9WRd+fOf" Content-Disposition: inline In-Reply-To: <20221005162051.1120041-8-lvivier@redhat.com> Received-SPF: pass client-ip=2404:9400:2221:ea00::3; envelope-from=dgibson@gandalf.ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -40 X-Spam_score: -4.1 X-Spam_bar: ---- X-Spam_report: (-4.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --tPZSyIBM9WRd+fOf Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 05, 2022 at 06:20:41PM +0200, Laurent Vivier wrote: > From: Stefano Brivio >=20 > Other errors are treated as failure by net_socket_connect_init(), > but if connect() returns EINVAL, we'll fail silently. Remove the > related exception. >=20 > Signed-off-by: Stefano Brivio > Signed-off-by: Laurent Vivier Reviewed-by: David Gibson > --- > net/socket.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/net/socket.c b/net/socket.c > index ade1ecf38b87..4944bb70d580 100644 > --- a/net/socket.c > +++ b/net/socket.c > @@ -577,8 +577,7 @@ static int net_socket_connect_init(NetClientState *pe= er, > if (errno =3D=3D EINTR || errno =3D=3D EWOULDBLOCK) { > /* continue */ > } else if (errno =3D=3D EINPROGRESS || > - errno =3D=3D EALREADY || > - errno =3D=3D EINVAL) { > + errno =3D=3D EALREADY) { > break; > } else { > error_setg_errno(errp, errno, "can't connect socket"); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --tPZSyIBM9WRd+fOf Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmM+ji8ACgkQgypY4gEw YSJ3BQ/9Hr2I9yNhOMNbQ4qoAq1XNw8uervrvRWral/six07PMfmqsy0M6QgeVij cgNiqyc6uK56jQ+l1YmhuzrxwV3p02YRjKpg55Cf7sPbaX75k7GKz+Foxaeqir+3 fLjCpSUdl+im3w1qOh5bqvvxLr9u7MP9KPsIacVFMcO0ghaBoq87rYDsPxFpDLUh goBGJmsEWmVFm/ovSLjAK9EXw1IbVLXObE5SObZ1b+/WH1PkQqMFLz9hbqhih1BB 3ch/bjvIacGLffv7LXaZDR3iUNx2zMBMKK8Uw7lo9Br/0zROB0rXcFcqW6D9sJE+ iGzbCLT7GvIbGQsatbIcyNG6uxhvkdjNNcwJ7NRW/4mI/eL6HxcOn5t0evq5oBJU lmibIaTsnjjr+8omokow70t4LlYnNpNTuicvOCSE72QGHhCd2e/OwXHeOGCklm1l fuSkCykWWHcI4ma7KvW8eD5CU8PVtfxov/wywvohytbyG1n9zwWhU2KBh5JkcRc7 RVqSlruUq7+lBz50WZZLantc1g93/PlKN5e97c2ATg7GRSgs8MN+ICfrfbulv4ST Uazud/eRwwIYFTQwGw8NCCzfeCjTXEkpYC+QXLRAJnsNNjEu2xarZtd9lK2eoroO DRG/dlLRil68Vjj6kznRyY+dzgyk3ug+NoHyqOSMBF1LHT5A6Gg= =klwa -----END PGP SIGNATURE----- --tPZSyIBM9WRd+fOf--