From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC76AC433FE for ; Thu, 6 Oct 2022 08:36:22 +0000 (UTC) Received: from localhost ([::1]:51464 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogMMf-0005Wu-Bq for qemu-devel@archiver.kernel.org; Thu, 06 Oct 2022 04:36:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45800) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogM2K-00013k-SU for qemu-devel@nongnu.org; Thu, 06 Oct 2022 04:15:21 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]:60903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogM2G-00033f-12 for qemu-devel@nongnu.org; Thu, 06 Oct 2022 04:15:19 -0400 Received: by gandalf.ozlabs.org (Postfix, from userid 1007) id 4Mjkl31xb2z4xGp; Thu, 6 Oct 2022 19:15:11 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gibson.dropbear.id.au; s=201602; t=1665044111; bh=YoFcQZRp5xIwY61iCIL4XDA4TzqzHX6ccG4ZQdLlzYo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SV+FcFUKQTgSGUqr6WjETq8pdCil2iMUt8Ti0R/hzpZ5dsyyT6rxXGEmLjJOoCEQn kW4M5iZ4tLJyzCFOEd8trtP6xZohEutZ7Ms8dJOlXijTESgcKoX+OqX1ThWY/Oj3uK sHOwojP6aVuvm2CMvT8PjCcve4Vb96PVoWTsamwk= Date: Thu, 6 Oct 2022 19:14:23 +1100 From: David Gibson To: Laurent Vivier Cc: qemu-devel@nongnu.org, Thomas Huth , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eric Blake , "Dr. David Alan Gilbert" , Jason Wang , Samuel Thibault , Markus Armbruster , Paolo Bonzini , Stefan Weil , Greg Kurz , "Michael S. Tsirkin" , Stefano Brivio Subject: Re: [PATCH v10 08/17] net: stream: Don't ignore EINVAL on netdev socket connection Message-ID: References: <20221005162051.1120041-1-lvivier@redhat.com> <20221005162051.1120041-9-lvivier@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="QF8ZkaI8jpuEV5R0" Content-Disposition: inline In-Reply-To: <20221005162051.1120041-9-lvivier@redhat.com> Received-SPF: pass client-ip=150.107.74.76; envelope-from=dgibson@gandalf.ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --QF8ZkaI8jpuEV5R0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Oct 05, 2022 at 06:20:42PM +0200, Laurent Vivier wrote: > From: Stefano Brivio >=20 > Other errors are treated as failure by net_stream_client_init(), > but if connect() returns EINVAL, we'll fail silently. Remove the > related exception. >=20 > Signed-off-by: Stefano Brivio > [lvivier: applied to net/stream.c] > Signed-off-by: Laurent Vivier > Reviewed-by: Daniel P. Berrang=E9 Reviewed-by: David Gibson > --- > net/stream.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >=20 > diff --git a/net/stream.c b/net/stream.c > index 37965eb74e1a..26e485438718 100644 > --- a/net/stream.c > +++ b/net/stream.c > @@ -360,8 +360,7 @@ static int net_stream_client_init(NetClientState *pee= r, > if (errno =3D=3D EINTR || errno =3D=3D EWOULDBLOCK) { > /* continue */ > } else if (errno =3D=3D EINPROGRESS || > - errno =3D=3D EALREADY || > - errno =3D=3D EINVAL) { > + errno =3D=3D EALREADY) { > break; > } else { > error_setg_errno(errp, errno, "can't connect socket"= ); --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --QF8ZkaI8jpuEV5R0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEoULxWu4/Ws0dB+XtgypY4gEwYSIFAmM+jlQACgkQgypY4gEw YSL1wA/8DJ5Ixx1awFRhjy2vSaHE0tZRgX2SvjTgZd5SIg+BIjmrSIwznt1wuxT0 X/wwoec0YHy0Ldw+wf8Y3Fr3O3B0fjApueyK4z677elI8AkNQdq8cgxhSRx0MMZj sFhNIMCnkmmmEBoHnSyiw6XH++8u3CAC1nsv80NiiVo1al6YZrAfsHEit9nIC51p xIXRW6J92l7wecms5cIgQXVXJrex0iv6QUTqXtT47cpnqWfyFbO/pRSgDP2wqH42 wAT5B6b+LfZeyC3ZkEXXgF+3m0xehUc+SuoEuxqjQhyDCUEUSwbF+EH8UzpkFirJ NbU9o9JGiBgbB5mz+wsN5Tmo0mYMjQfwLwV8H4dtWH1IW2uauGIfYnL0cRWFeCWS 1wzyaCJpXEsgw1SbWtfY4/ewPRUZ7ZtEssEMvHkrrA2LF4fPx3wKF8jU4vl9O3fL aZ2kgqhGL/eTBQ8y2mICEutPbOrgFRy2vCtbJNuu7JVs44gODIM4m0Csv3Qg78YZ 2rWipX41kNZW2fwKzKIwQDsQNz9dMpCk2SUHhG+MaWhNepK4v1Wci2PDOr2jkxkb gMCsONDgiiUJb0pw95AHqK+Y6N3r6fQHoScN5UJgF0Q1z0KMvFu/wXdW7/0ng/O0 TMMv67xXGA45SZxBz7IEvp85e5gtIrmTeuwTIu9iEG+wKfzbZlk= =PZWF -----END PGP SIGNATURE----- --QF8ZkaI8jpuEV5R0--