From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8FDC9C433F5 for ; Thu, 6 Oct 2022 10:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LVcyx29HdvBZnRUvvfeUH3HYuK0dSjoOB1/wibnrvuQ=; b=RdSdgup+zsn0iV /DhO10diuSlWBKaWP3vUWr0Eh5ai/FQk6HJT3eW8UT36768SpAQlfJHZMKsaNDf/K1kFOylaxR8Tg Vm94pcVh3p3cKr3WS0DEgvbAtwRSYUnmE8zvKEZDWFKLvRV8PSAX2kmoVWJZObv/fy2cuzYMWp7ER Z+ydUi1dRQ0PtkbHxF/DwqTxX2P7uzfGU9jTBQYMLL6trTjoTSMftXIVlJMJzbdYLsnvRUm/w0/7Y xvcFdjtbKIC7a0k1Fb87Mi3CGiQeCDbg5I3jaqmywkAwiz6M9hkmyZrcgMs1aZUyMQ78CVqYEYmEA 44B1Bd5gKw4dqNjl/Tsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogNkc-001KvY-U1; Thu, 06 Oct 2022 10:05:11 +0000 Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ogNkX-001Ksl-SS for linux-arm-kernel@lists.infradead.org; Thu, 06 Oct 2022 10:05:09 +0000 Received: by mail-wr1-x432.google.com with SMTP id b7so1897724wrq.9 for ; Thu, 06 Oct 2022 03:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WpK3HEcxibyqFugwFNWtBIn86oNeXCvN7BKqOHswlgA=; b=uM9HzOePGDYNdUPbTWeUMjWdVjHoYjfTzPNWnmhbIC2Dhp6WhbxLT0x1Esu4jsEx7a FJ6zSC7wCuoO3ldP54UZRiOKr7mvVvlW6wEVDZ5ExF9PkKoIojrSYFA1MtZ//aKbzmgT o+oRefRmk2W8wNIfOVrHJ+yM/YXcRvyDjNsGiTMal7GH/mIb3F3sKFYhgsBFXxiUdrK6 UnlnNC+OI7WD1PMUaWI9dXh9TLuY0MGdHMuu9FSCH3mZKCK3Q5xYf2R8UaLrAMCbjGH6 0D8Rl7YIdomaevqqy0/4aWRzanIWQ75az3z611q+NiPJo4M/oklXDDNkxTIEQLp1BGFl lcjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WpK3HEcxibyqFugwFNWtBIn86oNeXCvN7BKqOHswlgA=; b=3WvZJ4vx3x6AFEOlClkKVErZksBXV3DfPVYEeD/IOYfZ3zGKKHuQW8SWBjy7GDq55H IxMEi1SxFTF/mfEGCUdhJwHsdaK2Fi7G/6Xw9vNq0D6GKPd2pgBXS7RphFxWdXN80Tfu CRSqYwCBnx8tg8dfzJsLRbZyXFDdq9dIAY+m1Y+eN+QtG+Wo4ru1zfEOtyKBTd5AlLRM QxlJoUptLvO/DCaamV68eCVqcGDWbiRil2J735SYpeDXnzEmds4ZcfNJLQvmiANHW3p9 902G3pi+kurPFMkp2d2sT9BEtxYmbbQs9Yj/WCVgJmL/ZLaGwmBi6u6pYVBsNxVCPJsn X7TQ== X-Gm-Message-State: ACrzQf0YExsoc6yQVT8kT1oan+eWIdOKk9HEZW+xQVWsPsG+5Bi4nPzI plbRvZvHgssRto5Irzm41lwR8A== X-Google-Smtp-Source: AMsMyM7CJ6PtzzkeBzex4HDz66ngkKYtXQI1uZDi5YTDtwdhQ98N9OpHJt69/dNHNbzqRDYjr/FdAA== X-Received: by 2002:a5d:64c2:0:b0:22e:41b1:faf7 with SMTP id f2-20020a5d64c2000000b0022e41b1faf7mr2433214wri.428.1665050701841; Thu, 06 Oct 2022 03:05:01 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id y9-20020a5d4ac9000000b0021badf3cb26sm22098016wrs.63.2022.10.06.03.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 03:05:01 -0700 (PDT) Date: Thu, 6 Oct 2022 11:04:59 +0100 From: Daniel Thompson To: Linus Walleij Cc: Dmitry Torokhov , Sascha Hauer , Krzysztof Kozlowski , Rob Herring , Lee Jones , Jingoo Han , Shawn Guo , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221006_030505_947486_FF93E771 X-CRM114-Status: GOOD ( 20.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote: > On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov > wrote: > > > > Dmitry, could you fix this? Just patch away in gpiolib-of.c. > > > > Sure, I'll add a few quirks. I wonder what is the best way to merge > > this? I can create a bunch of IBs to be pulled, or I can send quirks to > > you/Bartosz and once they land send the patches to drivers... > > When I did it I was sufficiently convinced that I was the only one patching > the quirks in gpiolib-of.c that merge window so I just included it as > a hunk in the driver patch. If there will be some more patches to that > file I guess some separate patch(es) for gpiolib-of.c is needed, maybe > an immutable branch for those if it becomes a lot. Are renames likely to be a common quirk on the road to libgpiod conversion? I admit I sort of expected it to be common enough that there would be one rename quirk in the code supported by an alphabetized string table. Such a table would certainly still provoke troublesome merges but ones that are trivially resolved. Daniel. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2A04AC433F5 for ; Thu, 6 Oct 2022 10:05:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EA7210E090; Thu, 6 Oct 2022 10:05:09 +0000 (UTC) Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9D69410E090 for ; Thu, 6 Oct 2022 10:05:03 +0000 (UTC) Received: by mail-wr1-x432.google.com with SMTP id u10so1922231wrq.2 for ; Thu, 06 Oct 2022 03:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WpK3HEcxibyqFugwFNWtBIn86oNeXCvN7BKqOHswlgA=; b=uM9HzOePGDYNdUPbTWeUMjWdVjHoYjfTzPNWnmhbIC2Dhp6WhbxLT0x1Esu4jsEx7a FJ6zSC7wCuoO3ldP54UZRiOKr7mvVvlW6wEVDZ5ExF9PkKoIojrSYFA1MtZ//aKbzmgT o+oRefRmk2W8wNIfOVrHJ+yM/YXcRvyDjNsGiTMal7GH/mIb3F3sKFYhgsBFXxiUdrK6 UnlnNC+OI7WD1PMUaWI9dXh9TLuY0MGdHMuu9FSCH3mZKCK3Q5xYf2R8UaLrAMCbjGH6 0D8Rl7YIdomaevqqy0/4aWRzanIWQ75az3z611q+NiPJo4M/oklXDDNkxTIEQLp1BGFl lcjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WpK3HEcxibyqFugwFNWtBIn86oNeXCvN7BKqOHswlgA=; b=6xGhacnbA/ZYwA4guasHmmnMNLkYMqe6MY6Ln1XJ0Wv/no3mJtE8qg7vLVKUgXfh9j yrfifAEOz3zUUFaxzOzNTv7CL593DCBxMqOmTKYCyu2VoS4lj/V2TU0K5NnGONirWtHI rUnQG7R31zrNGzaI2S+rqLToTGwNfFP2veWkwLJ07FiG05zu38mam2M0H0RIBkYWFq/q cnC/c7u0flxYshsKqcMyEQ8sS6FpShYN4y3QSIXd5FzsUsNB6ComRqSqJ/+Od9D29u7R uZPVAh52AfiOcwKKtXm1xbwJVCYw0+KD1HiHU1WlWMQawU5pS4r1jQsu5SklEp164SUi d5pA== X-Gm-Message-State: ACrzQf3vRtsqcYiZX3fcx3/GHU0bcj98FTlOj3vCjHzu6eiGTzovl9dT nmS5sGif64rEVaAiG5uAEue3qA== X-Google-Smtp-Source: AMsMyM7CJ6PtzzkeBzex4HDz66ngkKYtXQI1uZDi5YTDtwdhQ98N9OpHJt69/dNHNbzqRDYjr/FdAA== X-Received: by 2002:a5d:64c2:0:b0:22e:41b1:faf7 with SMTP id f2-20020a5d64c2000000b0022e41b1faf7mr2433214wri.428.1665050701841; Thu, 06 Oct 2022 03:05:01 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id y9-20020a5d4ac9000000b0021badf3cb26sm22098016wrs.63.2022.10.06.03.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 03:05:01 -0700 (PDT) Date: Thu, 6 Oct 2022 11:04:59 +0100 From: Daniel Thompson To: Linus Walleij Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , Jingoo Han , Sascha Hauer , Dmitry Torokhov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , NXP Linux Team , Krzysztof Kozlowski , Shawn Guo , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote: > On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov > wrote: > > > > Dmitry, could you fix this? Just patch away in gpiolib-of.c. > > > > Sure, I'll add a few quirks. I wonder what is the best way to merge > > this? I can create a bunch of IBs to be pulled, or I can send quirks to > > you/Bartosz and once they land send the patches to drivers... > > When I did it I was sufficiently convinced that I was the only one patching > the quirks in gpiolib-of.c that merge window so I just included it as > a hunk in the driver patch. If there will be some more patches to that > file I guess some separate patch(es) for gpiolib-of.c is needed, maybe > an immutable branch for those if it becomes a lot. Are renames likely to be a common quirk on the road to libgpiod conversion? I admit I sort of expected it to be common enough that there would be one rename quirk in the code supported by an alphabetized string table. Such a table would certainly still provoke troublesome merges but ones that are trivially resolved. Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D6D7C433FE for ; Thu, 6 Oct 2022 10:05:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230395AbiJFKFI (ORCPT ); Thu, 6 Oct 2022 06:05:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56500 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229665AbiJFKFG (ORCPT ); Thu, 6 Oct 2022 06:05:06 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5A2E22610F for ; Thu, 6 Oct 2022 03:05:03 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id j16so1914830wrh.5 for ; Thu, 06 Oct 2022 03:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=WpK3HEcxibyqFugwFNWtBIn86oNeXCvN7BKqOHswlgA=; b=uM9HzOePGDYNdUPbTWeUMjWdVjHoYjfTzPNWnmhbIC2Dhp6WhbxLT0x1Esu4jsEx7a FJ6zSC7wCuoO3ldP54UZRiOKr7mvVvlW6wEVDZ5ExF9PkKoIojrSYFA1MtZ//aKbzmgT o+oRefRmk2W8wNIfOVrHJ+yM/YXcRvyDjNsGiTMal7GH/mIb3F3sKFYhgsBFXxiUdrK6 UnlnNC+OI7WD1PMUaWI9dXh9TLuY0MGdHMuu9FSCH3mZKCK3Q5xYf2R8UaLrAMCbjGH6 0D8Rl7YIdomaevqqy0/4aWRzanIWQ75az3z611q+NiPJo4M/oklXDDNkxTIEQLp1BGFl lcjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=WpK3HEcxibyqFugwFNWtBIn86oNeXCvN7BKqOHswlgA=; b=BnunJm0mIvvXw6sYpeZC9ZJPW2VFY+RLP1JGlSbf2o4du1YqHfNp3Rsd+Kmw7slYKy 1FplJ1tYR+8rG405L8A8Gxzb/Wh+aL7BvhJMKbWDsXHtLNfIT6TdePUPYxb8+RSLKwlP ROTDnq23OgVLqB3CxbUarb0tH8ch54YVJHgGxGoP66vXxQYSQCuJHlWthzgKnjgTWttz p7hlk7nUZGUsyQpsYVpwlQ1WZK6EljluucoY22aD867YSDtbvMHkcAP3XGX6z7sg2iVH 8axWsqTdY41kxMrJc5QyKufbe3/OktyeEFVsb3WYc1QJO31dDIB+8QS0mM+M2Z42kCX1 LCrg== X-Gm-Message-State: ACrzQf123KMt/SuNm8enpsdLKXl1pkDLy8/vNtVOGUtx9cSt/anwSodh OUCKtcfDS7AjV7sy8+cCXz6/sQ== X-Google-Smtp-Source: AMsMyM7CJ6PtzzkeBzex4HDz66ngkKYtXQI1uZDi5YTDtwdhQ98N9OpHJt69/dNHNbzqRDYjr/FdAA== X-Received: by 2002:a5d:64c2:0:b0:22e:41b1:faf7 with SMTP id f2-20020a5d64c2000000b0022e41b1faf7mr2433214wri.428.1665050701841; Thu, 06 Oct 2022 03:05:01 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id y9-20020a5d4ac9000000b0021badf3cb26sm22098016wrs.63.2022.10.06.03.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Oct 2022 03:05:01 -0700 (PDT) Date: Thu, 6 Oct 2022 11:04:59 +0100 From: Daniel Thompson To: Linus Walleij Cc: Dmitry Torokhov , Sascha Hauer , Krzysztof Kozlowski , Rob Herring , Lee Jones , Jingoo Han , Shawn Guo , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 06, 2022 at 11:03:15AM +0200, Linus Walleij wrote: > On Tue, Oct 4, 2022 at 10:35 PM Dmitry Torokhov > wrote: > > > > Dmitry, could you fix this? Just patch away in gpiolib-of.c. > > > > Sure, I'll add a few quirks. I wonder what is the best way to merge > > this? I can create a bunch of IBs to be pulled, or I can send quirks to > > you/Bartosz and once they land send the patches to drivers... > > When I did it I was sufficiently convinced that I was the only one patching > the quirks in gpiolib-of.c that merge window so I just included it as > a hunk in the driver patch. If there will be some more patches to that > file I guess some separate patch(es) for gpiolib-of.c is needed, maybe > an immutable branch for those if it becomes a lot. Are renames likely to be a common quirk on the road to libgpiod conversion? I admit I sort of expected it to be common enough that there would be one rename quirk in the code supported by an alphabetized string table. Such a table would certainly still provoke troublesome merges but ones that are trivially resolved. Daniel.