From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Vitaly Chikunov <vt@altlinux.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
linux-perf-users@vger.kernel.org,
"Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: /usr/include/perf/event.h:9:10: fatal error: linux/compiler.h: No such file or directory
Date: Thu, 6 Oct 2022 16:36:07 -0300 [thread overview]
Message-ID: <Yz8uJ9gdYOUIuhIL@kernel.org> (raw)
In-Reply-To: <CAP-5=fXqQpcVk+mzPpM9vC=RHTcZvm4Ng14dJ0Uax4kCQ5Qa7Q@mail.gmail.com>
Em Thu, Oct 06, 2022 at 10:20:34AM -0700, Ian Rogers escreveu:
> On Thu, Oct 6, 2022 at 8:16 AM Vitaly Chikunov <vt@altlinux.org> wrote:
> >
> > On Thu, Oct 06, 2022 at 05:28:53PM +0300, Vitaly Chikunov wrote:
> > > I noticed that perf examples do not compile anymore with v6.0 (first on ALT,
> > > but on Fedora is the same). Fedora example for convenience:
> > >
> > > # dnf install kernel libperf-devel gcc
> > > # cc /usr/share/doc/libperf/examples/counting.c -lperf
> > > In file included from /usr/share/doc/libperf/examples/counting.c:8:
> > > /usr/include/perf/event.h:9:10: fatal error: linux/compiler.h: No such file or directory
> > > 9 | #include <linux/compiler.h>
> > > | ^~~~~~~~~~~~~~~~~~
> > > compilation terminated.
> >
> > This is introduced in b2f10cd4e805 ("perf cpumap: Fix alignment for
> > masks in event encoding") just (it seems) for `__packed'.
> > I am told that all uapi is using __attribute__ ((__packed__)) for that.
> >
> > Thanks,
>
> Thanks for reporting the issue and sorry for the breakage. I'm not a
> dependency/packaging expert. Arnaldo, what should be the next steps
> here?
I guess we should just use '__attribute__ ((__packed__))', as its what
we see when grepping for attribute on /usr/include/linux/
But t his patch seems to simple remove the packed, no? I.e. is that
packed really needed?
- Arnaldo
next prev parent reply other threads:[~2022-10-06 19:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-06 14:28 /usr/include/perf/event.h:9:10: fatal error: linux/compiler.h: No such file or directory Vitaly Chikunov
2022-10-06 15:16 ` Vitaly Chikunov
2022-10-06 17:20 ` Ian Rogers
2022-10-06 19:36 ` Arnaldo Carvalho de Melo [this message]
2022-10-06 20:32 ` Ian Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yz8uJ9gdYOUIuhIL@kernel.org \
--to=acme@kernel.org \
--cc=acme@redhat.com \
--cc=irogers@google.com \
--cc=ldv@altlinux.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=vt@altlinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.