From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1ocSER-0002xu-UL for mharc-grub-devel@gnu.org; Sun, 25 Sep 2022 10:03:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46964) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocSEP-0002wM-RF for grub-devel@gnu.org; Sun, 25 Sep 2022 10:03:43 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40565) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocSEN-0003Vy-S7 for grub-devel@gnu.org; Sun, 25 Sep 2022 10:03:41 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id E19815C0041; Sun, 25 Sep 2022 10:03:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Sun, 25 Sep 2022 10:03:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=cc:cc :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm2; t=1664114618; x=1664201018; bh=Aluene1r8j b5S7RakfFQQPggCdfsRfCLpY6iGtjq4gs=; b=CRJH4FRS6s6CSY/PlZyxqEkGLB m/IfmrTsMBdl0PEaR+yEuAwttcXfkh/1qmxLWL90wRiFQG7e3/dfKj2yhB/3jJET f8O7sKPILokM6rxhURV54VldekFRFBiOmxuKZFmraUTWL6gif6mXFs2WxeEpIGhz he2fi77zGNnCxXan0lDeXH8NYN7ifWVs3RpUh4RH10YUGzrN+1N6M7lu9vERcrvw 63A6zvNyZA8L1nQNYffdQ7P92ZRZ0maqYNmnK5/JhbKTVawYxGwOaooPZfoj9Fdg hCA8wnoY/V679JLVCRVH2+VLftiiO1Hj+ROm7PrnxzsXi2qYKvq0Z6sR6HOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664114618; x=1664201018; bh=Aluene1r8jb5S7RakfFQQPggCdfs RfCLpY6iGtjq4gs=; b=f7JCSWPS85TUUacvuC1KhjbR8B3twL8Ylf0ped5KbZ+9 PBudHl0TqxZFRgKRsn2trfgXpAsIX98pXG32JZ4cWJLxvZt9w/m4HqMRuNT5RyP7 0awaCr5WmPGUpJ/66jz5dEoTnpDCUW5eb91qDhtHLB1CxCLuGAT5/2ZxmqKEfOJ8 5hRv751EtAPQhrejqeX1a1rAX5Ug8U9fHeJzed4EOXVvYpINAawyn2JmSvCiNcBy c8hoITkHnsXnxd7G71mfnUVmRxTXDirRuwY0j1TUXp6WCKK9qZ6ON4gLLU3d2Raf s2G8+NDWLA2zniB5ZWoLO7JNzgp9eA8fh9CVyf+N+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegtddgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesghdtreertddtvdenucfhrhhomheprfgrthhr ihgtkhcuufhtvghinhhhrghrughtuceophhssehpkhhsrdhimheqnecuggftrfgrthhtvg hrnhephfeiieeuvdffveeigeejjeffkeektdehleekvdekheeilefgkeefvdegtdekfeei necuffhomhgrihhnpehgnhhurdhorhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Feedback-ID: i197146af:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 25 Sep 2022 10:03:36 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id f8f2eabc (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 25 Sep 2022 14:03:35 +0000 (UTC) Date: Sun, 25 Sep 2022 16:03:34 +0200 From: Patrick Steinhardt To: Daniel Kiper Cc: Daniel Axtens , grub-devel@gnu.org, droidbittin@gmail.com, glin@suse.com, heinrich.schuchardt@canonical.com, jim945@mail.ru, langner.marcel@myiq.de, marcan@marcan.st, zhangboyang.id@gmail.com Subject: Re: [PATCH] efi: Increase default memory allocation to 32MB Message-ID: References: <20220919143030.355141-1-dja@axtens.net> <20220922155934.7eyw2e6a3pgvmikv@tomti.i.net-space.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zAA4H01LjEZBWK/d" Content-Disposition: inline In-Reply-To: <20220922155934.7eyw2e6a3pgvmikv@tomti.i.net-space.pl> Received-SPF: pass client-ip=66.111.4.29; envelope-from=ps@pks.im; helo=out5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Sep 2022 14:03:43 -0000 --zAA4H01LjEZBWK/d Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Sep 22, 2022 at 05:59:34PM +0200, Daniel Kiper wrote: > Adding some folks who may be interested in this thing too... >=20 > On Tue, Sep 20, 2022 at 12:30:30AM +1000, Daniel Axtens wrote: > > We have multiple reports of things being slower with a 1MB initial stat= ic > > allocation, and a report (more difficult to nail down) of a boot failure > > as a result of the smaller initial allocation. > > > > Make the initial memory allocation 32MB. > > > > Signed-off-by: Daniel Axtens >=20 > Reviewed-by: Daniel Kiper >=20 > However, I think we should consider [1] patch set too. I will be > looking at it in the following days. >=20 > Daniel >=20 > [1] https://lists.gnu.org/archive/html/grub-devel/2022-09/msg00080.html Agreed, we should definitely merge some form of fixes to improve the page request patterns. I'm also happy with bumping the default heap size in addition. Out of curiosity: do we have any kind of minimum system requirements documented somewhere that would allow us to come up with a default heap size? Patrick >=20 > > --- > > grub-core/kern/efi/mm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/grub-core/kern/efi/mm.c b/grub-core/kern/efi/mm.c > > index d290c9a76270..3705b8b1b465 100644 > > --- a/grub-core/kern/efi/mm.c > > +++ b/grub-core/kern/efi/mm.c > > @@ -39,7 +39,7 @@ > > #define MEMORY_MAP_SIZE 0x3000 > > > > /* The default heap size for GRUB itself in bytes. */ > > -#define DEFAULT_HEAP_SIZE 0x100000 > > +#define DEFAULT_HEAP_SIZE 0x2000000 > > > > static void *finish_mmap_buf =3D 0; > > static grub_efi_uintn_t finish_mmap_size =3D 0; --zAA4H01LjEZBWK/d Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEF9hrgiFbCdvenl/rVbJhu7ckPpQFAmMwX7UACgkQVbJhu7ck PpRZQA//U4hE5+xdfXDkcv5l/s7NuTh10VACySrYkn7e8kDQcEWu1m1r8NLLCaBT zsKhzXqu40Y37vnEDkrfX2kdAoWnLzGOXws6/zogHEw9/SvIexd+w72qhTHJFA5+ N/KXZmR9vLTKnJg4fQWUiIHGkr/cAfMsIiCwpix4Z2rNcYz1tgx7MvO5cQSAMPaJ v/SKmbt/7YOcKz/WF5MeMwAE8YpLEMM/DIiwUMd8vw388HVVDkv/VZxYA6ucVOgv oV+Hw8bsfHyWn1ibLILVeDq13qe1RwWCEkX8Uz1fDRP+htZTU/zl1US3W6rm7r+Y rEiDbgpGHpbI04YMBvrQE76xh6LkyLkLyIkDBKmvfYbDxg1WRrHsluDljlvAf6wA Txd23/RTxattZgAIGcEu+20h2e4/b/RpbxoINoYSI4m1owkOdSrGHgD1+WNoBnci XX8bbh0l784RkGv/myonhpujgAa3Jzrqved2Fn5OsqnMeHwmJmrtM/uEVhtU1v9U ABbHPEkXCSgNBWtSAdeevzUdSaK+GdBAUolu1TDtlcXsWvo/LfGTSICB2v89op5M tPzA1y+B8pGsVtWc1mymNb9YN0JFv1eHEkaa8gVO9Qklc0ZU6Md2XTiq8GHvrQl6 x3+B0ibR/LHR3V36WdxqBm7dzYoSeR8ywkK8O/rkmmoXA/Ep2Xg= =0VIQ -----END PGP SIGNATURE----- --zAA4H01LjEZBWK/d--