From: Lee Jones <lee@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
"Tony Lindgren" <tony@atomide.com>
Subject: Re: [PATCH v1 1/1] mfd: twl4030: Add missed linux/device.h header
Date: Mon, 26 Sep 2022 08:48:16 +0100 [thread overview]
Message-ID: <YzFZQLVeK9pXrKmF@google.com> (raw)
In-Reply-To: <20220923175401.8723-1-andriy.shevchenko@linux.intel.com>
On Fri, 23 Sep 2022, Andy Shevchenko wrote:
> With compile testing on non-OMAP platforms compiler might be not happy:
>
> In function ‘twl4030_sih_setup’:
> error: implicit declaration of function ‘dev_err’ [-Werror=implicit-function-declaration]
> error: implicit declaration of function ‘dev_info’ [-Werror=implicit-function-declaration]
> In function ‘twl4030_init_irq’:
> error: invalid use of undefined type ‘struct device’
>
> Add missed header.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/mfd/twl4030-irq.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2022-09-26 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-23 17:54 [PATCH v1 1/1] mfd: twl4030: Add missed linux/device.h header Andy Shevchenko
2022-09-26 7:48 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzFZQLVeK9pXrKmF@google.com \
--to=lee@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.