From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E073C07E9D for ; Mon, 26 Sep 2022 11:02:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C20BD40E62; Mon, 26 Sep 2022 07:02:04 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pBE+1ttOvW0B; Mon, 26 Sep 2022 07:02:03 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 7E1104B7FD; Mon, 26 Sep 2022 07:02:03 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0644E4B7ED for ; Mon, 26 Sep 2022 07:02:02 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZBdd0yTNftBa for ; Mon, 26 Sep 2022 07:02:00 -0400 (EDT) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id B2C0C40E62 for ; Mon, 26 Sep 2022 07:02:00 -0400 (EDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCF7C1063; Mon, 26 Sep 2022 04:02:06 -0700 (PDT) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0DA563F66F; Mon, 26 Sep 2022 04:01:58 -0700 (PDT) Date: Mon, 26 Sep 2022 12:02:54 +0100 From: Alexandru Elisei To: Andrew Jones Subject: Re: [kvm-unit-tests RFC PATCH 13/19] arm: page.h: Add missing libcflat.h include Message-ID: References: <20220809091558.14379-1-alexandru.elisei@arm.com> <20220809091558.14379-14-alexandru.elisei@arm.com> <20220920093956.sh4lunjssia376gf@kamzik> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220920093956.sh4lunjssia376gf@kamzik> Cc: nikos.nikoleris@arm.com, pbonzini@redhat.com, thuth@redhat.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu SGksCgpPbiBUdWUsIFNlcCAyMCwgMjAyMiBhdCAxMTozOTo1NkFNICswMjAwLCBBbmRyZXcgSm9u ZXMgd3JvdGU6Cj4gCj4gSSBndWVzcyB0aGlzIHNob3VsZCBiZSBzcXVhc2hlZCBpbnRvIG9uZSBv ZiB0aGUgZWFybHkgcGF0Y2hlcyBpbiB0aGlzCj4gc2VyaWVzIHNpbmNlIHdlIGRvbid0IGhhdmUg dGhpcyBpc3N1ZSB3aXRoIHRoZSBjdXJyZW50IGNvZGUuCgpXaWxsIGRvLCB0aGFua3MgZm9yIHRo ZSBzdWdnZXN0aW9uIQoKQWxleAoKPiAKPiBUaGFua3MsCj4gZHJldwo+IAo+IAo+IE9uIFR1ZSwg QXVnIDA5LCAyMDIyIGF0IDEwOjE1OjUyQU0gKzAxMDAsIEFsZXhhbmRydSBFbGlzZWkgd3JvdGU6 Cj4gPiBJbmNsdWRlIGxpYmNmbGF0IGZyb20gcGFnZS5oIHRvIGF2b2lkIGVycm9yIGxpa2UgdGhp cyBvbmU6Cj4gPiAKPiA+IC9wYXRoL3RvL2t2bS11bml0LXRlc3RzL2xpYi9hc20vcGFnZS5oOjE5 Ojk6IGVycm9yOiB1bmtub3duIHR5cGUgbmFtZSDigJh1NjTigJkKPiA+ICAgIDE5IHwgdHlwZWRl ZiB1NjQgcHRldmFsX3Q7Cj4gPiAgICAgICB8ICAgICAgICAgXn5+Cj4gPiBbLi5dCj4gPiAvcGF0 aC90by9rdm0tdW5pdC10ZXN0cy9saWIvYXNtL3BhZ2UuaDo0Nzo4OiBlcnJvcjogdW5rbm93biB0 eXBlIG5hbWUg4oCYcGh5c19hZGRyX3TigJkKPiA+ICAgIDQ3IHwgZXh0ZXJuIHBoeXNfYWRkcl90 IF9fdmlydF90b19waHlzKHVuc2lnbmVkIGxvbmcgYWRkcik7Cj4gPiAgICAgICB8ICAgICAgICBe fn5+fn5+fn5+fgo+ID4gICAgICAgfCAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBefn5+fn5+fn5+fgo+ID4gWy4uXQo+ID4gL3BhdGgvdG8va3ZtLXVuaXQtdGVzdHMvbGliL2Fz bS9wYWdlLmg6NTA6NDc6IGVycm9yOiB1bmtub3duIHR5cGUgbmFtZSDigJhzaXplX3TigJkKPiA+ ICAgIDUwIHwgZXh0ZXJuIHZvaWQgKl9faW9yZW1hcChwaHlzX2FkZHJfdCBwaHlzX2FkZHIsIHNp emVfdCBzaXplKTsKPiA+IAo+ID4gVGhlIGFybTY0IHZlcnNpb24gb2YgdGhlIGhlYWRlciBhbHJl YWR5IGluY2x1ZGVzIGxpYmNmbGF0IHNpbmNlIGNvbW1pdAo+ID4gYTJkMDY4NTJmZTU5ICgiYXJt NjQ6IEFkZCBzdXBwb3J0IGZvciBjb25maWd1cmluZyB0aGUgdHJhbnNsYXRpb24KPiA+IGdyYW51 bGUiKS4KPiA+IAo+ID4gU2lnbmVkLW9mZi1ieTogQWxleGFuZHJ1IEVsaXNlaSA8YWxleGFuZHJ1 LmVsaXNlaUBhcm0uY29tPgo+ID4gLS0tCj4gPiAgbGliL2FybS9hc20vcGFnZS5oIHwgMiArKwo+ ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKykKPiA+IAo+ID4gZGlmZiAtLWdpdCBh L2xpYi9hcm0vYXNtL3BhZ2UuaCBiL2xpYi9hcm0vYXNtL3BhZ2UuaAo+ID4gaW5kZXggOGViNGE4 ODM4MDhlLi4wYTQ2YmRhMDE4YzcgMTAwNjQ0Cj4gPiAtLS0gYS9saWIvYXJtL2FzbS9wYWdlLmgK PiA+ICsrKyBiL2xpYi9hcm0vYXNtL3BhZ2UuaAo+ID4gQEAgLTgsNiArOCw4IEBACj4gPiAgCj4g PiAgI2luY2x1ZGUgPGxpbnV4L2NvbnN0Lmg+Cj4gPiAgCj4gPiArI2luY2x1ZGUgPGxpYmNmbGF0 Lmg+Cj4gPiArCj4gPiAgI2RlZmluZSBQQUdFX1NISUZUCQkxMgo+ID4gICNkZWZpbmUgUEFHRV9T SVpFCQkoX0FDKDEsVUwpIDw8IFBBR0VfU0hJRlQpCj4gPiAgI2RlZmluZSBQQUdFX01BU0sJCSh+ KFBBR0VfU0laRS0xKSkKPiA+IC0tIAo+ID4gMi4zNy4xCj4gPiAKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka3ZtYXJtIG1haWxpbmcgbGlzdAprdm1hcm1A bGlzdHMuY3MuY29sdW1iaWEuZWR1Cmh0dHBzOi8vbGlzdHMuY3MuY29sdW1iaWEuZWR1L21haWxt YW4vbGlzdGluZm8va3ZtYXJtCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6D906C6FA83 for ; Mon, 26 Sep 2022 13:11:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235508AbiIZNLZ (ORCPT ); Mon, 26 Sep 2022 09:11:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233546AbiIZNKo (ORCPT ); Mon, 26 Sep 2022 09:10:44 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BB6168983E for ; Mon, 26 Sep 2022 04:40:12 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CCF7C1063; Mon, 26 Sep 2022 04:02:06 -0700 (PDT) Received: from monolith.localdoman (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0DA563F66F; Mon, 26 Sep 2022 04:01:58 -0700 (PDT) Date: Mon, 26 Sep 2022 12:02:54 +0100 From: Alexandru Elisei To: Andrew Jones Cc: pbonzini@redhat.com, thuth@redhat.com, kvm@vger.kernel.org, kvmarm@lists.cs.columbia.edu, nikos.nikoleris@arm.com Subject: Re: [kvm-unit-tests RFC PATCH 13/19] arm: page.h: Add missing libcflat.h include Message-ID: References: <20220809091558.14379-1-alexandru.elisei@arm.com> <20220809091558.14379-14-alexandru.elisei@arm.com> <20220920093956.sh4lunjssia376gf@kamzik> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220920093956.sh4lunjssia376gf@kamzik> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org Hi, On Tue, Sep 20, 2022 at 11:39:56AM +0200, Andrew Jones wrote: > > I guess this should be squashed into one of the early patches in this > series since we don't have this issue with the current code. Will do, thanks for the suggestion! Alex > > Thanks, > drew > > > On Tue, Aug 09, 2022 at 10:15:52AM +0100, Alexandru Elisei wrote: > > Include libcflat from page.h to avoid error like this one: > > > > /path/to/kvm-unit-tests/lib/asm/page.h:19:9: error: unknown type name ‘u64’ > > 19 | typedef u64 pteval_t; > > | ^~~ > > [..] > > /path/to/kvm-unit-tests/lib/asm/page.h:47:8: error: unknown type name ‘phys_addr_t’ > > 47 | extern phys_addr_t __virt_to_phys(unsigned long addr); > > | ^~~~~~~~~~~ > > | ^~~~~~~~~~~ > > [..] > > /path/to/kvm-unit-tests/lib/asm/page.h:50:47: error: unknown type name ‘size_t’ > > 50 | extern void *__ioremap(phys_addr_t phys_addr, size_t size); > > > > The arm64 version of the header already includes libcflat since commit > > a2d06852fe59 ("arm64: Add support for configuring the translation > > granule"). > > > > Signed-off-by: Alexandru Elisei > > --- > > lib/arm/asm/page.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/lib/arm/asm/page.h b/lib/arm/asm/page.h > > index 8eb4a883808e..0a46bda018c7 100644 > > --- a/lib/arm/asm/page.h > > +++ b/lib/arm/asm/page.h > > @@ -8,6 +8,8 @@ > > > > #include > > > > +#include > > + > > #define PAGE_SHIFT 12 > > #define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) > > #define PAGE_MASK (~(PAGE_SIZE-1)) > > -- > > 2.37.1 > >