From: Aurelien Jarno <aurelien@aurel32.net>
To: Peter Geis <pgwipeout@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Frank Wunderlich <frank-w@public-files.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY
Date: Mon, 26 Sep 2022 22:36:13 +0200 [thread overview]
Message-ID: <YzINPR0htauYppWQ@aurel32.net> (raw)
In-Reply-To: <CAMdYzYoR2caD2ecN5vGTiHejoE5AhbyKxSgSeU1+SzU7nNVTwg@mail.gmail.com>
On 2022-09-26 14:58, Peter Geis wrote:
> On Mon, Sep 26, 2022 at 2:35 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
> >
> > This commit fixes the error message
> >
> > rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap
>
> The pipe grf only is used on the rk3588 device for this phy.
Ok, looking at the code in details, I confirm that. Does it mean the
change should be done at the phy driver level, to only look for
rockchip,pipe-grf on the rk3588 device?
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Aurelien Jarno <aurelien@aurel32.net>
To: Peter Geis <pgwipeout@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Frank Wunderlich <frank-w@public-files.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY
Date: Mon, 26 Sep 2022 22:36:13 +0200 [thread overview]
Message-ID: <YzINPR0htauYppWQ@aurel32.net> (raw)
In-Reply-To: <CAMdYzYoR2caD2ecN5vGTiHejoE5AhbyKxSgSeU1+SzU7nNVTwg@mail.gmail.com>
On 2022-09-26 14:58, Peter Geis wrote:
> On Mon, Sep 26, 2022 at 2:35 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
> >
> > This commit fixes the error message
> >
> > rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap
>
> The pipe grf only is used on the rk3588 device for this phy.
Ok, looking at the code in details, I confirm that. Does it mean the
change should be done at the phy driver level, to only look for
rockchip,pipe-grf on the rk3588 device?
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Aurelien Jarno <aurelien@aurel32.net>
To: Peter Geis <pgwipeout@gmail.com>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
Frank Wunderlich <frank-w@public-files.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/Rockchip SoC support"
<linux-arm-kernel@lists.infradead.org>,
"open list:ARM/Rockchip SoC support"
<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY
Date: Mon, 26 Sep 2022 22:36:13 +0200 [thread overview]
Message-ID: <YzINPR0htauYppWQ@aurel32.net> (raw)
In-Reply-To: <CAMdYzYoR2caD2ecN5vGTiHejoE5AhbyKxSgSeU1+SzU7nNVTwg@mail.gmail.com>
On 2022-09-26 14:58, Peter Geis wrote:
> On Mon, Sep 26, 2022 at 2:35 PM Aurelien Jarno <aurelien@aurel32.net> wrote:
> >
> > This commit fixes the error message
> >
> > rockchip-snps-pcie3-phy fe8c0000.phy: failed to find rockchip,pipe_grf regmap
>
> The pipe grf only is used on the rk3588 device for this phy.
Ok, looking at the code in details, I confirm that. Does it mean the
change should be done at the phy driver level, to only look for
rockchip,pipe-grf on the rk3588 device?
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurelien@aurel32.net http://www.aurel32.net
next prev parent reply other threads:[~2022-09-26 20:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 18:35 [PATCH] arm64: dts: rockchip: Add missing rockchip,pipe-grf to rk3568 PCIe v3 PHY Aurelien Jarno
2022-09-26 18:35 ` Aurelien Jarno
2022-09-26 18:35 ` Aurelien Jarno
2022-09-26 18:58 ` Peter Geis
2022-09-26 18:58 ` Peter Geis
2022-09-26 18:58 ` Peter Geis
2022-09-26 20:36 ` Aurelien Jarno [this message]
2022-09-26 20:36 ` Aurelien Jarno
2022-09-26 20:36 ` Aurelien Jarno
2022-09-26 22:34 ` Peter Geis
2022-09-26 22:34 ` Peter Geis
2022-09-26 22:34 ` Peter Geis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzINPR0htauYppWQ@aurel32.net \
--to=aurelien@aurel32.net \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.