From: Christoph Hellwig <hch@infradead.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Pankaj Raghav <p.raghav@samsung.com>,
Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, damien.lemoal@opensource.wdc.com,
gost.dev@samsung.com
Subject: Re: [PATCH 1/2] block: modify blk_mq_plug() to allow only reads for zoned block devices
Date: Tue, 27 Sep 2022 09:51:05 -0700 [thread overview]
Message-ID: <YzMp+SIsv6Aw4bFW@infradead.org> (raw)
In-Reply-To: <fa80eef0-42a4-6ffc-cced-18ecbe5b1f5a@kernel.dk>
On Tue, Sep 27, 2022 at 10:04:19AM -0600, Jens Axboe wrote:
> Ah yes, good point. We used to have this notion of 'fs' request, don't
> think we do anymore. Because it really should just be:
A fs request is a !passthrough request.
> if (zoned && (op & REQ_OP_WRITE) && fs_request)
> return NULL;
>
> for that condition imho. I guess we could make it:
>
> if (zoned && (op & REQ_OP_WRITE) && !(op & REQ_OP_DRV_OUT))
> return NULL;
Well, the only opcodes we do zone locking for is REQ_OP_WRITE and
REQ_OP_WRITE_ZEROES. So this should be:
if (zoned && (op == REQ_OP_WRITE || op == REQ_OP_WRITE_ZEROES))
return NULL;
next prev parent reply other threads:[~2022-09-27 16:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220925185349eucas1p1dc689bac64668ca038ba8646c44fd580@eucas1p1.samsung.com>
2022-09-25 18:53 ` [PATCH 0/2] enable plugging only for reads in zoned block devices Pankaj Raghav
2022-09-25 18:53 ` [PATCH 1/2] block: modify blk_mq_plug() to allow only reads for " Pankaj Raghav
2022-09-25 22:55 ` Damien Le Moal
2022-09-26 14:37 ` Christoph Hellwig
2022-09-26 14:40 ` Jens Axboe
2022-09-26 14:43 ` Christoph Hellwig
2022-09-26 16:32 ` Jens Axboe
2022-09-26 19:20 ` Pankaj Raghav
2022-09-26 19:25 ` Jens Axboe
2022-09-27 15:20 ` Pankaj Raghav
2022-09-27 16:04 ` Jens Axboe
2022-09-27 16:51 ` Christoph Hellwig [this message]
2022-09-27 16:52 ` Jens Axboe
2022-09-27 23:07 ` Damien Le Moal
2022-09-27 23:10 ` Damien Le Moal
2022-09-27 23:13 ` Jens Axboe
2022-09-27 23:12 ` Jens Axboe
2022-09-27 23:35 ` Damien Le Moal
2022-09-28 11:57 ` Pankaj Raghav
2022-09-28 22:19 ` Damien Le Moal
2022-09-25 18:53 ` [PATCH 2/2] block: use blk_mq_plug() in blk_execute_rq_nowait() Pankaj Raghav
2022-09-25 22:56 ` Damien Le Moal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzMp+SIsv6Aw4bFW@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=damien.lemoal@opensource.wdc.com \
--cc=gost.dev@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=p.raghav@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.