From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Asmaa Mnebhi <asmaa@nvidia.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Khalil Blaiech <kblaiech@nvidia.com>
Subject: Re: [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC
Date: Tue, 27 Sep 2022 21:53:18 +0200 [thread overview]
Message-ID: <YzNUrsFbG0vfP1Rx@shikoro> (raw)
In-Reply-To: <20220926194507.24786-5-asmaa@nvidia.com>
[-- Attachment #1: Type: text/plain, Size: 309 bytes --]
> + ret = mlxbf_i2c_init_resource(pdev, &priv->smbus,
> + MLXBF_I2C_SMBUS_RES);
Did you maybe forget to check 'ret' here?
> + priv->timer->io = priv->smbus->io;
> + priv->mst->io = priv->smbus->io + MLXBF_I2C_MST_ADDR_OFFSET;
> + priv->slv->io = priv->smbus->io + MLXBF_I2C_SLV_ADDR_OFFSET;
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-09-27 19:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 19:45 [PATCH v6 0/5] i2c: i2c-mlxbf.c: bug fixes and new feature support Asmaa Mnebhi
2022-09-26 19:45 ` [PATCH v6 1/5] i2c: i2c-mlxbf.c: remove IRQF_ONESHOT Asmaa Mnebhi
2022-09-27 19:40 ` Wolfram Sang
2022-09-26 19:45 ` [PATCH v6 2/5] i2c: i2c-mlxbf.c: support lock mechanism Asmaa Mnebhi
2022-09-27 19:41 ` Wolfram Sang
2022-09-26 19:45 ` [PATCH v6 3/5] i2c: i2c-mlxbf: add multi slave functionality Asmaa Mnebhi
2022-09-27 19:43 ` Wolfram Sang
2022-09-26 19:45 ` [PATCH v6 4/5] i2c: i2c-mlxbf.c: support BlueField-3 SoC Asmaa Mnebhi
2022-09-27 19:53 ` Wolfram Sang [this message]
2022-09-27 19:56 ` Asmaa Mnebhi
2022-09-26 19:45 ` [PATCH v6 5/5] i2c: i2c-mlxbf.c: remove device tree support Asmaa Mnebhi
2022-09-26 19:50 ` Asmaa Mnebhi
2022-09-27 16:35 ` kernel test robot
2022-09-27 19:54 ` Wolfram Sang
2022-09-27 19:57 ` Asmaa Mnebhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzNUrsFbG0vfP1Rx@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=asmaa@nvidia.com \
--cc=kblaiech@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.