From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Rojtberg <rojtberg@gmail.com>
Cc: linux-input@vger.kernel.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/2] Input: xpad - refactor using BIT() macro
Date: Tue, 27 Sep 2022 18:04:16 -0700 [thread overview]
Message-ID: <YzOdkGkkA9n+hFEN@google.com> (raw)
In-Reply-To: <20220913213133.584979-2-rojtberg@gmail.com>
On Tue, Sep 13, 2022 at 11:31:32PM +0200, Pavel Rojtberg wrote:
> From: Pavel Rojtberg <rojtberg@gmail.com>
>
> reduces the amount of magic numbers and makes the code more readable
>
It is nice to include headers defining used APIs directly, so I added
"#include <linux/bits.h>" and applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2022-09-28 1:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-13 21:31 [PATCH 0/2] Input: xpad - reduce amount of magic numbers Pavel Rojtberg
2022-09-13 21:31 ` [PATCH 1/2] Input: xpad - refactor using BIT() macro Pavel Rojtberg
2022-09-28 1:04 ` Dmitry Torokhov [this message]
2022-09-13 21:31 ` [PATCH 2/2] Input: xpad - decipher xpadone packages with GIP defines Pavel Rojtberg
2022-09-28 1:04 ` Dmitry Torokhov
2022-09-27 17:26 ` [PATCH 0/2] Input: xpad - reduce amount of magic numbers Pavel Rojtberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzOdkGkkA9n+hFEN@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=rojtberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.