All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Rapoport <rppt@kernel.org>
To: Vernon Yang <vernon2gm@gmail.com>
Cc: corbet@lwn.net, akpm@linux-foundation.org, bobwxc@email.cn,
	hughd@google.com, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Documentation/mm: modify page_referenced to folio_referenced
Date: Wed, 28 Sep 2022 10:57:29 +0300	[thread overview]
Message-ID: <YzP+aZsR6Lov7zi6@kernel.org> (raw)
In-Reply-To: <20220926152032.74621-1-vernon2gm@gmail.com>

On Mon, Sep 26, 2022 at 11:20:32PM +0800, Vernon Yang wrote:
> Since commit b3ac04132c4b ("mm/rmap: Turn page_referenced() into
> folio_referenced()") the page_referenced function name was modified,
> so fix it up to use the correct one.
> 
> Signed-off-by: Vernon Yang <vernon2gm@gmail.com>

Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  Documentation/mm/unevictable-lru.rst | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/mm/unevictable-lru.rst b/Documentation/mm/unevictable-lru.rst
> index b280367d6a44..4a0e158aa9ce 100644
> --- a/Documentation/mm/unevictable-lru.rst
> +++ b/Documentation/mm/unevictable-lru.rst
> @@ -197,7 +197,7 @@ unevictable list for the memory cgroup and node being scanned.
>  There may be situations where a page is mapped into a VM_LOCKED VMA, but the
>  page is not marked as PG_mlocked.  Such pages will make it all the way to
>  shrink_active_list() or shrink_page_list() where they will be detected when
> -vmscan walks the reverse map in page_referenced() or try_to_unmap().  The page
> +vmscan walks the reverse map in folio_referenced() or try_to_unmap().  The page
>  is culled to the unevictable list when it is released by the shrinker.
>  
>  To "cull" an unevictable page, vmscan simply puts the page back on the LRU list
> @@ -267,7 +267,7 @@ the LRU.  Such pages can be "noticed" by memory management in several places:
>   (4) in the fault path and when a VM_LOCKED stack segment is expanded; or
>  
>   (5) as mentioned above, in vmscan:shrink_page_list() when attempting to
> -     reclaim a page in a VM_LOCKED VMA by page_referenced() or try_to_unmap().
> +     reclaim a page in a VM_LOCKED VMA by folio_referenced() or try_to_unmap().
>  
>  mlocked pages become unlocked and rescued from the unevictable list when:
>  
> @@ -547,7 +547,7 @@ vmscan's shrink_inactive_list() and shrink_page_list() also divert obviously
>  unevictable pages found on the inactive lists to the appropriate memory cgroup
>  and node unevictable list.
>  
> -rmap's page_referenced_one(), called via vmscan's shrink_active_list() or
> +rmap's folio_referenced_one(), called via vmscan's shrink_active_list() or
>  shrink_page_list(), and rmap's try_to_unmap_one() called via shrink_page_list(),
>  check for (3) pages still mapped into VM_LOCKED VMAs, and call mlock_vma_page()
>  to correct them.  Such pages are culled to the unevictable list when released
> -- 
> 2.25.1
> 

-- 
Sincerely yours,
Mike.

  reply	other threads:[~2022-09-28  7:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-26 15:20 [PATCH] Documentation/mm: modify page_referenced to folio_referenced Vernon Yang
2022-09-28  7:57 ` Mike Rapoport [this message]
2022-09-29 19:16 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YzP+aZsR6Lov7zi6@kernel.org \
    --to=rppt@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=bobwxc@email.cn \
    --cc=corbet@lwn.net \
    --cc=hughd@google.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vernon2gm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.