From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Rajat Khandelwal <rajat.khandelwal@intel.com>,
andreas.noever@gmail.com, michael.jamet@intel.com,
YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: Add wake on connect/disconnect on USB4 ports
Date: Wed, 28 Sep 2022 08:01:03 +0300 [thread overview]
Message-ID: <YzPVDzI4K4cbG7Mk@black.fi.intel.com> (raw)
In-Reply-To: <YzMpaa1V492X52/J@kroah.com>
Hi Greg,
On Tue, Sep 27, 2022 at 06:48:41PM +0200, Greg KH wrote:
> On Wed, Sep 28, 2022 at 06:30:05PM +0530, Rajat Khandelwal wrote:
> > Wake on connect/disconnect is only supported while runtime suspend
> > for now, which is obviously necessary. Its also not inherently
> > desired for the system to wakeup on thunderbolt hot events.
> > However, we can still make user in control of waking up the system
> > in the events of hot plug/unplug.
> > This patch adds 'wakeup' attribute under 'usb4_portX/power' sysfs
> > attribute and only enables wakes on connect/disconnect to the
> > respective port when 'wakeup' is set to 'enabled'. The attribute
> > is set to 'disabled' by default.
> >
> > Signed-off-by: Rajat Khandelwal <rajat.khandelwal@intel.com>
>
> Including the issue pointed out below by my bot, Intel has a "special"
> requirement that you are not meeting here in order to send out patches
> for review on a public mailing list in a subsystem like this (i.e. one
> that I and others review patches on.)
>
> Please meet that requirement first before sending any future kernel
> patches out.
I asked Khandelwal to send this patch upstream after we did an internal
review for it (I think I also asked him to send this out after v6.1-rc1
is released but whatever).
I think the bot noticed the v4 he sent earlier that was the same we
reviewed internally.
I was planning to pick this up after the merge window closes if there
are no objections.
next prev parent reply other threads:[~2022-09-28 5:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 13:00 [PATCH] thunderbolt: Add wake on connect/disconnect on USB4 ports Rajat Khandelwal
2022-09-27 16:48 ` Greg KH
2022-09-28 5:01 ` Mika Westerberg [this message]
2022-09-28 6:03 ` Greg KH
2022-09-28 6:08 ` Mika Westerberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzPVDzI4K4cbG7Mk@black.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michael.jamet@intel.com \
--cc=rajat.khandelwal@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.