From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31055C32771 for ; Wed, 28 Sep 2022 15:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234395AbiI1PZ3 (ORCPT ); Wed, 28 Sep 2022 11:25:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234673AbiI1PYt (ORCPT ); Wed, 28 Sep 2022 11:24:49 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C2AD5BC3D; Wed, 28 Sep 2022 08:23:57 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D40C3B82034; Wed, 28 Sep 2022 15:23:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10DC2C433C1; Wed, 28 Sep 2022 15:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664378634; bh=9SIVS1Ktay/VjvIG1Tb63vZHKdfb93SgqGY3i3lFWHI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=seAUZILZ+WhEwxK58YX7ABSmr+ZqeVa/Q2ap9X2g653i2tjww1KSqfPR/bn1JQRF2 BzBinLgdhYVGxfTdsXBc9BiSt+u4w8vsm10ziMZQ5jqNVcy33mctlyPXD3/ZuOqnJV KioubTnY6W/hQ8Iq3iowWuYMI41hf6F39VCm/cByErgfd6iBF4hzf1wAnjfYOTF0Hp kbTDmMcPnG9scsLXNrFz4o204QMW6P1YrO3HhCbx3Q8rr1J74Y5yVR+Jqf8huCEWen YiVD224EYn+z9TfM3Ww00DZrc2dZnhrkMnRMeVMC/wWDazLxkhXJfR/eeYCTXtc559 El5hP+sh11vZw== Date: Wed, 28 Sep 2022 16:23:47 +0100 From: Lee Jones To: Sergiu.Moga@microchip.com Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com, Claudiu.Beznea@microchip.com, radu_nicolae.pirea@upb.ro, richard.genoud@gmail.com, gregkh@linuxfoundation.org, jirislaby@kernel.org, Kavyasree.Kotagiri@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, linux-serial@vger.kernel.org, krzysztof.kozlowski@linaro.org Subject: Re: [PATCH v5 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding Message-ID: References: <20220922113347.144383-1-sergiu.moga@microchip.com> <20220922113347.144383-2-sergiu.moga@microchip.com> <7a0c45e2-85fc-b5b0-d1de-a9e06a20bb42@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7a0c45e2-85fc-b5b0-d1de-a9e06a20bb42@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, 28 Sep 2022, Sergiu.Moga@microchip.com wrote: > On 28.09.2022 18:03, Lee Jones wrote: > > On Thu, 22 Sep 2022, Sergiu Moga wrote: > > > >> Another functionality of FLEXCOM is that of SPI. In order for > >> the proper validation of the SPI children nodes through the binding > >> to occur, the proper binding for SPI must be referenced. > >> > >> Signed-off-by: Sergiu Moga > >> Reviewed-by: Krzysztof Kozlowski > >> --- > >> > >> > >> v1 -> v2: > >> - use full schema paths > >> > >> > >> v2 -> v3: > >> - Added Reviewed-by tag, previously this was [PATCH 3] > >> > >> > >> v3 -> v4: > >> - Nothing, previously this was [PATCH 5] > >> > >> > >> v4 -> v5: > >> - Nothing > >> > >> > >> > >> .../devicetree/bindings/mfd/atmel,sama5d2-flexcom.yaml | 5 ++--- > >> 1 file changed, 2 insertions(+), 3 deletions(-) > > > > Not sure how these can be handled. > > > > I guess I cannot take these until the other patches are applied. > > > > NB: The patch doesn't apply cleanly anyway, so will need to be rebased. > > > > > Hello, > > The sama5d2-flexcom binding related patches are dependent on: > https://lore.kernel.org/linux-arm-kernel/20220916075744.1879428-1-kavyasree.kotagiri@microchip.com/ I would be very cautious about relying on comments made in the cover-letter. Better to make this a hard requirement and place them in the same patch-set. -- Lee Jones [李琼斯] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 785B7C04A95 for ; Wed, 28 Sep 2022 15:24:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AsKbJp4e9lGC+RkFJ22HRjPDGULi3KFWpy5LGwkeaik=; b=JPhHtT5IT4W44s cESm0hpE2pFK7dSEVoNweWA1tDQZjVlUXyDyslBky4XhKhCKoJROKlFwr8pF7GCIaVCwEERHplByR mf4WkmFhA3cMEoknflv65Ykg0DXg4ILr7hNlpV+08sCGfGKUM8RJ83ZcIdoI5ywakaHtkNuZ/1Y1V O0lwjJddncwElYB3I4rPzwe9kjHiZt26PydoKDlQKQWl2LUMgQcMK49ukE3oGN5liQaQczb2lcUe2 ermA/vJA8DCUh99sU1U09sVvUgHkTT35gyfRbAZx/rmEg75nnujiBOUNGXkcEHTnwSPfLCB1BXAp7 T6odSwrV38TYjN5Sfp7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odYuk-00Gsvi-Ri; Wed, 28 Sep 2022 15:23:58 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odYuh-00Gsuw-OZ for linux-arm-kernel@lists.infradead.org; Wed, 28 Sep 2022 15:23:57 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 33BA661E52; Wed, 28 Sep 2022 15:23:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 10DC2C433C1; Wed, 28 Sep 2022 15:23:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664378634; bh=9SIVS1Ktay/VjvIG1Tb63vZHKdfb93SgqGY3i3lFWHI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=seAUZILZ+WhEwxK58YX7ABSmr+ZqeVa/Q2ap9X2g653i2tjww1KSqfPR/bn1JQRF2 BzBinLgdhYVGxfTdsXBc9BiSt+u4w8vsm10ziMZQ5jqNVcy33mctlyPXD3/ZuOqnJV KioubTnY6W/hQ8Iq3iowWuYMI41hf6F39VCm/cByErgfd6iBF4hzf1wAnjfYOTF0Hp kbTDmMcPnG9scsLXNrFz4o204QMW6P1YrO3HhCbx3Q8rr1J74Y5yVR+Jqf8huCEWen YiVD224EYn+z9TfM3Ww00DZrc2dZnhrkMnRMeVMC/wWDazLxkhXJfR/eeYCTXtc559 El5hP+sh11vZw== Date: Wed, 28 Sep 2022 16:23:47 +0100 From: Lee Jones To: Sergiu.Moga@microchip.com Subject: Re: [PATCH v5 1/9] dt-bindings: mfd: atmel,sama5d2-flexcom: Add SPI child node ref binding Message-ID: References: <20220922113347.144383-1-sergiu.moga@microchip.com> <20220922113347.144383-2-sergiu.moga@microchip.com> <7a0c45e2-85fc-b5b0-d1de-a9e06a20bb42@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7a0c45e2-85fc-b5b0-d1de-a9e06a20bb42@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220928_082355_855988_CE4B5D6B X-CRM114-Status: GOOD ( 20.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, alexandre.belloni@bootlin.com, Kavyasree.Kotagiri@microchip.com, richard.genoud@gmail.com, gregkh@linuxfoundation.org, radu_nicolae.pirea@upb.ro, linux-kernel@vger.kernel.org, krzysztof.kozlowski@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-serial@vger.kernel.org, linux-spi@vger.kernel.org, jirislaby@kernel.org, Claudiu.Beznea@microchip.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCAyOCBTZXAgMjAyMiwgU2VyZ2l1Lk1vZ2FAbWljcm9jaGlwLmNvbSB3cm90ZToKCj4g T24gMjguMDkuMjAyMiAxODowMywgTGVlIEpvbmVzIHdyb3RlOgo+ID4gT24gVGh1LCAyMiBTZXAg MjAyMiwgU2VyZ2l1IE1vZ2Egd3JvdGU6Cj4gPiAKPiA+PiBBbm90aGVyIGZ1bmN0aW9uYWxpdHkg b2YgRkxFWENPTSBpcyB0aGF0IG9mIFNQSS4gSW4gb3JkZXIgZm9yCj4gPj4gdGhlIHByb3BlciB2 YWxpZGF0aW9uIG9mIHRoZSBTUEkgY2hpbGRyZW4gbm9kZXMgdGhyb3VnaCB0aGUgYmluZGluZwo+ ID4+IHRvIG9jY3VyLCB0aGUgcHJvcGVyIGJpbmRpbmcgZm9yIFNQSSBtdXN0IGJlIHJlZmVyZW5j ZWQuCj4gPj4KPiA+PiBTaWduZWQtb2ZmLWJ5OiBTZXJnaXUgTW9nYSA8c2VyZ2l1Lm1vZ2FAbWlj cm9jaGlwLmNvbT4KPiA+PiBSZXZpZXdlZC1ieTogS3J6eXN6dG9mIEtvemxvd3NraSA8a3J6eXN6 dG9mLmtvemxvd3NraUBsaW5hcm8ub3JnPgo+ID4+IC0tLQo+ID4+Cj4gPj4KPiA+PiB2MSAtPiB2 MjoKPiA+PiAtIHVzZSBmdWxsIHNjaGVtYSBwYXRocwo+ID4+Cj4gPj4KPiA+PiB2MiAtPiB2MzoK PiA+PiAtIEFkZGVkIFJldmlld2VkLWJ5IHRhZywgcHJldmlvdXNseSB0aGlzIHdhcyBbUEFUQ0gg M10KPiA+Pgo+ID4+Cj4gPj4gdjMgLT4gdjQ6Cj4gPj4gLSBOb3RoaW5nLCBwcmV2aW91c2x5IHRo aXMgd2FzIFtQQVRDSCA1XQo+ID4+Cj4gPj4KPiA+PiB2NCAtPiB2NToKPiA+PiAtIE5vdGhpbmcK PiA+Pgo+ID4+Cj4gPj4KPiA+PiAgIC4uLi9kZXZpY2V0cmVlL2JpbmRpbmdzL21mZC9hdG1lbCxz YW1hNWQyLWZsZXhjb20ueWFtbCAgICAgICB8IDUgKystLS0KPiA+PiAgIDEgZmlsZSBjaGFuZ2Vk LCAyIGluc2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCj4gPiAKPiA+IE5vdCBzdXJlIGhvdyB0 aGVzZSBjYW4gYmUgaGFuZGxlZC4KPiA+IAo+ID4gSSBndWVzcyBJIGNhbm5vdCB0YWtlIHRoZXNl IHVudGlsIHRoZSBvdGhlciBwYXRjaGVzIGFyZSBhcHBsaWVkLgo+ID4gCj4gPiBOQjogVGhlIHBh dGNoIGRvZXNuJ3QgYXBwbHkgY2xlYW5seSBhbnl3YXksIHNvIHdpbGwgbmVlZCB0byBiZSByZWJh c2VkLgo+ID4gCj4gCj4gCj4gSGVsbG8sCj4gCj4gVGhlIHNhbWE1ZDItZmxleGNvbSBiaW5kaW5n IHJlbGF0ZWQgcGF0Y2hlcyBhcmUgZGVwZW5kZW50IG9uOgo+IGh0dHBzOi8vbG9yZS5rZXJuZWwu b3JnL2xpbnV4LWFybS1rZXJuZWwvMjAyMjA5MTYwNzU3NDQuMTg3OTQyOC0xLWthdnlhc3JlZS5r b3RhZ2lyaUBtaWNyb2NoaXAuY29tLwoKSSB3b3VsZCBiZSB2ZXJ5IGNhdXRpb3VzIGFib3V0IHJl bHlpbmcgb24gY29tbWVudHMgbWFkZSBpbiB0aGUKY292ZXItbGV0dGVyLiAgQmV0dGVyIHRvIG1h a2UgdGhpcyBhIGhhcmQgcmVxdWlyZW1lbnQgYW5kIHBsYWNlIHRoZW0KaW4gdGhlIHNhbWUgcGF0 Y2gtc2V0LgoKLS0gCkxlZSBKb25lcyBb5p2O55C85pavXQoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QK bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRl YWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=