From: Sean Christopherson <seanjc@google.com>
To: David Matlack <dmatlack@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Ben Gardon <bgardon@google.com>,
kvm@vger.kernel.org, Andrew Jones <andrew.jones@linux.dev>,
Colton Lewis <coltonlewis@google.com>,
Ricardo Koller <ricarkol@google.com>
Subject: Re: [PATCH 2/2] KVM: selftests: Rename perf_test_util symbols to memstress
Date: Wed, 28 Sep 2022 23:05:28 +0000 [thread overview]
Message-ID: <YzTTOEOkrkSqGcMQ@google.com> (raw)
In-Reply-To: <20220919232300.1562683-3-dmatlack@google.com>
On Mon, Sep 19, 2022, David Matlack wrote:
> @@ -42,10 +42,10 @@ static struct kvm_vcpu *vcpus[KVM_MAX_VCPUS];
> * Continuously write to the first 8 bytes of each page in the
> * specified region.
> */
> -void perf_test_guest_code(uint32_t vcpu_idx)
> +void memstress_guest_code(uint32_t vcpu_idx)
> {
> - struct perf_test_args *pta = &perf_test_args;
> - struct perf_test_vcpu_args *vcpu_args = &pta->vcpu_args[vcpu_idx];
> + struct memstress_args *ma = &memstress_args;
As a prep patch, what about renaming pta=>args? I always struggle to remember
what "pta" means, and "ma" isn't any better. And that would give some amount
of alignment between "args" and "vcpu_args". At a glance, I don't think using a
generic name like that will be problematic.
prev parent reply other threads:[~2022-09-28 23:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 23:22 [PATCH 0/2] KVM: selftests: Rename perf_test_util to memstress David Matlack
2022-09-19 23:22 ` [PATCH 1/2] KVM: selftests: Rename perf_test_util.[ch] to memstress.[ch] David Matlack
2022-09-19 23:23 ` [PATCH 2/2] KVM: selftests: Rename perf_test_util symbols to memstress David Matlack
2022-09-28 23:05 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzTTOEOkrkSqGcMQ@google.com \
--to=seanjc@google.com \
--cc=andrew.jones@linux.dev \
--cc=bgardon@google.com \
--cc=coltonlewis@google.com \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=ricarkol@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.