From: Jason Gunthorpe <jgg@nvidia.com>
To: Niklas Schnelle <schnelle@linux.ibm.com>
Cc: Matthew Rosato <mjrosato@linux.ibm.com>,
Pierre Morel <pmorel@linux.ibm.com>,
iommu@lists.linux.dev, linux-s390@vger.kernel.org,
borntraeger@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
svens@linux.ibm.com, joro@8bytes.org, will@kernel.org,
robin.murphy@arm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/5] iommu/s390: Fix incorrect pgsize_bitmap
Date: Thu, 29 Sep 2022 12:59:02 -0300 [thread overview]
Message-ID: <YzXAxmtajuK5fevj@nvidia.com> (raw)
In-Reply-To: <20220929153302.3195115-6-schnelle@linux.ibm.com>
On Thu, Sep 29, 2022 at 05:33:02PM +0200, Niklas Schnelle wrote:
> The .pgsize_bitmap property of struct iommu_ops is not a page mask but
> rather has a bit set for each size of pages the IOMMU supports. As the
> comment correctly pointed out at this moment the code only support 4K
> pages so simply use SZ_4K here.
>
> Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
> ---
> drivers/iommu/s390-iommu.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
Yep!
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Jason
prev parent reply other threads:[~2022-09-29 15:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 15:32 [PATCH v3 0/5] iommu/s390: Fixes related to attach and aperture handling Niklas Schnelle
2022-09-29 15:32 ` [PATCH v3 1/5] iommu/s390: Fix duplicate domain attachments Niklas Schnelle
2022-09-29 16:10 ` Jason Gunthorpe
2022-09-29 15:32 ` [PATCH v3 2/5] iommu/s390: Get rid of s390_domain_device Niklas Schnelle
2022-09-29 16:20 ` Jason Gunthorpe
2022-09-29 15:33 ` [PATCH v3 3/5] iommu/s390: Fix potential s390_domain aperture shrinking Niklas Schnelle
2022-09-29 16:24 ` Jason Gunthorpe
2022-09-29 15:33 ` [PATCH v3 4/5] iommu/s390: Fix incorrect aperture check Niklas Schnelle
2022-09-29 15:58 ` Jason Gunthorpe
2022-09-30 8:01 ` Niklas Schnelle
2022-09-29 15:33 ` [PATCH v3 5/5] iommu/s390: Fix incorrect pgsize_bitmap Niklas Schnelle
2022-09-29 15:59 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzXAxmtajuK5fevj@nvidia.com \
--to=jgg@nvidia.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=pmorel@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.