From: Vinod Koul <vkoul@kernel.org>
To: Dave Jiang <dave.jiang@intel.com>
Cc: dmaengine@vger.kernel.org
Subject: Re: [PATCH] dmaengine: ioat: stop mod_timer from resurrecting deleted timer in __cleanup()
Date: Thu, 29 Sep 2022 21:53:53 +0530 [thread overview]
Message-ID: <YzXGmeTVQlsDa4cx@matsya> (raw)
In-Reply-To: <166360672197.3851724.17040290563764838369.stgit@djiang5-desk3.ch.intel.com>
On 19-09-22, 09:58, Dave Jiang wrote:
> User reports observing timer event report channel halted but no error
> observed in CHANERR register. The driver finished self-test and released
> channel resources. Debug shows that __cleanup() can call
> mod_timer() after the timer has been deleted and thus resurrect the
> timer. While harmless, it causes suprious error message to be emitted.
> Use mod_timer_pending() call to prevent deleted timer from being
> resurrected.
Applied, thanks
--
~Vinod
prev parent reply other threads:[~2022-09-29 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 16:58 [PATCH] dmaengine: ioat: stop mod_timer from resurrecting deleted timer in __cleanup() Dave Jiang
2022-09-29 16:23 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzXGmeTVQlsDa4cx@matsya \
--to=vkoul@kernel.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.