From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B5480C433FE for ; Thu, 29 Sep 2022 17:21:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mJOK109fehIBMYftkiGtdIeb8CrnQyvX5nmlNSsPdc8=; b=qu4lntRe4KWEWo vT0wTyASmN2JPizZXxvr1vzCxy/0MG8AEAhDh+H1qcq+E65vAZDvYT6n5WuTyh++Osd8eqr5kbhIV DbAD7NbOVhb85mzrWJdmEaLF64NnUPBcSia/BM+/LcWt6HPoi/EM4T+pFzk/MRpSDu/SmAgtFujEA sutEL5su/+TqZ7dOeRTCu4t4s0i4ztqscsJ03tIwCwaSV+HGmbtPUL4eNG6ypb3gDkY0SYd4arBVB Q2UCA+SrOuvzfwhjEAm9hnOrn078qWf2p6nvRSLHqbTRq0JClpPZqJkmn78Mfyb8eoMSuxNePdt4X kKpg57RSXjJK+qEGTrfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1odxCt-004XyL-8R; Thu, 29 Sep 2022 17:20:19 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1odx4T-004T0S-II for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 17:11:39 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EEA3561C15; Thu, 29 Sep 2022 17:11:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3930FC433C1; Thu, 29 Sep 2022 17:11:35 +0000 (UTC) Date: Thu, 29 Sep 2022 18:11:31 +0100 From: Catalin Marinas To: Sergey Shtylyov Cc: Will Deacon , linux-arm-kernel@lists.infradead.org, Oleg Nesterov , lvc-project@linuxtesting.org Subject: Re: [PATCH] arm64: ptrace: user_regset_copyin_ignore() always returns 0 Message-ID: References: <4c678cd1-7e75-5c73-0de8-2ffaa3a96e0e@omp.ru> <20220922115902.GB11505@willie-the-truck> <21919615-c075-006b-1730-50043f344f83@omp.ru> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_101137_667140_39A79EAB X-CRM114-Status: GOOD ( 24.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 27, 2022 at 09:46:11PM +0300, Sergey Shtylyov wrote: > On 9/26/22 5:01 PM, Catalin Marinas wrote: > >>>> user_regset_copyin_ignore() always return 0, so checking its result seems > >>>> pointless -- don't do this... [...] > >>> I think it would be better to have user_regset_copyin_ignore() return void > >>> so that we don't run the risk of missing an error code if it starts > >>> returning one in future. > >> > >> That's the plan! But I need to convert the users 1st, right? > > > > Right, though normally we'd like to see the full series that does the > > arch clean-up followed by the user_regset_copyin_ignore() return changed > > to void. If for some reason the last patch is rejected by the maintainer > > because there are plans to actually return some non-zero value, we'd > > have to revert the above. > > Hm... I usually try to avoid a cross-tree patch series but here I should > be able to use the linux-next repo as I series' base. Is that OK? It depends on how you plan to merge it, though basing the series off linux-next is not ideal. It's fine to merge individual patches in one release though specific trees and the final patch in another but when you posted this single patch we didn't have the context. So ideally I'd like to see an ack on the patch converting user_regset_copyin_ignore() to void. It wasn't obvious there's such patch. You can also have a cross-tree series and convince one of the maintainer to pick it up (usually cc'ing akpm does the trick ;)). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel