From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Simon Ser <contact@emersion.fr>
Cc: andrealmeid@igalia.com, daniel.vetter@ffwll.ch,
amd-gfx@lists.freedesktop.org,
wayland-devel@lists.freedesktop.org, mwen@igalia.com,
dri-devel@lists.freedesktop.org, alexander.deucher@amd.com,
hwentlan@amd.com, nicholas.kazlauskas@amd.com, joshua@froggi.es
Subject: Re: [PATCH v3 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported
Date: Fri, 30 Sep 2022 17:02:09 +0300 [thread overview]
Message-ID: <Yzb24RJOn/OkTsKx@intel.com> (raw)
In-Reply-To: <TIyTbXwbugAMrWLflS6c6MSMb8Nfv0n3kzxZS8XYDPW2KhtzVxazMJUQPRdq0c7BUNLAaT125oFiZYCTIT-tF5QVCnKxffLfGYOMBCBpQWQ=@emersion.fr>
On Fri, Sep 30, 2022 at 01:56:25PM +0000, Simon Ser wrote:
> On Friday, September 30th, 2022 at 15:53, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>
> > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > > index 44235345fd57..7500e82cf06a 100644
> > > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > > @@ -3808,6 +3808,7 @@ static int amdgpu_dm_mode_config_init(struct amdgpu_device *adev)
> > > adev_to_drm(adev)->mode_config.prefer_shadow = 1;
> > > /* indicates support for immediate flip */
> > > adev_to_drm(adev)->mode_config.async_page_flip = true;
> > > + adev_to_drm(adev)->mode_config.atomic_async_page_flip_not_supported = true;
> >
> > The flag polarity seems weird. Why opt out and not opt in?
>
> Explained in the commit message.
Seems a bit ambitious, but sure.
--
Ville Syrjälä
Intel
next prev parent reply other threads:[~2022-09-30 14:02 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 18:43 [PATCH v3 0/6] Add support for atomic async page-flips Simon Ser
2022-09-29 18:43 ` Simon Ser
2022-09-29 18:43 ` [PATCH v3 1/6] drm: document DRM_MODE_PAGE_FLIP_ASYNC Simon Ser
2022-09-29 18:43 ` Simon Ser
2022-09-29 18:43 ` [PATCH v3 2/6] amd/display: only accept async flips for fast updates Simon Ser
2022-09-29 18:43 ` Simon Ser
2022-09-29 18:43 ` [PATCH v3 3/6] drm: introduce drm_mode_config.atomic_async_page_flip_not_supported Simon Ser
2022-09-29 18:43 ` Simon Ser
2022-09-30 13:53 ` Ville Syrjälä
2022-09-30 13:56 ` Simon Ser
2022-09-30 14:02 ` Ville Syrjälä [this message]
2022-09-29 18:43 ` [PATCH v3 4/6] drm: allow DRM_MODE_PAGE_FLIP_ASYNC for atomic commits Simon Ser
2022-09-29 18:43 ` Simon Ser
2022-09-29 18:43 ` [PATCH v3 5/6] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP Simon Ser
2022-09-29 18:43 ` Simon Ser
2022-09-29 18:44 ` [PATCH v3 6/6] amd/display: indicate support for atomic async page-flips on DC Simon Ser
2022-09-29 18:44 ` Simon Ser
2022-09-30 13:42 ` [PATCH v3 0/6] Add support for atomic async page-flips Harry Wentland
2022-09-30 13:42 ` Harry Wentland
2022-09-30 13:52 ` Ville Syrjälä
2022-09-30 14:19 ` Ville Syrjälä
2022-09-30 15:09 ` Ville Syrjälä
2022-09-30 15:37 ` KMS atomic state sets, full vs. minimal (Re: [PATCH v3 0/6] Add support for atomic async page-flips) Pekka Paalanen
2022-09-30 15:37 ` Pekka Paalanen
2022-09-30 15:45 ` Ville Syrjälä
2022-09-30 15:45 ` Ville Syrjälä
2022-09-30 15:58 ` Ville Syrjälä
2022-10-03 8:48 ` Pekka Paalanen
2022-10-03 8:48 ` Pekka Paalanen
2022-10-03 9:04 ` Ville Syrjälä
2022-10-03 9:04 ` Ville Syrjälä
2022-10-13 16:02 ` [PATCH v3 0/6] Add support for atomic async page-flips Simon Ser
2022-10-17 14:35 ` André Almeida
2022-10-17 14:35 ` André Almeida
2022-10-28 12:36 ` André Almeida
2022-10-28 12:36 ` André Almeida
2022-11-17 8:58 ` Simon Ser
2023-01-05 16:01 ` Simon Ser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yzb24RJOn/OkTsKx@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andrealmeid@igalia.com \
--cc=contact@emersion.fr \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hwentlan@amd.com \
--cc=joshua@froggi.es \
--cc=mwen@igalia.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=wayland-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.