Re: [xen-unstable-smoke test] 173362: regressions - FAIL

[Anthony PERARD <anthony.perard@citrix.com>]

On Fri, Sep 30, 2022 at 08:31:20AM +0200, Jan Beulich wrote:
> On 29.09.2022 18:25, Andrew Cooper wrote:
> > On 29/09/2022 17:22, osstest service owner wrote:
> >> flight 173362 xen-unstable-smoke real [real]
> >> http://logs.test-lab.xenproject.org/osstest/logs/173362/
> >>
> >> Regressions :-(
> >>
> >> Tests which did not succeed and are blocking,
> >> including tests which could not be run:
> >>  build-arm64-xsm               6 xen-build                fail REGR. vs. 173347
> > 
> > arch/arm/gic-v3-its.c: In function 'gicv3_its_deny_access':
> > arch/arm/gic-v3-its.c:905:32: error: passing argument 1 of
> > 'iomem_deny_access' discards 'const' qualifier from pointer target type
> > [-Werror=discarded-qualifiers]
> >          rc = iomem_deny_access(d, mfn, mfn + nr);
> >                                 ^
> > In file included from arch/arm/gic-v3-its.c:24:
> > ./include/xen/iocap.h:32:52: note: expected 'struct domain *' but
> > argument is of type 'const struct domain *'
> >  static inline int iomem_deny_access(struct domain *d, unsigned long s,
> >                                      ~~~~~~~~~~~~~~~^
> > cc1: all warnings being treated as errors
> 
> I've sent a patch, but this raises another question: Why does the smoke
> test (try to) build an unsupported configuration? HAS_ITS (which is
> necessary to be set for the issue to surface) has its prompt depend on
> UNSUPPORTED, and (implicitly) defaults to N.

According to osstest sources:
    # ITS driver is required to boot the Hardware Domain
    # on Xen. For now (Xen 4.10/4.11 at at least),
    # will be not built by default and gated by expert mode
    echo >>xen/.config CONFIG_HAS_ITS=y

https://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=ts-xen-build;h=c294a51eafc26e53b5417529b943224902870acf;hb=HEAD#l131

> 
> Jan
> 

-- 
Anthony PERARD