From: Borislav Petkov <bp@alien8.de>
To: Juergen Gross <jgross@suse.com>
Cc: xen-devel@lists.xenproject.org, x86@kernel.org,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init
Date: Fri, 30 Sep 2022 13:55:16 +0200 [thread overview]
Message-ID: <YzbZJEeVHkTnWIfc@zn.tnic> (raw)
In-Reply-To: <b707e459-4e21-80f5-c676-c275528c06ae@suse.com>
On Thu, Sep 29, 2022 at 10:26:59AM +0200, Juergen Gross wrote:
> So right now I'm inclined to be better on the safe side by not adding any
> cpu hotplug hook, but to use just the same "delayed AP init" flag as today,
> just renaming it. This would leave the delayed MTRR/PAT init in place for
> resume and kexec cases, but deferring the MTRR/PAT cleanup due to this
> potential issue seems not appropriate, as the cleanup isn't changing the
> behavior here.
Ok, what's wrong with adding a special hotplug level just for that thing
and running it very early? Practically pretty much where it was in time,
in identify_secondary_cpu()?
Having a special one is warranted, as you explain, I'd say.
Thx.
--
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquette
next prev parent reply other threads:[~2022-09-30 11:55 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-08 8:49 [PATCH v3 00/10] x86: make pat and mtrr independent from each other Juergen Gross
2022-09-08 8:49 ` [PATCH v3 01/10] x86/mtrr: add comment for set_mtrr_state() serialization Juergen Gross
2022-09-08 8:49 ` [PATCH v3 02/10] x86/mtrr: remove unused cyrix_set_all() function Juergen Gross
2022-09-08 8:49 ` [PATCH v3 03/10] x86/mtrr: replace use_intel() with a local flag Juergen Gross
2022-09-11 10:16 ` Borislav Petkov
2022-09-12 9:10 ` Juergen Gross
2022-09-19 19:10 ` Borislav Petkov
2022-09-28 10:17 ` Juergen Gross
2022-09-08 8:49 ` [PATCH v3 04/10] x86: move some code out of arch/x86/kernel/cpu/mtrr Juergen Gross
2022-09-11 11:02 ` Borislav Petkov
2022-09-12 9:11 ` Juergen Gross
2022-09-08 8:49 ` [PATCH v3 05/10] x86/mtrr: split generic_set_all() Juergen Gross
2022-09-19 19:25 ` Borislav Petkov
2022-09-08 8:49 ` [PATCH v3 06/10] x86/mtrr: remove set_all callback from struct mtrr_ops Juergen Gross
2022-09-08 8:49 ` [PATCH v3 07/10] x86/mtrr: simplify mtrr_bp_init() Juergen Gross
2022-09-26 18:40 ` Borislav Petkov
2022-09-08 8:49 ` [PATCH v3 08/10] x86/mtrr: let cache_aps_delayed_init replace mtrr_aps_delayed_init Juergen Gross
2022-09-26 21:11 ` Borislav Petkov
2022-09-27 8:57 ` Juergen Gross
2022-09-27 10:10 ` Borislav Petkov
2022-09-27 10:14 ` Juergen Gross
2022-09-27 11:19 ` Borislav Petkov
2022-09-27 11:25 ` Juergen Gross
2022-09-27 12:13 ` Borislav Petkov
2022-09-27 12:21 ` Juergen Gross
2022-09-27 23:16 ` Borislav Petkov
2022-09-28 5:30 ` Juergen Gross
2022-09-28 6:16 ` Juergen Gross
2022-09-28 10:48 ` Borislav Petkov
2022-09-28 11:14 ` Juergen Gross
2022-09-28 11:22 ` Borislav Petkov
2022-09-28 13:43 ` Juergen Gross
2022-09-28 16:12 ` Borislav Petkov
2022-09-28 16:32 ` Juergen Gross
2022-09-28 16:39 ` Borislav Petkov
2022-09-29 8:26 ` Juergen Gross
2022-09-30 11:55 ` Borislav Petkov [this message]
2022-09-30 13:11 ` Juergen Gross
2022-09-30 13:25 ` Borislav Petkov
2022-09-08 8:49 ` [PATCH v3 09/10] x86/mtrr: add a stop_machine() handler calling only cache_cpu_init() Juergen Gross
2022-09-08 8:49 ` [PATCH v3 10/10] x86: decouple pat and mtrr handling Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzbZJEeVHkTnWIfc@zn.tnic \
--to=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.