From: Petr Vorel <pvorel@suse.cz>
To: Cyril Hrubis <chrubis@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] tst_test.sh: Fix missing cleanup run from setup
Date: Fri, 30 Sep 2022 14:05:21 +0200 [thread overview]
Message-ID: <YzbbgS6O0vBPUXbp@pevik> (raw)
In-Reply-To: <YzbV5JFPNNoVmqth@yuki>
Hi,
> Hi!
> Looks like an obvious regression that should be fixed.
+1
> But we should at least re-run all shell tests to make sure that this
> does not break anything. I would vote for this to go in before the
> release but after you did enough testing.
I'm testing with these 2 patches (this and zram01.sh) in my fork:
https://github.com/pevik/ltp/commits/ltp-202209.2022-09-30.pre-release
I rerun whole LTP tests on 3 SLES versions, most of the shell tests on
Tumbleweed, I'll also try some shell tests on some Debian version.
Also CI passed (which runs make test-shell), + I run make test-shell manually
(covers more than CI), but that's not that relevant as we don't cover much.
> And also it would be better if anyone else had a look.
That'd be great, but not sure if anybody jumps in.
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2022-09-30 12:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-30 11:24 [LTP] [PATCH 1/1] tst_test.sh: Fix missing cleanup run from setup Petr Vorel
2022-09-30 11:30 ` Petr Vorel
2022-09-30 11:41 ` Cyril Hrubis
2022-09-30 12:05 ` Petr Vorel [this message]
2022-09-30 14:27 ` Petr Vorel
2022-09-30 14:38 ` Cyril Hrubis
2022-09-30 14:51 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzbbgS6O0vBPUXbp@pevik \
--to=pvorel@suse.cz \
--cc=chrubis@suse.cz \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.