From: Jarkko Sakkinen <jarkko@kernel.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] tpm: st33zp24: switch to using gpiod API
Date: Fri, 30 Sep 2022 23:43:22 +0300 [thread overview]
Message-ID: <YzdU6tpZaqSvVm5/@kernel.org> (raw)
In-Reply-To: <20220926053958.1541912-2-dmitry.torokhov@gmail.com>
On Sun, Sep 25, 2022 at 10:39:57PM -0700, Dmitry Torokhov wrote:
> This patch switches the driver from legacy gpio API to the newer gpiod
> API, so that eventually we can drop the former.
Once a patch is applied, it's a commit, not a patch. Just start by
"Switch ...".
Please also define what is the legacy API exactly, and what sort of
API it is switched to with a bit more detail. I don't follow GPIO.
> During conversion it was noted that the gpio handling code for SPI and
> I2C variants duplicates each other, so it was moved into the core.
Who noted what? Please provide a reference. I do not connect this
sentence to anything, as I do not follow gpio's mailing list.
> Also, it seems that the driver never assigned tpm_dev->io_lpcpd in the
> past, so gpio-based power management was most likely not working ever.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
BR, Jarkko
next prev parent reply other threads:[~2022-09-30 20:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 5:39 [PATCH 1/3] tpm: st33zp24: drop support for platform data Dmitry Torokhov
2022-09-26 5:39 ` [PATCH 2/3] tpm: st33zp24: switch to using gpiod API Dmitry Torokhov
2022-09-30 20:43 ` Jarkko Sakkinen [this message]
2022-09-26 5:39 ` [PATCH 3/3] tpm: st33zp24: remove pointless checks on probe Dmitry Torokhov
2022-09-30 20:44 ` Jarkko Sakkinen
2022-10-01 4:13 ` Dmitry Torokhov
2022-09-30 20:39 ` [PATCH 1/3] tpm: st33zp24: drop support for platform data Jarkko Sakkinen
2022-10-01 4:11 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YzdU6tpZaqSvVm5/@kernel.org \
--to=jarkko@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.