From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 517CDC433FE for ; Fri, 30 Sep 2022 22:34:14 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1oeOaB-0006iv-Cn; Fri, 30 Sep 2022 22:34:11 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1oeOa9-0006in-8o for linux-f2fs-devel@lists.sourceforge.net; Fri, 30 Sep 2022 22:34:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=itrbu3AvfQFjIa4my+KZX0rAgfzAL+R7UDY98bHgcE4=; b=MrE3cjb2HEtkDpVoupSU2d1jVv lcjbmL0NAI08oNonKnYGEQhKcvn7/73YG4nhcQUO3g9/KZsmqQ8J0STgZbU7JGWPjWv+iow8bvBBy Hw5fkgcFtg2dxps6dkxCqfD8/LW/ZSPGRJK968r1/NHhTsuBojuuaj2ULj/b+Q0aJZlQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=itrbu3AvfQFjIa4my+KZX0rAgfzAL+R7UDY98bHgcE4=; b=CKpxpC1fPlzfr24xUF3GF3e7LI V+EcoLJaC9zTdzUiTn5G/N0Mwzf+G6hNyDBMi0fKhGxDn4pvkRyJPcUrXb8AYagKIeLr8QVxTGU9L F92N2w35BZmXoAy3zuxDuBrLKLizZPePRPtZKlpZdoMlmWuoQ1FG4PR6gaZXgBHVk7XM=; Received: from ams.source.kernel.org ([145.40.68.75]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1oeOa2-008Kzr-Uw for linux-f2fs-devel@lists.sourceforge.net; Fri, 30 Sep 2022 22:34:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A4E68B82A74 for ; Fri, 30 Sep 2022 22:33:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4283FC433C1; Fri, 30 Sep 2022 22:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1664577230; bh=QdBhOcrx32CkEXBIHARgnrZoGVaa/l69pYtMxOFcu1A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fDIaq0Vn3qRpLNgcySmoF2loz6k26YaCkMtyx5c/aRsXTjfGQED5kbDUlQYX0eWOY Md0hAwpcRfr61Hh9/HkjkUzymqxg4Lm0fsPo3UlDYihrGNZu+FMZCH0tabc8Tm/WGW MlIwEbQox2Y9tZ+FTNd+S71JUEL4yYh6WcNnE0CopzKqOfbpY1l21rxJ+IfwBNz9Y3 MwBJLg1jKUFFhM9ori/nb5qRA32zlPUp2ehLiPRN2Vn/N0tIfcm4LaC1Fs3gUQg/Iq CS3IvI2QVuzWg8+OyochvQy+BS4Jai87h9H2O1EGXng0++7Pif08xdLARnM0PMdnDm nC6f/0dvnDXNQ== Date: Fri, 30 Sep 2022 15:33:48 -0700 From: Jaegeuk Kim To: Chao Yu Message-ID: References: <20220925055802.11955-1-chao@kernel.org> <7387ba71-46bd-aed9-d435-f234f486a7a0@kernel.org> <45e56fa9-de7a-7858-f032-4433adb2b021@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <45e56fa9-de7a-7858-f032-4433adb2b021@kernel.org> X-Headers-End: 1oeOa2-008Kzr-Uw Subject: Re: [f2fs-dev] [PATCH] mkfs.f2fs: update allocation policy for ro feature X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 09/30, Chao Yu wrote: > On 2022/9/30 2:27, Jaegeuk Kim wrote: > > On 09/28, Chao Yu wrote: > > > On 2022/9/28 11:15, Jaegeuk Kim wrote: > > > > On 09/28, Chao Yu wrote: > > > > > On 2022/9/28 0:40, Jaegeuk Kim wrote: > > > > > > On 09/25, Chao Yu wrote: > > > > > > > Update allocation policy for ro feature: > > > > > > > - hot_data: allocating blocks by LBA ascending order > > > > > > > - hot_node: allocating blocks by LBA descending order > > > > > > > > > > > > This will increase the RO image size. > > > > > > > > > > Shouldn't RO image has fixed-size during mkfs? > > > > > > > > First run gives the reduced size information, and second round makes the image > > > > with the required size. > > > > > > I didn't get it, in which step it may increase the RO image size? > > > > > > IIUC, after we apply this patch, reduced size information won't change due > > > to that after sload in first run, total used block count should be fixed? > > > > First run fills the data and leaves the maximum LBA touched in the image. Then, > > How about caclulating required size w/ total used blocks rather than maximum LBA? Do you think that can give the smallest size for the image? > > Thanks, > > > it'll resize the image file and run again with the smallest image. > > > > > > > > Thanks, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Signed-off-by: Chao Yu > > > > > > > --- > > > > > > > mkfs/f2fs_format.c | 4 ++-- > > > > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > > > > > > > diff --git a/mkfs/f2fs_format.c b/mkfs/f2fs_format.c > > > > > > > index 40ac589..8d0f410 100644 > > > > > > > --- a/mkfs/f2fs_format.c > > > > > > > +++ b/mkfs/f2fs_format.c > > > > > > > @@ -544,10 +544,10 @@ static int f2fs_prepare_super_block(void) > > > > > > > } > > > > > > > if (c.feature & cpu_to_le32(F2FS_FEATURE_RO)) { > > > > > > > - c.cur_seg[CURSEG_HOT_NODE] = 0; > > > > > > > + c.cur_seg[CURSEG_HOT_NODE] = last_section(last_zone(total_zones)); > > > > > > > c.cur_seg[CURSEG_WARM_NODE] = 0; > > > > > > > c.cur_seg[CURSEG_COLD_NODE] = 0; > > > > > > > - c.cur_seg[CURSEG_HOT_DATA] = 1; > > > > > > > + c.cur_seg[CURSEG_HOT_DATA] = 0; > > > > > > > c.cur_seg[CURSEG_COLD_DATA] = 0; > > > > > > > c.cur_seg[CURSEG_WARM_DATA] = 0; > > > > > > > } else if (c.heap) { > > > > > > > -- > > > > > > > 2.36.1 _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel