From: Sean Christopherson <seanjc@google.com>
To: David Matlack <dmatlack@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Colton Lewis <coltonlewis@google.com>,
Peter Xu <peterx@redhat.com>, Jim Mattson <jmattson@google.com>,
Aaron Lewis <aaronlewis@google.com>,
kvm@vger.kernel.org
Subject: Re: [PATCH 0/4] KVM: selftests: Fix and clean up emulator_error_test
Date: Mon, 3 Oct 2022 23:31:50 +0000 [thread overview]
Message-ID: <Yztw5p+Y5oyJElH2@google.com> (raw)
In-Reply-To: <20220929204708.2548375-1-dmatlack@google.com>
On Thu, Sep 29, 2022, David Matlack wrote:
> Miscellaneous fixes and cleanups to emulator_error_test. The reason I
> started looking at this test is because it fails when TDP is disabled,
> which pollutes my test results when I am testing a new series for
> upstream.
This series defeats the (not well documented) purpose of emulator_error_test. The
test exists specifically to verify that KVM emulates in response to EPT violations
when "allow_smaller_maxphyaddr && guest.MAXPHYADDR < host.MAXPHADDR".
That said, the test could use some upgrades:
1. Verify that a well-emulated instruction takes #PF(RSVD)
2. Verify that FLDS takes #PF(RSVD) when EPT is disabled
next prev parent reply other threads:[~2022-10-03 23:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-29 20:47 [PATCH 0/4] KVM: selftests: Fix and clean up emulator_error_test David Matlack
2022-09-29 20:47 ` [PATCH 1/4] KVM: selftests: Use MMIO to trigger emulation in emulator_error_test David Matlack
2022-09-29 20:47 ` [PATCH 2/4] KVM: selftests: Delete dead ucall code from emulator_error_test David Matlack
2022-09-29 20:47 ` [PATCH 3/4] KVM: selftests: Skip emulator_error_test if KVM_CAP_EXIT_ON_EMULATION_FAILURE not available David Matlack
2022-09-29 20:47 ` [PATCH 4/4] KVM: selftests: Explicitly require instructions bytes in emulator_error_test David Matlack
2022-10-03 23:31 ` Sean Christopherson [this message]
2022-10-04 16:33 ` [PATCH 0/4] KVM: selftests: Fix and clean up emulator_error_test David Matlack
2022-10-04 20:30 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Yztw5p+Y5oyJElH2@google.com \
--to=seanjc@google.com \
--cc=aaronlewis@google.com \
--cc=coltonlewis@google.com \
--cc=dmatlack@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.