All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Xiaoke Wang <xkernel.wang@foxmail.com>
Cc: "Larry.Finger" <Larry.Finger@lwfinger.net>,
	"florian.c.schilhabel" <florian.c.schilhabel@googlemail.com>,
	gregkh <gregkh@linuxfoundation.org>,
	linux-staging <linux-staging@lists.linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] staging: rtl8712: fix potential memory leak in _r8712_init_xmit_priv()
Date: Tue, 4 Oct 2022 16:37:31 +0300	[thread overview]
Message-ID: <Yzw3G8rPsW1TMhPW@kadam> (raw)
In-Reply-To: <tencent_FACCCAB91E1C6F141FE1CA4AC1FF2420DA08@qq.com>

On Tue, Sep 27, 2022 at 08:55:08PM +0800, Xiaoke Wang wrote:
> 
> Yes, the memory address is still on the list, and at the above position of
> `Note`, the address of `pxmitpriv-&gt;pallocated_frame_buf` is also left on a
> list named `pxmitpriv-&gt;free_xmit_queue`.
> However, these lists are in `pxmitpriv` and this function is for
> initializing `pxmitpriv`. When this function fails, the probe function of
> this driver will finally fail. So I guess the list in `pxmitpriv` will not
> be accessed.

Sorry for the delayed response.  I think you are right.  This patch is
fine then.

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter


  reply	other threads:[~2022-10-04 13:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-27 12:55 [PATCH v3] staging: rtl8712: fix potential memory leak in _r8712_init_xmit_priv() Xiaoke Wang
2022-10-04 13:37 ` Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-09-26  7:06 xkernel.wang
2022-09-27  7:57 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yzw3G8rPsW1TMhPW@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=florian.c.schilhabel@googlemail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=xkernel.wang@foxmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.