From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 96649C433FE for ; Tue, 4 Oct 2022 12:56:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aSanm3K3xBXQ8pc1ZCXDSK91onoNxvZCOSVCuWzJzxk=; b=a64Jue8kcq3mlX W6gaxg969c2t0l2c0ERvnmZhrjaPKCozWXVd/T+MV/nMql6p39uJqqy2fZ7JLRd4kfaQ1SuD8SGHR RgGmAGwYfK5vAl8kAEWPmSv9L94N62O5YjC587P9NM7r6FK8UDYknYlsGwZ4I0TwnmOb/05YyYCJO XVA97drF8BCIkcDcIwCF/cO3QxLxc4F55vseDKb4KCtv4skHIdolkr8ZzhIC0hACOm06twH6/77KH uLnnry71FicOdtQwf4cbMn4Q7YOWS8/hVW3AR6CPL8HwPx+9WKXFRahKuTnEQsKH0vfOSvKGjwudX jVNs6n6zu1/+TWlYV9HA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofhRu-009gDC-7w; Tue, 04 Oct 2022 12:55:02 +0000 Received: from mail-wr1-x429.google.com ([2a00:1450:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofhRq-009gBh-JI for linux-arm-kernel@lists.infradead.org; Tue, 04 Oct 2022 12:55:00 +0000 Received: by mail-wr1-x429.google.com with SMTP id b4so14223077wrs.1 for ; Tue, 04 Oct 2022 05:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PkPNtuib5iRHSYoXuvCITszxB1jeo5nPeYiHHZL01UU=; b=aKbbnZoDBY06Fjy3RSKQhfzAXP/Fpd7Z0NocPlMkBTEjqE9KysXAj0smHAg6k5bZ52 G3kcQkx0Y+fM9LPYRSAHWxnErO5LuGtgSVK5VU7qtIpqFjFr8isprkSzhfCKvlZNg5Uc bblamli2YxIlhbGYCKmlXDAzxtU1rW+o67ONYWDWlTadw7ufy/9sA5vbxKE5/l3KtwTE z2gYoyV1NmPHkKI13GaBFPLMSiD5exh43C6GJXFeIVNiDI/a1bE/3dHN4HF/N3uh3LPY CplV3F1T6nmpxOHlfxlj29KE5vlrZJQcjHRWqW7O8bdocUUXeHQeZbuxNPrGVVl6tSYg r5TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PkPNtuib5iRHSYoXuvCITszxB1jeo5nPeYiHHZL01UU=; b=2B7UrXSrpewyh6hBjIlrZ1sG7zY8KE43iOWmgfjFw30WLX6CSwjCh/6rF1ehHhUun3 prOngvHgYvLTQvwaJOEBY1AoGuuifnm1hEdivojDQHv/FpiUWJjIWNdI/3vjUqJ4gaTs mBb4x40iLbLOzq2qW88AZdN3EGx/ltSHv3XSDN1rm3kNDp/YQNWYPLEaHiJ231HennMq ONPMjCz+FGAwJYNgUM20iGeu+/P+NzNNFJRyNdtbG6vv3cmM8Vuc4U5dw/KavuSKD+9r wwhrusWUxjZ+qmc0jjzofLtnbDADJi/x8RxXVd8R+jL+MMvm2JzmqTX6CR4wqG97CwiA HRkA== X-Gm-Message-State: ACrzQf0OoqKGDBi9xGyK5UdiCwByO3kuvUHo/oZ0KLlD4fB9DxmZGyPN 3rcxVuftUwR+5hHn5qz97LKLvA== X-Google-Smtp-Source: AMsMyM6zkuocVUmsW5crCUEXtpbvBS7DDgsVlES5Am7dCaMtOQ/Tak12eHP2HL2OCi1vm5tQZq3p3Q== X-Received: by 2002:a5d:588f:0:b0:22b:5cc:e1d3 with SMTP id n15-20020a5d588f000000b0022b05cce1d3mr15148579wrf.142.1664888095272; Tue, 04 Oct 2022 05:54:55 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id w10-20020a05600c474a00b003b4ac05a8a4sm25305803wmo.27.2022.10.04.05.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 05:54:54 -0700 (PDT) Date: Tue, 4 Oct 2022 13:54:51 +0100 From: Daniel Thompson To: Linus Walleij Cc: Dmitry Torokhov , Sascha Hauer , Krzysztof Kozlowski , Rob Herring , Lee Jones , Jingoo Han , Shawn Guo , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_055458_665110_ED3ED7EA X-CRM114-Status: GOOD ( 24.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 04, 2022 at 11:02:06AM +0200, Linus Walleij wrote: > On Wed, Sep 28, 2022 at 12:32 AM Dmitry Torokhov > wrote: > > > Properties describing GPIOs should be named as "-gpios" or > > "-gpio", and that is what gpiod API expects, however the > > driver uses non-standard "gpios-reset" name. Let's adjust this, and also > > note that the reset line is active low as that is also important to > > gpiod API. > > > > Signed-off-by: Dmitry Torokhov > > I think the gods of Open Firmware will try to punish you for such > incompatible changes. But I have long since renounced them. > > > Another option is to add another quirk into gpiolib-of.c, but we > > may end up with a ton of them once we convert everything away from > > of_get_named_gpio() to gpiod API, so I'd prefer not doing that. > > We need to know if i.MX is shipping device trees stored in flash, > or if they bundle it with the kernel. This part is frequently found in add-on boards so it's not purely an i.MX-only question. > In the former case, you have to add quirks, in the latter case this > patch is fine. > > Sascha, what does the Freescale maintainer say? IMHO for not-in-the-soc devices like this the presence of in-kernel DTs isn't enough to make a decision. What is needed is a degree of due-diligence to show that there are no obvious out-of-kernel users. To be honest, I suspect the due-diligence checks will probably yield a green light for this one. Most of the tutorials for the popular HX8357 devices, show how to run python code in userspace that sends raw SPI commands. That sucks but at least it doesn't raise any concerns about bindings maintenance. Daniel. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1CBC7C433F5 for ; Tue, 4 Oct 2022 12:55:05 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7444110E630; Tue, 4 Oct 2022 12:55:03 +0000 (UTC) Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1EF610E5E1 for ; Tue, 4 Oct 2022 12:54:56 +0000 (UTC) Received: by mail-wr1-x42f.google.com with SMTP id b4so14223078wrs.1 for ; Tue, 04 Oct 2022 05:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PkPNtuib5iRHSYoXuvCITszxB1jeo5nPeYiHHZL01UU=; b=aKbbnZoDBY06Fjy3RSKQhfzAXP/Fpd7Z0NocPlMkBTEjqE9KysXAj0smHAg6k5bZ52 G3kcQkx0Y+fM9LPYRSAHWxnErO5LuGtgSVK5VU7qtIpqFjFr8isprkSzhfCKvlZNg5Uc bblamli2YxIlhbGYCKmlXDAzxtU1rW+o67ONYWDWlTadw7ufy/9sA5vbxKE5/l3KtwTE z2gYoyV1NmPHkKI13GaBFPLMSiD5exh43C6GJXFeIVNiDI/a1bE/3dHN4HF/N3uh3LPY CplV3F1T6nmpxOHlfxlj29KE5vlrZJQcjHRWqW7O8bdocUUXeHQeZbuxNPrGVVl6tSYg r5TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PkPNtuib5iRHSYoXuvCITszxB1jeo5nPeYiHHZL01UU=; b=aSCWZ7PY0Cx4Y4xnjeVGbJnIBMCTvstR9J5K+bG32GQJhUwfgvCzLPMXZZ5BCTomKj TE9pu5pro/ILINkM9HoyJpvzLg8UAity9LIMzqEpQnweUF8aXmKye8Bq4jkHyNEQKkU7 5I5osLXQz2sWYk+pD4+Xk4M9kGl1bbybqjoIvJj9LfmqgXzrUUyWBmERoDiJCcUb2s3q +ZxKylAVw0L0nZASTs+2zjGjEWMN+ZCZGyzyU7+srgmOnnV5ab3mnHGfQERIulMlhMhM LvJYNeYZ3gkHfw8MUe4TsGDOgeQLnGnQ2YB7ddt0LJjmM83FSYLojFLpnpj0rzkZWbei mywg== X-Gm-Message-State: ACrzQf1EgJ2mTvGfRH3ZvoVh2fJWIRgHHlg+Wms9aBLKTCSZycLwVdag VEle+Oy1miYh9XG/zTwFOVSqFg== X-Google-Smtp-Source: AMsMyM6zkuocVUmsW5crCUEXtpbvBS7DDgsVlES5Am7dCaMtOQ/Tak12eHP2HL2OCi1vm5tQZq3p3Q== X-Received: by 2002:a5d:588f:0:b0:22b:5cc:e1d3 with SMTP id n15-20020a5d588f000000b0022b05cce1d3mr15148579wrf.142.1664888095272; Tue, 04 Oct 2022 05:54:55 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id w10-20020a05600c474a00b003b4ac05a8a4sm25305803wmo.27.2022.10.04.05.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 05:54:54 -0700 (PDT) Date: Tue, 4 Oct 2022 13:54:51 +0100 From: Daniel Thompson To: Linus Walleij Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lee Jones , Jingoo Han , Sascha Hauer , Dmitry Torokhov , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , NXP Linux Team , Krzysztof Kozlowski , Shawn Guo , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Oct 04, 2022 at 11:02:06AM +0200, Linus Walleij wrote: > On Wed, Sep 28, 2022 at 12:32 AM Dmitry Torokhov > wrote: > > > Properties describing GPIOs should be named as "-gpios" or > > "-gpio", and that is what gpiod API expects, however the > > driver uses non-standard "gpios-reset" name. Let's adjust this, and also > > note that the reset line is active low as that is also important to > > gpiod API. > > > > Signed-off-by: Dmitry Torokhov > > I think the gods of Open Firmware will try to punish you for such > incompatible changes. But I have long since renounced them. > > > Another option is to add another quirk into gpiolib-of.c, but we > > may end up with a ton of them once we convert everything away from > > of_get_named_gpio() to gpiod API, so I'd prefer not doing that. > > We need to know if i.MX is shipping device trees stored in flash, > or if they bundle it with the kernel. This part is frequently found in add-on boards so it's not purely an i.MX-only question. > In the former case, you have to add quirks, in the latter case this > patch is fine. > > Sascha, what does the Freescale maintainer say? IMHO for not-in-the-soc devices like this the presence of in-kernel DTs isn't enough to make a decision. What is needed is a degree of due-diligence to show that there are no obvious out-of-kernel users. To be honest, I suspect the due-diligence checks will probably yield a green light for this one. Most of the tutorials for the popular HX8357 devices, show how to run python code in userspace that sends raw SPI commands. That sucks but at least it doesn't raise any concerns about bindings maintenance. Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C00D0C433FE for ; Tue, 4 Oct 2022 12:59:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230005AbiJDM7E (ORCPT ); Tue, 4 Oct 2022 08:59:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229543AbiJDM5t (ORCPT ); Tue, 4 Oct 2022 08:57:49 -0400 Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E3CEB865 for ; Tue, 4 Oct 2022 05:54:57 -0700 (PDT) Received: by mail-wr1-x429.google.com with SMTP id c11so21189485wrp.11 for ; Tue, 04 Oct 2022 05:54:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PkPNtuib5iRHSYoXuvCITszxB1jeo5nPeYiHHZL01UU=; b=aKbbnZoDBY06Fjy3RSKQhfzAXP/Fpd7Z0NocPlMkBTEjqE9KysXAj0smHAg6k5bZ52 G3kcQkx0Y+fM9LPYRSAHWxnErO5LuGtgSVK5VU7qtIpqFjFr8isprkSzhfCKvlZNg5Uc bblamli2YxIlhbGYCKmlXDAzxtU1rW+o67ONYWDWlTadw7ufy/9sA5vbxKE5/l3KtwTE z2gYoyV1NmPHkKI13GaBFPLMSiD5exh43C6GJXFeIVNiDI/a1bE/3dHN4HF/N3uh3LPY CplV3F1T6nmpxOHlfxlj29KE5vlrZJQcjHRWqW7O8bdocUUXeHQeZbuxNPrGVVl6tSYg r5TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PkPNtuib5iRHSYoXuvCITszxB1jeo5nPeYiHHZL01UU=; b=HwQ8yyH47N6loqNc08vkuq2XV+l0WB631AqcqptjIjQmEDEDNsuTgPOz54CRz+GmCQ ZK1OYFwvDKgZ+1tq14k4CEA0+QtWUA41bDQKCfpq17Ilie7YaFdDh9c4Hh14JbYZukcd Ki+teNKEywL/LsTRPXc7ey4jU9kuyIgMo24C6oySbQ3X1nbZ6z05/R+eY1R43kYUul3D QUgWCEOHT+shqS4AKOr96LU3+l/ZwpnfIPkjf5F7Y0jaJqSwnwegHtZ1YSTBZkHc5/O3 2PkkeWZxTPTgDYlusIolCZPKMElQtb7oLg/PMQi/V2NR007ofTjrhK5bLC4+JxWjqJSn pNjg== X-Gm-Message-State: ACrzQf0z/c9fHNAJoUoupZetwp8CcF6rIpiGp72QurBatSmEjX9M37P+ M5oIlBk/xUM0lozc9rs8DaX+nQ== X-Google-Smtp-Source: AMsMyM6zkuocVUmsW5crCUEXtpbvBS7DDgsVlES5Am7dCaMtOQ/Tak12eHP2HL2OCi1vm5tQZq3p3Q== X-Received: by 2002:a5d:588f:0:b0:22b:5cc:e1d3 with SMTP id n15-20020a5d588f000000b0022b05cce1d3mr15148579wrf.142.1664888095272; Tue, 04 Oct 2022 05:54:55 -0700 (PDT) Received: from maple.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id w10-20020a05600c474a00b003b4ac05a8a4sm25305803wmo.27.2022.10.04.05.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Oct 2022 05:54:54 -0700 (PDT) Date: Tue, 4 Oct 2022 13:54:51 +0100 From: Daniel Thompson To: Linus Walleij Cc: Dmitry Torokhov , Sascha Hauer , Krzysztof Kozlowski , Rob Herring , Lee Jones , Jingoo Han , Shawn Guo , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 04, 2022 at 11:02:06AM +0200, Linus Walleij wrote: > On Wed, Sep 28, 2022 at 12:32 AM Dmitry Torokhov > wrote: > > > Properties describing GPIOs should be named as "-gpios" or > > "-gpio", and that is what gpiod API expects, however the > > driver uses non-standard "gpios-reset" name. Let's adjust this, and also > > note that the reset line is active low as that is also important to > > gpiod API. > > > > Signed-off-by: Dmitry Torokhov > > I think the gods of Open Firmware will try to punish you for such > incompatible changes. But I have long since renounced them. > > > Another option is to add another quirk into gpiolib-of.c, but we > > may end up with a ton of them once we convert everything away from > > of_get_named_gpio() to gpiod API, so I'd prefer not doing that. > > We need to know if i.MX is shipping device trees stored in flash, > or if they bundle it with the kernel. This part is frequently found in add-on boards so it's not purely an i.MX-only question. > In the former case, you have to add quirks, in the latter case this > patch is fine. > > Sascha, what does the Freescale maintainer say? IMHO for not-in-the-soc devices like this the presence of in-kernel DTs isn't enough to make a decision. What is needed is a degree of due-diligence to show that there are no obvious out-of-kernel users. To be honest, I suspect the due-diligence checks will probably yield a green light for this one. Most of the tutorials for the popular HX8357 devices, show how to run python code in userspace that sends raw SPI commands. That sucks but at least it doesn't raise any concerns about bindings maintenance. Daniel.