Re: [PATCH v4] target/i386: Fix model number of Zhaoxin YongFeng vCPU template

[Zhao Liu <zhao1.liu@intel.com>]

On Mon, Apr 14, 2025 at 10:45:44PM -0400, Ewan Hai wrote:
> Date: Mon, 14 Apr 2025 22:45:44 -0400
> From: Ewan Hai <ewanhai-oc@zhaoxin.com>
> Subject: [PATCH v4] target/i386: Fix model number of Zhaoxin YongFeng vCPU
>  template
> X-Mailer: git-send-email 2.34.1
> 
> The model number was mistakenly set to 0x0b (11) in commit ff04bc1ac4.
> The correct value is 0x5b. This mistake occurred because the extended
> model bits in cpuid[eax=0x1].eax were overlooked, and only the base
> model was used.
> 
> Using the wrong model number can affect guest behavior. One known issue
> is that vPMU (which relies on the model number) may fail to operate
> correctly.
> 
> This patch corrects the model field by introducing a new vCPU version.
> 
> Additionally, it adds a "Preferred CPU models for Zhaoxin x86 hosts"
> section in docs/system/cpu-models-x86.rst.inc to recommend the
> appropriate Zhaoxin CPU model(s).
> 
> Fixes: ff04bc1ac4 ("target/i386: Introduce Zhaoxin Yongfeng CPU model")
> Signed-off-by: Ewan Hai <ewanhai-oc@zhaoxin.com>

LGTM,

> Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Thanks,
Zhao