All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jorge Ramirez <jorge.ramirez@oss.qualcomm.com>
To: neil.armstrong@linaro.org
Cc: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
	caleb.connolly@linaro.org, sumit.garg@kernel.org,
	u-boot-qcom@groups.io, u-boot@lists.denx.de
Subject: Re: [PATCH 3/5] clk/qcom: apq8096: fix the sdhci clock
Date: Mon, 7 Apr 2025 16:17:09 +0200	[thread overview]
Message-ID: <Z/PeZVBhwcNOVRAD@trex> (raw)
In-Reply-To: <ca4b11e9-4bd0-4a9b-9980-ff2367f8c43f@linaro.org>

On 07/04/25 14:36:51, neil.armstrong@linaro.org wrote:
> On 07/04/2025 14:05, Jorge Ramirez-Ortiz wrote:
> > Select the right clock for sdhci.
> > 
> > Signed-off-by: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>
> > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
> > ---
> >   drivers/clk/qcom/clock-apq8096.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/clk/qcom/clock-apq8096.c b/drivers/clk/qcom/clock-apq8096.c
> > index bc00826a5e8..551f52d5197 100644
> > --- a/drivers/clk/qcom/clock-apq8096.c
> > +++ b/drivers/clk/qcom/clock-apq8096.c
> > @@ -83,7 +83,7 @@ static ulong apq8096_clk_set_rate(struct clk *clk, ulong rate)
> >   	struct msm_clk_priv *priv = dev_get_priv(clk->dev);
> >   	switch (clk->id) {
> > -	case GCC_SDCC1_APPS_CLK: /* SDC1 */
> > +	case GCC_SDCC2_APPS_CLK: /* SDC2 */
> 
> Should be GCC_SDCC2_AHB_CLK

why? also if I do that, mcc fails to probe

> 
> >   		return clk_init_sdc(priv, rate);
> >   		break;
> >   	case GCC_BLSP2_UART2_APPS_CLK: /*UART2*/
> 

  reply	other threads:[~2025-04-07 14:17 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 12:05 [PATCH 1/5] board: qualcomm: dragonboard820c: udpate readme Jorge Ramirez-Ortiz
2025-04-07 12:05 ` [PATCH 2/5] clk/qcom: apq8096: fix set rate for the uart clock Jorge Ramirez-Ortiz
2025-04-07 14:25   ` Caleb Connolly
2025-04-07 12:05 ` [PATCH 3/5] clk/qcom: apq8096: fix the sdhci clock Jorge Ramirez-Ortiz
2025-04-07 12:36   ` neil.armstrong
2025-04-07 14:17     ` Jorge Ramirez [this message]
2025-04-07 14:27       ` Caleb Connolly
2025-04-07 15:12       ` neil.armstrong
2025-04-07 15:27         ` Jorge Ramirez
2025-04-07 12:05 ` [PATCH 4/5] clk: stub: add qcom,glink-smd-rpm Jorge Ramirez-Ortiz
2025-04-07 12:36   ` Sumit Garg
2025-04-07 12:37   ` neil.armstrong
2025-04-07 14:18     ` Jorge Ramirez
2025-04-07 12:05 ` [PATCH 5/5] configs: dragonboard820: updates Jorge Ramirez-Ortiz
2025-04-07 12:50 ` [PATCH 1/5] board: qualcomm: dragonboard820c: udpate readme Christopher Obbard
2025-04-07 14:22   ` Jorge Ramirez
2025-04-07 14:25 ` Caleb Connolly
  -- strict thread matches above, loose matches on Subject: below --
2025-04-07 17:56 [PATCH 1/5] board: qualcomm: dragonboard820c: update readme Jorge Ramirez-Ortiz
2025-04-07 17:56 ` [PATCH 3/5] clk/qcom: apq8096: fix the sdhci clock Jorge Ramirez-Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z/PeZVBhwcNOVRAD@trex \
    --to=jorge.ramirez@oss.qualcomm.com \
    --cc=caleb.connolly@linaro.org \
    --cc=neil.armstrong@linaro.org \
    --cc=sumit.garg@kernel.org \
    --cc=u-boot-qcom@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.