All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, Bingbu Cao <bingbu.cao@intel.com>
Subject: Re: [PATCH 2/7] media: intel/ipu6: Remove line_align
Date: Thu, 10 Apr 2025 15:12:40 +0200	[thread overview]
Message-ID: <Z/fDyNb2evbxipY+@linux.intel.com> (raw)
In-Reply-To: <Z_ezvvBNtpcZlAXW@kekkonen.localdomain>

On Thu, Apr 10, 2025 at 12:04:14PM +0000, Sakari Ailus wrote:
> Hi Stanislaw,
> 
> Thanks for the set.
> 
> On Mon, Apr 07, 2025 at 03:40:32PM +0200, Stanislaw Gruszka wrote:
> > isys->line_align value is only used in one place and we can just use
> > the proper value directly there.
> > 
> > Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>
> > ---
> >  drivers/media/pci/intel/ipu6/ipu6-isys-video.c | 2 +-
> >  drivers/media/pci/intel/ipu6/ipu6-isys.c       | 1 -
> >  drivers/media/pci/intel/ipu6/ipu6-isys.h       | 4 ----
> >  3 files changed, 1 insertion(+), 6 deletions(-)
> > 
> > diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> > index e36a21aa9040..3165904d7ebf 100644
> > --- a/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> > +++ b/drivers/media/pci/intel/ipu6/ipu6-isys-video.c
> > @@ -241,7 +241,7 @@ static void ipu6_isys_try_fmt_cap(struct ipu6_isys_video *av, u32 type,
> >  	else
> >  		*bytesperline = DIV_ROUND_UP(*width * pfmt->bpp, BITS_PER_BYTE);
> >  
> > -	*bytesperline = ALIGN(*bytesperline, av->isys->line_align);
> > +	*bytesperline = ALIGN(*bytesperline, 64);
> 
> Is this value the same for ipu7?

Yes.

Regards
Stanislaw

  reply	other threads:[~2025-04-10 13:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-07 13:40 [PATCH 0/7] media: intel/ipu6: continue on ipu7 code sharing preparation Stanislaw Gruszka
2025-04-07 13:40 ` [PATCH 1/7] media: intel/ipu6: Use isd name in isys.h Stanislaw Gruszka
2025-04-07 13:40 ` [PATCH 2/7] media: intel/ipu6: Remove line_align Stanislaw Gruszka
2025-04-10 12:04   ` Sakari Ailus
2025-04-10 13:12     ` Stanislaw Gruszka [this message]
2025-04-10 15:34       ` Sakari Ailus
2025-04-07 13:40 ` [PATCH 3/7] media: intel/ipu6: Move common structures definitions to isys.h Stanislaw Gruszka
2025-04-07 13:40 ` [PATCH 4/7] media: intel/ipu6: Rename common structures Stanislaw Gruszka
2025-04-07 13:40 ` [PATCH 5/7] media: intel/ipu6: Remove deprecated lock comment Stanislaw Gruszka
2025-04-07 13:40 ` [PATCH 6/7] media: intel/ipu6: Introduce isys and dev accessors macros Stanislaw Gruszka
2025-04-07 13:40 ` [PATCH 7/7] media: intel/ipu6: Start using accessors to get dev pointer Stanislaw Gruszka
2025-04-10 15:34 ` [PATCH 0/7] media: intel/ipu6: continue on ipu7 code sharing preparation Sakari Ailus
2025-04-14 10:11   ` Stanislaw Gruszka
2025-04-14 12:52     ` Sakari Ailus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z/fDyNb2evbxipY+@linux.intel.com \
    --to=stanislaw.gruszka@linux.intel.com \
    --cc=bingbu.cao@intel.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.