From: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
To: Tony Nguyen <anthony.l.nguyen@intel.com>
Cc: Simon Horman <horms@kernel.org>,
Michal Swiatkowski <michal.swiatkowski@linux.intel.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
Pavan Kumar Linga <pavan.kumar.linga@intel.com>,
Aleksandr Loktionov <aleksandr.loktionov@intel.com>
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v1] idpf: fix potential memory leak on kcalloc() failure
Date: Fri, 11 Apr 2025 07:09:47 +0200 [thread overview]
Message-ID: <Z/ikGxzPOysJZvUh@mev-dev.igk.intel.com> (raw)
In-Reply-To: <bcf8dcc5-527d-41ae-95e4-3c0b6439d959@intel.com>
On Thu, Apr 10, 2025 at 03:04:16PM -0700, Tony Nguyen wrote:
> On 4/7/2025 3:43 AM, Simon Horman wrote:
> > On Fri, Apr 04, 2025 at 12:54:21PM +0200, Michal Swiatkowski wrote:
> > > In case of failing on rss_data->rss_key allocation the function is
> > > freeing vport without freeing earlier allocated q_vector_idxs. Fix it.
> > >
> > > Move from freeing in error branch to goto scheme.
> > >
> > > Fixes: 95af467d9a4e ("idpf: configure resources for RX queues")
> >
> > Hi Michal,
> >
> > WRT leaking q_vector_indxs, that allocation is not present at
> > the commit cited above, so I think the correct Fixes tag for
> > that problem is the following, where that allocation was added:
> >
> > Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport")
>
> Patch applied. I do agree with Simon's assessment so plan to use this fixes.
>
Thanks Tony, I also agree.
> Thanks,
> Tony
>
next prev parent reply other threads:[~2025-04-11 5:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-04 10:54 [Intel-wired-lan] [PATCH iwl-net v1] idpf: fix potential memory leak on kcalloc() failure Michal Swiatkowski
2025-04-04 10:54 ` Michal Swiatkowski
2025-04-07 10:43 ` [Intel-wired-lan] " Simon Horman
2025-04-07 10:43 ` Simon Horman
2025-04-10 22:04 ` [Intel-wired-lan] " Tony Nguyen
2025-04-11 5:09 ` Michal Swiatkowski [this message]
2025-04-11 5:09 ` Michal Swiatkowski
2025-04-11 5:09 ` Michal Swiatkowski
2025-04-11 15:51 ` [Intel-wired-lan] " Simon Horman
2025-04-11 15:51 ` Simon Horman
2025-04-25 16:49 ` [Intel-wired-lan] " Salin, Samuel
2025-04-25 16:49 ` Salin, Samuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z/ikGxzPOysJZvUh@mev-dev.igk.intel.com \
--to=michal.swiatkowski@linux.intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=horms@kernel.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=netdev@vger.kernel.org \
--cc=pavan.kumar.linga@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.