From: Baoquan He <bhe@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
agruenba@redhat.com, gfs2@lists.linux.dev
Cc: linux-mm@kvack.org, david@redhat.com, osalvador@suse.de,
yanjun.zhu@linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/4] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable()
Date: Fri, 11 Apr 2025 13:32:44 +0800 [thread overview]
Message-ID: <Z/ipfCofBe99Ie+7@MiWiFi-R3L-srv> (raw)
In-Reply-To: <20250410204338.4b2101afdf18d8898390ef58@linux-foundation.org>
On 04/10/25 at 08:43pm, Andrew Morton wrote:
> On Thu, 10 Apr 2025 11:57:14 +0800 Baoquan He <bhe@redhat.com> wrote:
>
> > Not like fault_in_readable() or fault_in_writeable(), in
> > fault_in_safe_writeable() local variable 'start' is increased page
> > by page to loop till the whole address range is handled. However,
> > it mistakenly calcalates the size of handled range with 'uaddr - start'.
>
> What are the userspace-visible runtime effects of this change?
I see it mainly affect gfs2_file_direct_read(). Not sure if GFS2 people
can sense any exceptional behaviour caused by this code bug.
>
next prev parent reply other threads:[~2025-04-11 5:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 3:57 [PATCH v4 0/4] mm/gup: Minor fix, cleanup and improvements Baoquan He
2025-04-10 3:57 ` [PATCH v4 1/4] mm/gup: fix wrongly calculated returned value in fault_in_safe_writeable() Baoquan He
2025-04-10 8:31 ` Oscar Salvador
2025-04-11 3:43 ` Andrew Morton
2025-04-11 5:32 ` Baoquan He [this message]
2025-04-11 15:07 ` Andreas Gruenbacher
2025-04-11 23:22 ` Andrew Morton
2025-04-11 8:44 ` David Hildenbrand
2025-04-10 3:57 ` [PATCH v4 2/4] mm/gup: remove unneeded checking in follow_page_pte() Baoquan He
2025-04-10 3:57 ` [PATCH v4 3/4] mm/gup: remove gup_fast_pgd_leaf() and clean up the relevant codes Baoquan He
2025-04-10 3:57 ` [PATCH v4 4/4] mm/gup: clean up codes in fault_in_xxx() functions Baoquan He
2025-04-11 8:54 ` David Hildenbrand
2025-04-11 11:15 ` Baoquan He
2025-04-11 11:41 ` David Hildenbrand
2025-04-13 1:07 ` Baoquan He
2025-04-13 20:02 ` David Hildenbrand
2025-04-13 2:04 ` [PATCH v5 " Baoquan He
2025-04-13 20:09 ` David Hildenbrand
2025-04-14 3:44 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z/ipfCofBe99Ie+7@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=agruenba@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=gfs2@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=osalvador@suse.de \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.