From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6713CC3601A for ; Fri, 4 Apr 2025 15:45:16 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1u0jEF-00059d-GA; Fri, 04 Apr 2025 11:45:11 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0jEE-00058v-1R; Fri, 04 Apr 2025 11:45:10 -0400 Received: from ssh.movementarian.org ([139.162.205.133] helo=movementarian.org) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1u0jEC-0000oQ-KK; Fri, 04 Apr 2025 11:45:09 -0400 Received: from movement by movementarian.org with local (Exim 4.95) (envelope-from ) id 1u0jEA-006OmV-VS; Fri, 04 Apr 2025 16:45:06 +0100 Date: Fri, 4 Apr 2025 16:45:06 +0100 From: John Levon To: =?iso-8859-1?Q?C=E9dric?= Le Goater Cc: qemu-devel@nongnu.org, Jason Herne , Thanos Makatos , Halil Pasic , Daniel =?iso-8859-1?Q?P=2E_Berrang=E9?= , Eric Farman , Tony Krowiak , Thomas Huth , qemu-s390x@nongnu.org, Matthew Rosato , Paolo Bonzini , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Stefano Garzarella , Alex Williamson , David Hildenbrand , Peter Xu , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , "Michael S. Tsirkin" Subject: Re: [PATCH v8 05/28] vfio: add vfio_prepare_device() Message-ID: References: <20250219144858.266455-1-john.levon@nutanix.com> <20250219144858.266455-6-john.levon@nutanix.com> <3369ecab-21ea-4198-9ffa-73307a795f69@redhat.com> <46d85400-7073-463e-b61a-73731270a6c0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <46d85400-7073-463e-b61a-73731270a6c0@redhat.com> X-Url: http://www.movementarian.org/ Received-SPF: pass client-ip=139.162.205.133; envelope-from=movement@movementarian.org; helo=movementarian.org X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Apr 04, 2025 at 05:41:54PM +0200, Cédric Le Goater wrote: > > > > +void vfio_prepare_device(VFIODevice *vbasedev, VFIOContainerBase *bcontainer, > > > > + VFIOGroup *group, struct vfio_device_info *info) > > > > > > I would prefer that the first version did not have a 'group' parameter. > > > Let's add it when needed. > > > > I think you mean something like this in hw/vfio/container.c: > > > > vfio_prepare_device(vbasedev, &group->container->bcontainer, info); > > > > vbasedev->group = group; > > QLIST_INSERT_HEAD(&group->device_list, vbasedev, next); > > > > As it's the only consumer that actually wants a group. > yes. It's a vfio legacy only construct. We will see what to do > if vfio-user needs it. vfio-user is not going to need it for sure, so sounds good to me. regards john