From: John Levon <levon@movementarian.org>
To: "Cédric Le Goater" <clg@redhat.com>
Cc: qemu-devel@nongnu.org, "Jason Herne" <jjherne@linux.ibm.com>,
"Thanos Makatos" <thanos.makatos@nutanix.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Eric Farman" <farman@linux.ibm.com>,
"Tony Krowiak" <akrowiak@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-s390x@nongnu.org, "Matthew Rosato" <mjrosato@linux.ibm.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Stefano Garzarella" <sgarzare@redhat.com>,
"Alex Williamson" <alex.williamson@redhat.com>,
"David Hildenbrand" <david@redhat.com>,
"Peter Xu" <peterx@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Jagannathan Raman" <jag.raman@oracle.com>,
"John Johnson" <john.g.johnson@oracle.com>,
"Elena Ufimtseva" <elena.ufimtseva@oracle.com>
Subject: Re: [PATCH v8 09/28] vfio: split out VFIOKernelPCIDevice
Date: Thu, 3 Apr 2025 19:08:09 +0100 [thread overview]
Message-ID: <Z+7Oif+ZTFRYBqXa@movementarian.org> (raw)
In-Reply-To: <52ecc629-4138-4436-bc38-b5f427dd3d7f@redhat.com>
On Thu, Apr 03, 2025 at 07:13:30PM +0200, Cédric Le Goater wrote:
> On 2/19/25 15:48, John Levon wrote:
> > From: Jagannathan Raman <jag.raman@oracle.com>
> >
> > Split out code specific to the kernel-side vfio implementation from the
> > VFIOPCIDevice class into a VFIOKernelPCIDevice. The forthcoming
> > VFIOUserPCIDevice will share the base VFIOPCIDevice class.
>
> The new VFIOKernelPCIDevice struct is not needed. Please drop it.
I presume the idea was if something was ever needed in the struct that was
kernel vfio specific, it could go there. But sure.
> I am not sure the new TYPE_VFIO_PCI_BASE class is needed too.
> Are the properties the only difference ?
I'm not sure if you're talking about the type specifically (a bit sketchy on how
qemu's klass/type system works) or the existence of the base/kernel/user
separation at all.
If it's possible to set up vfio_user_pci_dev_info and its callbacks without
needing a sub-type then maybe not? Honestly I'm not really sure why we have
sub-classes and inheritance like this.
regards
john
next prev parent reply other threads:[~2025-04-03 18:08 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 14:48 [PATCH v8 00/28] vfio-user client John Levon
2025-02-19 14:48 ` [PATCH v8 01/28] vfio/container: pass MemoryRegion to DMA operations John Levon
2025-04-02 16:44 ` Cédric Le Goater
2025-02-19 14:48 ` [PATCH v8 02/28] vfio/container: pass listener_begin/commit callbacks John Levon
2025-04-02 12:30 ` Cédric Le Goater
2025-02-19 14:48 ` [PATCH v8 03/28] vfio/container: support VFIO_DMA_UNMAP_FLAG_ALL John Levon
2025-04-02 16:49 ` Cédric Le Goater
2025-04-03 9:45 ` John Levon
2025-04-04 15:43 ` Cédric Le Goater
2025-02-19 14:48 ` [PATCH v8 04/28] vfio: add vfio_attach_device_by_iommu_type() John Levon
2025-04-02 16:52 ` Cédric Le Goater
2025-02-19 14:48 ` [PATCH v8 05/28] vfio: add vfio_prepare_device() John Levon
2025-04-03 9:19 ` Cédric Le Goater
2025-04-03 9:34 ` John Levon
2025-04-04 15:41 ` Cédric Le Goater
2025-04-04 15:45 ` John Levon
2025-02-19 14:48 ` [PATCH v8 06/28] vfio: refactor out vfio_interrupt_setup() John Levon
2025-04-03 9:23 ` Cédric Le Goater
2025-04-03 9:38 ` John Levon
2025-02-19 14:48 ` [PATCH v8 07/28] vfio: refactor out vfio_pci_config_setup() John Levon
2025-04-03 9:30 ` Cédric Le Goater
2025-02-19 14:48 ` [PATCH v8 08/28] vfio: add region cache John Levon
2025-04-03 15:46 ` Cédric Le Goater
2025-04-03 16:00 ` John Levon
2025-04-04 16:57 ` Cédric Le Goater
2025-04-04 17:18 ` John Levon
2025-04-08 13:48 ` John Levon
2025-02-19 14:48 ` [PATCH v8 09/28] vfio: split out VFIOKernelPCIDevice John Levon
2025-04-03 17:13 ` Cédric Le Goater
2025-04-03 18:08 ` John Levon [this message]
2025-04-04 12:49 ` Cédric Le Goater
2025-04-04 14:21 ` John Levon
2025-04-04 14:48 ` Cédric Le Goater
2025-04-04 15:44 ` John Levon
2025-02-19 14:48 ` [PATCH v8 10/28] vfio: add device IO ops vector John Levon
2025-04-04 14:36 ` Cédric Le Goater
2025-04-04 15:53 ` John Levon
2025-02-19 14:48 ` [PATCH v8 11/28] vfio-user: introduce vfio-user protocol specification John Levon
2025-02-19 14:48 ` [PATCH v8 12/28] vfio-user: add vfio-user class and container John Levon
2025-02-19 14:48 ` [PATCH v8 13/28] vfio-user: connect vfio proxy to remote server John Levon
2025-02-19 14:48 ` [PATCH v8 14/28] vfio-user: implement message receive infrastructure John Levon
2025-02-19 14:48 ` [PATCH v8 15/28] vfio-user: implement message send infrastructure John Levon
2025-02-19 14:48 ` [PATCH v8 16/28] vfio-user: implement VFIO_USER_DEVICE_GET_INFO John Levon
2025-02-19 14:48 ` [PATCH v8 17/28] vfio-user: implement VFIO_USER_DEVICE_GET_REGION_INFO John Levon
2025-02-19 14:48 ` [PATCH v8 18/28] vfio-user: implement VFIO_USER_REGION_READ/WRITE John Levon
2025-02-19 14:48 ` [PATCH v8 19/28] vfio-user: set up PCI in vfio_user_pci_realize() John Levon
2025-02-19 14:48 ` [PATCH v8 20/28] vfio-user: implement VFIO_USER_DEVICE_GET/SET_IRQ* John Levon
2025-02-19 14:48 ` [PATCH v8 21/28] vfio-user: forward MSI-X PBA BAR accesses to server John Levon
2025-02-19 14:48 ` [PATCH v8 22/28] vfio-user: set up container access to the proxy John Levon
2025-02-19 14:48 ` [PATCH v8 23/28] vfio-user: implement VFIO_USER_DEVICE_RESET John Levon
2025-02-19 14:48 ` [PATCH v8 24/28] vfio-user: implement VFIO_USER_DMA_MAP/UNMAP John Levon
2025-02-19 14:48 ` [PATCH v8 25/28] vfio-user: implement VFIO_USER_DMA_READ/WRITE John Levon
2025-02-19 14:48 ` [PATCH v8 26/28] vfio-user: add 'no-direct-dma' option John Levon
2025-02-19 14:48 ` [PATCH v8 27/28] vfio-user: add 'x-msg-timeout' option John Levon
2025-02-19 14:48 ` [PATCH v8 28/28] vfio-user: add coalesced posted writes John Levon
2025-02-28 17:09 ` [PATCH v8 00/28] vfio-user client Jag Raman
2025-03-03 11:19 ` John Levon
2025-03-03 15:39 ` Jag Raman
2025-03-14 14:25 ` Cédric Le Goater
2025-03-14 14:48 ` Steven Sistare
2025-03-18 10:00 ` Cédric Le Goater
2025-03-14 15:13 ` John Levon
2025-03-18 10:02 ` Cédric Le Goater
2025-04-04 17:21 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z+7Oif+ZTFRYBqXa@movementarian.org \
--to=levon@movementarian.org \
--cc=akrowiak@linux.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=berrange@redhat.com \
--cc=clg@redhat.com \
--cc=david@redhat.com \
--cc=elena.ufimtseva@oracle.com \
--cc=farman@linux.ibm.com \
--cc=jag.raman@oracle.com \
--cc=jjherne@linux.ibm.com \
--cc=john.g.johnson@oracle.com \
--cc=marcandre.lureau@redhat.com \
--cc=mjrosato@linux.ibm.com \
--cc=mst@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=thanos.makatos@nutanix.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.