All of lore.kernel.org
 help / color / mirror / Atom feed
From: Uday Shankar <ushankar@purestorage.com>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	io-uring@vger.kernel.org, linux-block@vger.kernel.org,
	Pavel Begunkov <asml.silence@gmail.com>,
	Caleb Sander Mateos <csander@purestorage.com>
Subject: Re: [PATCH] selftests: ublk: fix test_stripe_04
Date: Thu, 3 Apr 2025 19:09:37 -0600	[thread overview]
Message-ID: <Z+8xUR/Ocbmorisk@dev-ushankar.dev.purestorage.com> (raw)
In-Reply-To: <20250404001849.1443064-1-ming.lei@redhat.com>

On Fri, Apr 04, 2025 at 08:18:49AM +0800, Ming Lei wrote:
> Commit 57ed58c13256 ("selftests: ublk: enable zero copy for stripe target")
> added test entry of test_stripe_04, but forgot to add the test script.
> 
> So fix the test by adding the script file.
> 
> Reported-by: Uday Shankar <ushankar@purestorage.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>

Reviewed-by: Uday Shankar <ushankar@purestorage.com>

Thanks for the quick fix!

> ---
>  .../testing/selftests/ublk/test_stripe_04.sh  | 24 +++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100755 tools/testing/selftests/ublk/test_stripe_04.sh
> 
> diff --git a/tools/testing/selftests/ublk/test_stripe_04.sh b/tools/testing/selftests/ublk/test_stripe_04.sh
> new file mode 100755
> index 000000000000..1f2b642381d1
> --- /dev/null
> +++ b/tools/testing/selftests/ublk/test_stripe_04.sh
> @@ -0,0 +1,24 @@
> +#!/bin/bash
> +# SPDX-License-Identifier: GPL-2.0
> +
> +. "$(cd "$(dirname "$0")" && pwd)"/test_common.sh
> +
> +TID="stripe_04"
> +ERR_CODE=0
> +
> +_prep_test "stripe" "mkfs & mount & umount on zero copy"
> +
> +backfile_0=$(_create_backfile 256M)
> +backfile_1=$(_create_backfile 256M)
> +dev_id=$(_add_ublk_dev -t stripe -z -q 2 "$backfile_0" "$backfile_1")
> +_check_add_dev $TID $? "$backfile_0" "$backfile_1"
> +
> +_mkfs_mount_test /dev/ublkb"${dev_id}"
> +ERR_CODE=$?
> +
> +_cleanup_test "stripe"
> +
> +_remove_backfile "$backfile_0"
> +_remove_backfile "$backfile_1"
> +
> +_show_result $TID $ERR_CODE
> -- 
> 2.47.1
> 

  reply	other threads:[~2025-04-04  1:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04  0:18 [PATCH] selftests: ublk: fix test_stripe_04 Ming Lei
2025-04-04  1:09 ` Uday Shankar [this message]
2025-04-04  2:19 ` Jens Axboe
2025-04-04  3:46   ` Ming Lei
2025-04-04 12:37     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Z+8xUR/Ocbmorisk@dev-ushankar.dev.purestorage.com \
    --to=ushankar@purestorage.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=io-uring@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.