Re: [PATCH v4 05/12] tpm2_key_protector: Unseal key from a buffer

[Daniel Kiper via Grub-devel <grub-devel@gnu.org>]

On Fri, Mar 21, 2025 at 03:59:01PM +0800, Gary Lin wrote:
> Extract the logic to handle the file buffer from the SRK recover
> function to prepare to load the sealed key from the NV index handle,
> so the NV index mode can share the same code path in the later patch.
> The SRK recover function now only reads the file and sends the file
> buffer to the new function.
>
> Besides this, to avoid introducing more options for the NV index mode,
> the file format is detected automatically before unmarshalling the data,
> so there is no need to use the command option to specify the file format
> anymore. In other words, '--tpm2key' and '--keyfile' are the same now.

You are referring to long options in the commit message but documentation
updates doing some stuff around short ones. I can understand they are
equivalent but I think you should be consistent and use short form
everywhere or both in the commit message.

Additionally, it seems to me the docs mention short or long options but
do not show there are some equivalents. Am I right? If yes I think this
should be fixed in separate patch.

Daniel

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel